Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ListenAndServe(addr, nil) #47

Open
grazzini opened this issue Jun 12, 2017 · 0 comments
Open

Fix ListenAndServe(addr, nil) #47

grazzini opened this issue Jun 12, 2017 · 0 comments

Comments

@grazzini
Copy link

The main example from the package comment doesn't work:

    http.Handle("/hello", func(w http.ResponseWriter, r *http.Request) {
      w.Write([]byte("Hello\n"))
    })

    log.Fatal(manners.ListenAndServe(":8080", nil))

This gives the panic mentioned in #39.

(See also #40, but IMHO it would be better to make this work than to show a workaround in the README.)

grazzini added a commit to grazzini/manners that referenced this issue Jun 12, 2017
Fix for braintree#47 - makes ListenAndServe et al drop-in replacements
for the corresponding methods in net/http.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant