Fix Samsung Internet Browser formatting #110
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cgdibble
approved these changes
Apr 8, 2024
doniarobinson
force-pushed
the
fix_samsung_browser_formatting
branch
from
fd54a68
to
9cdfa52
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is specifically to fix a bug noted in issue LI-35763 where, in Samsung Internet Browser only, the expiration date was not automatically adding a forward slash and there was no way a user could add it. Because of this, later on in the process (after the submit button was pressed), the date was not validating correctly so the transaction would not go through successfully.
To test: create a sample application with card fields and test locally with BrowserStack (use domain bs-local.com). Choose an Android device with Samsung Internet Browser. Fill in the date using only the phone keypad and ensure the forward slash gets added in automatically.
Integration tests aren’t currently working, but it is recommended to come back and add integration tests for the validation of expiration date in Samsung Internet Browser and several other browsers.
Broken:
