Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added manufacturer alias. Added model IDs to device aliases. #2867

Closed
wants to merge 3 commits into from

Conversation

michalk-k
Copy link
Contributor

@michalk-k michalk-k commented Dec 28, 2024

Co-authored-by: Bram Gerritsen <bgerritsen@gmail.com>
@bramstroker
Copy link
Owner

@michalk-k I'm waiting a bit before merging this PR.
In latest beta v1.17.0-beta.0 I have implemented per device discovery, which applies to this profile.
When we merge this now already this will cause this profile to be discovered for all sensor.* entities under 3EM device.
So when I release v1.17.0 stable and give it a few days to be installed by users I will merge this MR.

@michalk-k
Copy link
Contributor Author

makes sense. Thank you

BTW there are devices like Shelly 2.5 which have two relays.
In such case there will be device self consumption + each relay might take a bit more.
will new version take care about such setup?

@bramstroker
Copy link
Owner

makes sense. Thank you

BTW there are devices like Shelly 2.5 which have two relays. In such case there will be device self consumption + each relay might take a bit more. will new version take care about such setup?

There is this strategy: https://docs.powercalc.nl/strategies/multi-switch/
Which should fit this use case.
However it's not supported in the library yet.
It's not straightforward as the underlying entities (naming etc) differ per installation.
So there must be some selection possibility for the user, to select the relevant entities.
Have some ideas about that, see my latest comment I just posted at #2755.
Or alternatively we might pick all switch.* entities from the same device in this scenario.
But for both developments are needed, so currently not supported.

Could you make an issue with some more information about the device, which entities you have in your system etc.
Than we can do further communication there, and it stays on my radar.

@bramstroker
Copy link
Owner

Just noticed I have already implemented support for multi_switch in library some time ago.
See: https://github.com/bramstroker/homeassistant-powercalc/blob/master/profile_library/tp-link/HS300/model.json

Using this strategy user will be provided with an extra step during discovery configuration where he/she can choose the individual switch entities which make up the device.

So you can already supply Shelly 2.5 profile using similar configuration.

I might implement automatic selection of device switch entities in the config flow, so it is less manual setup for the user.
But the JSON for the profile won't change. So you can go ahead and make the profile.

@bramstroker
Copy link
Owner

Auto populating switch devices during discovery flow also implemented with #2876.
Is released in latest beta: v1.17.0-beta.2
This will be the last added feature for the v1.17 version. When no issues arise during this and next week I will release stable.

@bramstroker
Copy link
Owner

bramstroker commented Jan 7, 2025

This PR can be closed @michalk-k ?
As it's superseeded by #2902

@michalk-k
Copy link
Contributor Author

Yes, my fault I forgot about that.

@michalk-k michalk-k closed this Jan 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants