Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Duplicate Upload Start Broadcasts and Update Upload Progress Handling #456

Merged
merged 1 commit into from
Sep 18, 2024

Conversation

brand-it
Copy link
Owner

These changes optimize the upload process by preventing unnecessary event broadcasts, ensuring accurate progress tracking, and improving overall system efficiency.

Changelog:

  • Eliminated Redundant Upload Start Events:

    • Removed duplicate calls to broadcast(:upload_started) in Ftp::UploadMkvService.
    • Adjusted upload_ready method in UploadProgressListener to prevent redundant invocation of upload_started.
  • Improved Upload Progress Tracking:

    • Ensured job.metadata['completed'] is accurately initialized and updated.
    • Fixed the sequence of setting job.metadata['completed'] in upload_finished to use the correct value from video_blob.byte_size.
  • Updated Upload Worker Initialization:

    • Correctly instantiated UploadProgressListener with necessary parameters in UploadWorker.
  • Enhanced Video Blob Management:

    • Updated video_blob attributes (uploadable, uploaded_on) upon upload completion.

@brand-it brand-it merged commit 78b6c6b into main Sep 18, 2024
2 checks passed
@brand-it brand-it deleted the fixed-upload-progress-bar branch September 18, 2024 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant