Fix Duplicate Upload Start Broadcasts and Update Upload Progress Handling #456
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes optimize the upload process by preventing unnecessary event broadcasts, ensuring accurate progress tracking, and improving overall system efficiency.
Changelog:
Eliminated Redundant Upload Start Events:
broadcast(:upload_started)
inFtp::UploadMkvService
.upload_ready
method inUploadProgressListener
to prevent redundant invocation ofupload_started
.Improved Upload Progress Tracking:
job.metadata['completed']
is accurately initialized and updated.job.metadata['completed']
inupload_finished
to use the correct value fromvideo_blob.byte_size
.Updated Upload Worker Initialization:
UploadProgressListener
with necessary parameters inUploadWorker
.Enhanced Video Blob Management:
video_blob
attributes (uploadable
,uploaded_on
) upon upload completion.