Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancements and Bug Fixes for Disk Title and Movie Services #466

Merged
merged 1 commit into from
Oct 8, 2024

Conversation

brand-it
Copy link
Owner

@brand-it brand-it commented Oct 8, 2024

This PR includes updates across several components to enhance functionality, fix bugs, and improve readability for disk titles, movie title components, and related services.

Summary of Changes:

  • Movie Title Table Component (movie_title_table_component.html.erb):
  • Updated table headers and duration formatting.
  • Added dynamic warnings for file size exceeding available disk space.
  • Config Model (config.rb):
  • Enhanced caching with Thread.current to store the latest updated configuration.
  • Added a method to clear the Rails cache effectively.
  • Disk Title Model (disk_title.rb):
  • Added angle, filename, and description attributes to better describe disk titles.
  • Create Disks Service (create_disks_service.rb):
  • Updated find_or_build_disk_title to improve matching logic with new attributes.
  • Disk Info Service (disk_info_service.rb):
  • Refactored TitleInfo class with new attributes and conversion utilities.
  • Enhanced find_or_init_title_info for improved type handling and data assignment.
  • Movie Disk Title Selector Service (movie_disk_title_selector_service.rb):
  • Updated extra_type and featured_file_disk_title logic for more precise title classification.
  • MKV Parser Toolbox (mkv_parser.rb):
  • Expanded TINFO_CODE_LEGEND with new codes to accommodate additional title metadata.
  • Refactored TINFO struct to handle complex title parsing and attribute mapping.
  • Database Migrations:
  • Added migrations to include angle, filename, and description attributes to disk_titles.
  • Spec Updates:
  • Updated factories and specs to include new attributes for disk_titles.
  • Refined tests for DiskInfoService to verify parsing and data extraction logic.

Additional:

  • Version Bump: Updated current_version.txt to v5.3.0.

These updates improve metadata handling, caching efficiency, and code readability across movie and disk services.

@brand-it brand-it merged commit bc5c6c9 into main Oct 8, 2024
2 checks passed
@brand-it brand-it deleted the general-upgrade branch October 8, 2024 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant