Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change how Android project path is handled #258

Closed
bweissbart opened this issue Oct 12, 2018 · 0 comments · Fixed by #829
Closed

Change how Android project path is handled #258

bweissbart opened this issue Oct 12, 2018 · 0 comments · Fixed by #829

Comments

@bweissbart
Copy link
Member

bweissbart commented Oct 12, 2018

Currently the Android project path is hardcoded to be "com.brandingbrand.reactnative.and.project_name" as specified in getNativeProjectPathAndriod [sic]:

function getNativeProjectPathAndriod(configuration: Config): string {
return resolvePathFromProject(
getMainPath(),
'java',
'com',
'brandingbrand',
'reactnative',
'and',
configuration.name.toLowerCase()
);
}

This value is used in a few places during Android init, such as constructing applicationId in build.gradle.

This is an issue for a couple of reasons:

  1. Because Flagship is now open source, application identifiers shouldn't be required to have "brandingbrand" in them
  2. We let apps define arbitrary bundle IDs in the bundleIds.android environment configuration, so it isn't obvious that the bundle ID actually needs to conform to a strict schema that consists of "com.brandingbrand.reactnative.and." followed by the name property in the environment configuration
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant