-
Notifications
You must be signed in to change notification settings - Fork 139
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change how Android project path is handled #258
Comments
This was referenced Sep 24, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Currently the Android project path is hardcoded to be "com.brandingbrand.reactnative.and.project_name" as specified in getNativeProjectPathAndriod [sic]:
flagship/packages/flagship/src/lib/path.ts
Lines 171 to 181 in 20a2b2e
This value is used in a few places during Android init, such as constructing applicationId in build.gradle.
This is an issue for a couple of reasons:
bundleIds.android
environment configuration, so it isn't obvious that the bundle ID actually needs to conform to a strict schema that consists of "com.brandingbrand.reactnative.and." followed by thename
property in the environment configurationThe text was updated successfully, but these errors were encountered: