fix(flagship): Make android namespace match package name #829
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The namespace for native android code was always set to
com.brandingbrand.reactnative.and.{config.name}, rather than using the defined ID. This lead to some
issues with starting activities and imports.
BREAKING CHANGE: If anything hard codes the android native project path (ie.
android/app/src/main/java/com/brandingbrand/reactnative/and/project-name), it will need to be
updated to account for the dynamic package name. Flagship now exports its own modules, so
`flagship.path.android.nativeProjectPath(config)` can be used to get the directory without hard
coding a path.
|
Looks like merging this caused a conflict: |
…android-bundle-id
|
yarn.lock conflicts again. |
Cauldrath
previously approved these changes
Sep 25, 2019
…android-bundle-id
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The namespace for native android code was always set to
com.brandingbrand.reactnative.and.{config.name}, rather than using the defined ID. This lead to someissues with starting activities and imports.
BREAKING CHANGE: If anything hard codes the android native project path (ie.
android/app/src/main/java/com/brandingbrand/reactnative/and/project-name), it will need to beupdated to account for the dynamic package name. Flagship now exports its own modules, so
flagship.path.android.nativeProjectPath(config)can be used to get the directory without hardcoding a path.
Will resolve #258