refactor: cli logger #2729
Merged
refactor: cli logger #2729
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crherman7
commented
Aug 6, 2024
crherman7
commented
Aug 6, 2024
crherman7
force-pushed
the
refactor/logger
branch
from
70e7448
to
ef6cefa
Compare
crherman7
force-pushed
the
refactor/logger
branch
from
ef6cefa
to
54f0802
Compare
crherman7
commented
Aug 6, 2024
crherman7
force-pushed
the
refactor/logger
branch
from
4758be3
to
da78b57
Compare
crherman7
force-pushed
the
refactor/logger
branch
from
4231156
to
85d0d79
Compare
crherman7
commented
Aug 7, 2024
packages/cli/src/cmds/align-deps.tsx
Outdated
| @@ -1,10 +1,14 @@ | |||
| import chalk from 'chalk'; | |||
packages/cli/src/cmds/align-deps.tsx
Outdated
| '-l --log-level [logLevel]', | ||
| 'debug, log, info, warn, error log levels.', | ||
| ) | ||
| .choices(['debug', 'log', 'info', 'warn', 'error']) |
There was a problem hiding this comment.
if you set log level to warn or error you no longer get the relevant output flagship-code align-deps -p "0.72" -l warn, seems odd to be able to remove the functionality with a log level, not sure if we need it for this command.
There was a problem hiding this comment.
ok - I will remove it from that command
NickBurkhartBB
approved these changes
Aug 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
CLI log levels + status.
Type of change
Test Plan
yarn testyarn flagship-code prebuild --build internal --env prodyarn flagship-code prebuild --build internal --env prod --log-level logyarn flagship-code prebuild --build internal --env prod --log-level debuginfo
Screen.Recording.2024-08-07.at.9.54.17.AM.mov
log
Screen.Recording.2024-08-07.at.9.55.24.AM.mov
debug
Screen.Recording.2024-08-07.at.9.56.05.AM.mov
Checklist before requesting a review
Notes