fix: Add itemCount to cart interface in fscommerce #877

olkorsia · 2019-10-23T14:06:13Z

Description
It would be useful to have an itemCount that takes into account quantities of different items in count. could be implemented as a virtual using 'get' function:
https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Functions/get

* chore(fscomponents): const name to clearicon from cancelicon * chore: refactor ccard validation to remove moment This refactors the validation in the CreditCardForm component to eliminate the need for the moment library. Because we were using moment to simply grab the month and date off a MM/YY formatted string it was easy to change. This helps us achieve our goal of removing dependencies to moment because it's a huge library. * fix(fscomponents): flatten validation for cc number to onblur * chore: tell greenkeeper to ignore react-native updates This updates the Greenkeeper configuration to always ignore react-native updates, as we should never be merging in react-native updates without developer oversight. Syntax per the Greenkeeper docs: https://greenkeeper.io/docs.html#monorepo * feat: android init config add various config based values that inject into Android template this allows for modifying the Android project during the init command * fix: update react-native-htmlview to version 0.14.0 * feat(fsweb): Enable Progressive Web App Activates features required to build as a progressive web app. Also switches to Workbox, addressing issue #620 * fix(flagship): Remove deprecated lifecycle functions Removing componentWillReceiveProps and componentWillMount. * fix(fsweb): Match routers path-to-regexp The react-router uses path-to-regexp@^1.7.0, which generates paths differently from 2.4.0, which fsweb was using without specifying the version. Without this change, the router wasn't working, so you couldn't visit any non-root pages. * fix(pirateship): Use componentDidUpdate in PSProductDetail getDerivedStateFromProps wasn't properly propogating the commerceData property, so visiting a PDP without refreshing the page caused it to stay in a loading state forever. Switching to componentDidUpdate resolves the issue. Resolves #637 * Update README.md * feat: Add create-fs-app functionality To test/run locally: 1. Navigate to `packages/create-fs-app` 2. Run `yarn link` 3. You should be able to run `create-fs-app` now in the directory of your choosing * fix: Remove launch screen base config option This cannot be set to a default unless the files actually exist * fix: Fix app name config key * fix: Remove template config when writing a new one * fix: Add more stubbed configs * fix: Fix types and name variable for package.json * fix: Add check that script is running on node 10 or above * chore(release): publish v6.1.0 * fix(fsweb): tag type of css bundle * fix(create-fs-app): fix run cmd for android with certain bundleIds * ci(create-fs-app): remove node version restriction from package.json the node version restriction is enforced at runtime. removing the package.json configuration allows older node version (like those used in CI) to still build the package * fix(fsweb): Lock webpack version to 4.39.3 Version 4.40.0 introduces a bug that prevents web from compiling: webpack/webpack#9693 * chore(release): publish v6.1.1 * chore(release): publish v6.1.2 * chore(release): publish v6.1.3 * fix(fsweb): Lock web dependency versions Added package-lock.json file to fsweb to avoid grabbing new versions automatically and locked some versions to the new values. Also set webpack to 4.40.2 because they fixed the issue in 4.40.0 and added a ship:init-web command for easier debugging. * fix: fix network security config for android emulators (#817) android blocks http requests by default. the network security config was set up to work with physical devices, but not emulators * chore(release): publish v6.1.4 * chore: add unit test for android exception domains This test ensures that localhost, 10.0.2.2 (the Android emulator internal localhost IP), and any configured exception domains are added to the network security file in the Android project. * feat(fsapp): Track whether the drawer is visible (#814) Reimplementation of #658 with additional safety checks "isOpen" only tracks whether the drawer is open or closed, regardless of the animation transition. This adds a "drawerVisible" property for the wrapped component, which will allow the component to know whether it is displaying or not. This allows the component to, for example, hide itself when it isn't visible, to avoid being tabbed to. * fix(fsweb): Fix slashes for running web on Windows * fix(pirateship): Fixes for blacklist and linking Windows slashes * fix: bump leanplum sdk version (#823) * chore(release): publish v6.2.0 * feat(fsnetwork): Add option for interceptor (#808) Adds the option to specify interceptor functions, mostly for error logging: https://www.npmjs.com/package/axios#interceptors * chore(release): publish v6.3.0 * fix(flagship): Make android namespace match package name The namespace for native android code was always set to com.brandingbrand.reactnative.and.{config.name}, rather than using the defined ID. This lead to some issues with starting activities and imports. BREAKING CHANGE: If anything hard codes the android native project path (ie. android/app/src/main/java/com/brandingbrand/reactnative/and/project-name), it will need to be updated to account for the dynamic package name. Flagship now exports its own modules, so `flagship.path.android.nativeProjectPath(config)` can be used to get the directory without hard coding a path. * Revert yarn.lock changes * feat: update bv components w/ syndicated indicator **Description** Some reviews are syndicated by the manufacturer. When this is the case, if the client wants to display the indicator, another row will appear on the bottom of the review indicating that it is syndicated. * chore(release): publish v7.0.0 * feat(flagship): support background modes * feat: update bv syndicated indicator style **Description** There were some bugs with the syndication badges on smaller devices. Fixed them with flex-wrap. Also updated copy. * chore(release): publish v7.1.0 * feat: add position property for half modal component * chore: add state typing for component CMSBanner * fix: excessive calls of handleContainerSizeChange in MultiCarousel * fix: Gridlines are misaligned between products in Product Index #143 * fix: Add 'Marquis' feature to Button with title dynamically reflecting CTA state * fix(fscomponents): add arg to bv syndication badge render prop **Description** I needed to include the syndicationSource details in the renderSyndicatedIndicator prop * chore(release): publish v7.1.1 * fix(flagship): ios background modes returning undefine * refactor: Change login for Dimensions * fix: Development version number should be fixed to the bottom of viewport for web * fix: fix infinite re-render bug when using renderSyndicatedIndicator prop * feat(fsengagement): expose new inbox route that sets attributes * fix: create SyndicationIndicator component, simplify conditional * fix: remove unused function * chore(release): publish v7.2.0 * feat: add appcenter support to fastlane scripts This adds :appcenter lanes to the fastfile scripts for ios and android. When paired with the correct configuration, it will compile the app and then upload the build to App Center's distribution section. * refactor: pass property height from parent for component HalfModalScreen * feat(fsengagement): remove moment library * chore(fscomponents): add missing typedef to modalhalfscreen component (#862) * chore(release): publish v7.3.0 * fix(flagship): update string replace to work in new fastfile (#864) * fix(flagship): update string replace to work in new fastfile * chore(release): publish v7.4.0 * fix(flagship): add support for new pods * chore(release): publish v7.4.1 * fix: get default env from initial script * build: upgrade deprecated webpack dev server * chore: tell greenkeeper to ignore more dependencies react, metro-react-babel-preset, and babel should only be updated as part of coordinated React Native upgrades. * fix: Add itemCount to cart interface in fscommerce (#877) * fix: Modify the podspec version to ve 2.6.2 (#878) * build: upgrade deprecated webpack dev server * fix: remove unnecessary checks * fix(pirateship): Remove duplicate "name" in config (#867) * chore: Update react-native-masked-text * fix: exclude kotlin intermediate build files 3rd party libraries begin using Kotlin and intermediate`*.kotlin_module` files are causing build errors. Added this rule to exclude those files * chore: update react-dom library * chore: Update react-native-touch-id dependency * fix(flagship): Fix renaming edge case for android (#898) The only file/directory with "flagship" in the name was the package directory, which is already being renamed when fixing the package directory structure. Resolves #895 * fix(fsweb): Use yarn.lock for fsweb (#906) Allows us to lock versions of subdependencies when running fsweb. * chore(release): publish v7.4.2 * fix(fsweb): Lock babel runtime in package.json (#905) package-lock.json doesn't get published by npm, so this removes it and locks the version in package.json. This still leaves us open to other package updates breaking web, so I will be following up to see if yarn.lock doesn't have this issue. * chore(release): publish v7.4.3

* fix(flagship): add targeted device to both Debug and Release config * feat: Write Reviews Baazarvoice implementation * refactor: move denormalize function to separate file Keeping BazaarvoiceDataSource.ts clean * feat: Write review submission typings * fix: update react-native-htmlview to version 0.14.0 * feat(fsengagement): add new carousel option and full screen background * chore(release): publish v4.1.0 * chore: update react native cli dependency to 1.11.2 This should resolve an issue we're seeing in CI as described here: react-native-community/cli#586 * feat(fscomponents): add some option props to zoomCarousel **Description** added and implemented the following optional props: * hideZoomButton * A bool to show/hide zoom functionality * containerStyle * StyleProp to ensure that all wrapping elements are styled as desired * renderImageWeb * A function that returns a react node * feat(fscomponents): add nextArrowOnBlur prop to pass through * feat(fscomponents): extend changes to non web-specific zoomcarousel change containerStyle to fillContainer: bool * chore: pin react-native-permissions version react-native-permissions released a breaking change with 1.2.0 (way to semver guys) that removes support for React Native's built in Async Storage in favor of having a peer dependency for the newly released react native community async storage. Because we do not currently have a dependency on the new async storage package this causes an error. This PR pins react-native-permissions to the last good version until we have time to properly add support for the new async storage package. * fix(fsengagement): update react-native-video there are compile issues of 3.X react-native-video when compiling with react-native 0.59 version 4.x has better support with this react version * fix(fsapp): Put dev menu as first screen When there is a collision between the path matching for other screens and the dev menu, this will make the dev menu take priority. * chore: remove add-keys scripts in favor of more generic versions BREAKING CHANGE: This removes the add-keys-ios and add-keys-android scripts as they required an internal BB workflow to work. The new scripts, add-keys-ios-internal and add-keys-android-internal, can be configured with the environment files with passwords being passed in as environment variables. For usage instructions, see the new wiki article: https://github.com/brandingbrand/flagship/wiki/Signing-Your-Apps * chore: pin react-native-sensitive-info to 5.4.x * feat(fscomponents): support more styling options for MultiCarousel * feat(fscomponents): add hideZoomButton props to ZoomCarousel * fix: Add 'Marquis' feature to Button with title dynamically reflecting CTA state * chore(fscomponents): add missing typedef to modalhalfscreen component * fix(flagship): update string replace to work in new fastfile * fix: get default env from initial script * build: upgrade deprecated webpack dev server * fix(flagship): fix fastlane build lane Added missing xcargs flags that tells xcode to make an unprovisioned build when "fastlane build" is executed. * chore: tell greenkeeper to ignore more dependencies react, metro-react-babel-preset, and babel should only be updated as part of coordinated React Native upgrades. * fix: Add itemCount to cart interface in fscommerce (#877) * fix: Modify the podspec version to ve 2.6.2 (#878) * feat(fsshopify): account data source implementation * build: upgrade deprecated webpack dev server * fix: remove unnecessary checks * fix(pirateship): Remove duplicate "name" in config (#867) * chore: Update react-native-masked-text * fix: exclude kotlin intermediate build files 3rd party libraries begin using Kotlin and intermediate`*.kotlin_module` files are causing build errors. Added this rule to exclude those files * chore: update react-dom library * chore: Update react-native-touch-id dependency * fix(flagship): Fix renaming edge case for android (#898) The only file/directory with "flagship" in the name was the package directory, which is already being renamed when fixing the package directory structure. Resolves #895 * fix(fsweb): Use yarn.lock for fsweb (#906) Allows us to lock versions of subdependencies when running fsweb. * chore(release): publish v7.4.2 * fix(fsweb): Lock babel runtime in package.json (#905) package-lock.json doesn't get published by npm, so this removes it and locks the version in package.json. This still leaves us open to other package updates breaking web, so I will be following up to see if yarn.lock doesn't have this issue. * chore(release): publish v7.4.3 * chore: fix merge confict * chore: fix merge confict * feat(fscomponents): add custom modal content logic and test view * feat(fscomponents): add condition to render custom test modal content * Update README.md * chore(release): publish v7.5.0 * chore(release): publish v7.5.1 * chore(release): publish v7.5.2 * chore(release): publish v7.5.3 * chore(release): publish v7.5.4 * chore(pirateship): update react-native-svg library (#889) * chore: tell greenkeeper to ignore react and react native types These types should be updated in sync with Flagship updates to the React and React Native libraries. * feat(fsshopify): add safe undefined handler * feat(fsshopify): add safe undefined handler * feat(flagship): Add option to only include the default env (#925) * feat(flagship): Add option to only include the default env * chore(release): publish v7.6.0 * refactor: CreditCardNumber to avoid getDerivedStateFromProps (#926) * chore: Update generating info plist (#924) * feat(flagship): deprecate appcenter.apiconfig configuration option This deprecates the appcenter.apiConfig configuration option in favor of using the APPCENTER_API_TOKEN environment variable. This makes the key optional in the typedef and updates the Fastfiles for iOS and Android such that not including this option will not break the builds. * chore(release): publish v7.7.0 * chore: update dev dependencies to alleviate security issues (#932) This updates commitlint, jest, lerna, and typedoc to their latest versions. Because some of the concerns were not yet addressed by their parent packages, I also had to add custom resolutions for handlebars and https-proxy-agent. * chore(release): publish v7.7.1 * fix(fsbazaarvoice): fix review id normalizer (#936) review.id is normalized from `ProductId` which is not unique, on the contrary, the values are usually the same because the reviews are usually from the same product. `Id` provides unique values so using that instead * Update typedoc to the latest version 🚀 (#922) * chore: update typedoc to version 0.15.1 * Update yargs in group flagship to the latest version 🚀 (#929) * fix: update yargs to version 15.0.1 * Update husky to the latest version 🚀 (#930) chore: update husky to version 3.1.0 * chore: add error message if user runs tsc on top level (#944)

@storybook

* chore: tell greenkeeper to ignore more dependencies react, metro-react-babel-preset, and babel should only be updated as part of coordinated React Native upgrades. * fix: Add itemCount to cart interface in fscommerce (#877) * fix: Modify the podspec version to ve 2.6.2 (#878) * feat(fsshopify): account data source implementation * build: upgrade deprecated webpack dev server * fix: remove unnecessary checks * fix(pirateship): Remove duplicate "name" in config (#867) * fix(fscomponents): Update form tests * chore: Update react-native-masked-text * fix(flagship): Fix dependencies * fix: exclude kotlin intermediate build files 3rd party libraries begin using Kotlin and intermediate`*.kotlin_module` files are causing build errors. Added this rule to exclude those files * chore: update react-dom library * chore: Update react-native-touch-id dependency * fix(flagship): Fix renaming edge case for android (#898) The only file/directory with "flagship" in the name was the package directory, which is already being renamed when fixing the package directory structure. Resolves #895 * fix(fsweb): Use yarn.lock for fsweb (#906) Allows us to lock versions of subdependencies when running fsweb. * chore(release): publish v7.4.2 * fix(fsapp): Basic React Native Navigation Web Wrapper Not showing modals as modals (pushing the screen instead) and not running the slide menu, but most screen transitions should work. * fix(fsapp): Support RNN side menus in web * fix(fsweb): Lock babel runtime in package.json (#905) package-lock.json doesn't get published by npm, so this removes it and locks the version in package.json. This still leaves us open to other package updates breaking web, so I will be following up to see if yarn.lock doesn't have this issue. * chore(release): publish v7.4.3 * fix(fsapp): Add support for basic modals to navigator * fix(pirateship): Fix modal dismissal * chore: fix merge confict * chore: fix merge confict * fix(flagship): Update yarn.lock * fix(flagship): Update packages to latest in range Also makes some updates for packages that give warnings * feat(fscomponents): add custom modal content logic and test view * fix(flagship): Upgrade to RN61 and Typescript 3.7.2 * fix(fsapp) Fix circular dependencies * feat(fscomponents): add condition to render custom test modal content * fix: Fix default viewport for storybook * Update README.md * chore(release): publish v7.5.0 * fix(flagship) Fixes for autolinking * chore(release): publish v7.5.1 * chore(release): publish v7.5.2 * chore(release): publish v7.5.3 * chore(release): publish v7.5.4 * fix(fsweb) Babel Update Replace deprecated @babel/polyfill with core-js 3, update versions of babel besides runtime to 7.7.2. Storybook 5.0 was using core-js 2, so this upgrades to 5.2. * chore(pirateship): update react-native-svg library (#889) * chore: tell greenkeeper to ignore react and react native types These types should be updated in sync with Flagship updates to the React and React Native libraries. * feat(fsshopify): add safe undefined handler * feat(fsshopify): add safe undefined handler * fix(flagship): Update various modules * fix(fsapp): Fixes for develop merge Set path-to-regexp in fsweb to match react-router and fix a typescript error. * feat(flagship): Add option to only include the default env (#925) * feat(flagship): Add option to only include the default env * chore(release): publish v7.6.0 * fix(fsapp): Swap NavWrapper to Navigator This should make updates from previous versions easier. * refactor: CreditCardNumber to avoid getDerivedStateFromProps (#926) * chore: Update generating info plist (#924) * feat(flagship): deprecate appcenter.apiconfig configuration option This deprecates the appcenter.apiConfig configuration option in favor of using the APPCENTER_API_TOKEN environment variable. This makes the key optional in the typedef and updates the Fastfiles for iOS and Android such that not including this option will not break the builds. * chore(release): publish v7.7.0 * chore: update dev dependencies to alleviate security issues (#932) This updates commitlint, jest, lerna, and typedoc to their latest versions. Because some of the concerns were not yet addressed by their parent packages, I also had to add custom resolutions for handlebars and https-proxy-agent. * chore(release): publish v7.7.1 * fix(fsbazaarvoice): fix review id normalizer (#936) review.id is normalized from `ProductId` which is not unique, on the contrary, the values are usually the same because the reviews are usually from the same product. `Id` provides unique values so using that instead * Update typedoc to the latest version 🚀 (#922) * chore: update typedoc to version 0.15.1 * Update yargs in group flagship to the latest version 🚀 (#929) * fix: update yargs to version 15.0.1 * Update husky to the latest version 🚀 (#930) chore: update husky to version 3.1.0 * chore: add error message if user runs tsc on top level (#944) * Merge develop into rnn2 (#952) * fix(flagship): add targeted device to both Debug and Release config * feat: Write Reviews Baazarvoice implementation * refactor: move denormalize function to separate file Keeping BazaarvoiceDataSource.ts clean * feat: Write review submission typings * fix: update react-native-htmlview to version 0.14.0 * feat(fsengagement): add new carousel option and full screen background * chore(release): publish v4.1.0 * chore: update react native cli dependency to 1.11.2 This should resolve an issue we're seeing in CI as described here: react-native-community/cli#586 * feat(fscomponents): add some option props to zoomCarousel **Description** added and implemented the following optional props: * hideZoomButton * A bool to show/hide zoom functionality * containerStyle * StyleProp to ensure that all wrapping elements are styled as desired * renderImageWeb * A function that returns a react node * feat(fscomponents): add nextArrowOnBlur prop to pass through * feat(fscomponents): extend changes to non web-specific zoomcarousel change containerStyle to fillContainer: bool * chore: pin react-native-permissions version react-native-permissions released a breaking change with 1.2.0 (way to semver guys) that removes support for React Native's built in Async Storage in favor of having a peer dependency for the newly released react native community async storage. Because we do not currently have a dependency on the new async storage package this causes an error. This PR pins react-native-permissions to the last good version until we have time to properly add support for the new async storage package. * fix(fsengagement): update react-native-video there are compile issues of 3.X react-native-video when compiling with react-native 0.59 version 4.x has better support with this react version * fix(fsapp): Put dev menu as first screen When there is a collision between the path matching for other screens and the dev menu, this will make the dev menu take priority. * chore: remove add-keys scripts in favor of more generic versions BREAKING CHANGE: This removes the add-keys-ios and add-keys-android scripts as they required an internal BB workflow to work. The new scripts, add-keys-ios-internal and add-keys-android-internal, can be configured with the environment files with passwords being passed in as environment variables. For usage instructions, see the new wiki article: https://github.com/brandingbrand/flagship/wiki/Signing-Your-Apps * chore: pin react-native-sensitive-info to 5.4.x * feat(fscomponents): support more styling options for MultiCarousel * feat(fscomponents): add hideZoomButton props to ZoomCarousel * fix: Add 'Marquis' feature to Button with title dynamically reflecting CTA state * chore(fscomponents): add missing typedef to modalhalfscreen component * fix(flagship): update string replace to work in new fastfile * fix: get default env from initial script * build: upgrade deprecated webpack dev server * fix(flagship): fix fastlane build lane Added missing xcargs flags that tells xcode to make an unprovisioned build when "fastlane build" is executed. * chore: tell greenkeeper to ignore more dependencies react, metro-react-babel-preset, and babel should only be updated as part of coordinated React Native upgrades. * fix: Add itemCount to cart interface in fscommerce (#877) * fix: Modify the podspec version to ve 2.6.2 (#878) * feat(fsshopify): account data source implementation * build: upgrade deprecated webpack dev server * fix: remove unnecessary checks * fix(pirateship): Remove duplicate "name" in config (#867) * chore: Update react-native-masked-text * fix: exclude kotlin intermediate build files 3rd party libraries begin using Kotlin and intermediate`*.kotlin_module` files are causing build errors. Added this rule to exclude those files * chore: update react-dom library * chore: Update react-native-touch-id dependency * fix(flagship): Fix renaming edge case for android (#898) The only file/directory with "flagship" in the name was the package directory, which is already being renamed when fixing the package directory structure. Resolves #895 * fix(fsweb): Use yarn.lock for fsweb (#906) Allows us to lock versions of subdependencies when running fsweb. * chore(release): publish v7.4.2 * fix(fsweb): Lock babel runtime in package.json (#905) package-lock.json doesn't get published by npm, so this removes it and locks the version in package.json. This still leaves us open to other package updates breaking web, so I will be following up to see if yarn.lock doesn't have this issue. * chore(release): publish v7.4.3 * chore: fix merge confict * chore: fix merge confict * feat(fscomponents): add custom modal content logic and test view * feat(fscomponents): add condition to render custom test modal content * Update README.md * chore(release): publish v7.5.0 * chore(release): publish v7.5.1 * chore(release): publish v7.5.2 * chore(release): publish v7.5.3 * chore(release): publish v7.5.4 * chore(pirateship): update react-native-svg library (#889) * chore: tell greenkeeper to ignore react and react native types These types should be updated in sync with Flagship updates to the React and React Native libraries. * feat(fsshopify): add safe undefined handler * feat(fsshopify): add safe undefined handler * feat(flagship): Add option to only include the default env (#925) * feat(flagship): Add option to only include the default env * chore(release): publish v7.6.0 * refactor: CreditCardNumber to avoid getDerivedStateFromProps (#926) * chore: Update generating info plist (#924) * feat(flagship): deprecate appcenter.apiconfig configuration option This deprecates the appcenter.apiConfig configuration option in favor of using the APPCENTER_API_TOKEN environment variable. This makes the key optional in the typedef and updates the Fastfiles for iOS and Android such that not including this option will not break the builds. * chore(release): publish v7.7.0 * chore: update dev dependencies to alleviate security issues (#932) This updates commitlint, jest, lerna, and typedoc to their latest versions. Because some of the concerns were not yet addressed by their parent packages, I also had to add custom resolutions for handlebars and https-proxy-agent. * chore(release): publish v7.7.1 * fix(fsbazaarvoice): fix review id normalizer (#936) review.id is normalized from `ProductId` which is not unique, on the contrary, the values are usually the same because the reviews are usually from the same product. `Id` provides unique values so using that instead * Update typedoc to the latest version 🚀 (#922) * chore: update typedoc to version 0.15.1 * Update yargs in group flagship to the latest version 🚀 (#929) * fix: update yargs to version 15.0.1 * Update husky to the latest version 🚀 (#930) chore: update husky to version 3.1.0 * chore: add error message if user runs tsc on top level (#944) * feat: update webpack dependencies - Update versions of terser-webpack-plugin, marked, and copy-webpack-plugin - Replaced uglify with terser for js minification in fsweb. The Uglify webpack plugin is no longer actively maintained. Test: - cd packages/pirateship - yarn run init:web --env shopify - cd web - yarn run start-prod - Server should listen to localhost:8080 - Inspect the bundle and verify it's minified and that the application is functional * feat(fsengagement): add animated card list for demo (#954) feat(fsengagement): add animated card list * feat(fsengagement): add image grid component (#947) * feat(fsengagement): add image grid component Ticket: https://jira.brandingbrand.com/browse/PARATROOPER-39 Description: -add image grid component to fsengagement * comments changes * feat(fsengagement): add language localization (#913) feat(fsengagement): add language localization Adds optional language localization * chore(release): publish v7.8.0 * fix(fscomponents): ModalHalfScreen listener height update (#957) * feat(flagship): add Android App Bundle (.aab) Support (#950) https://developer.android.com/guide/app-bundle Added a new Fastfile lane: appcenter_app_bundle * feat(pirateship): add enagement to pirateship demo (#959) * feat(pirateship): add enagement to pirateship demo * feat(pirateship): simplify story map * chore(pirateship): update provisioning profile (#960) * Update @types/yargs in group flagship to the latest version 🚀 (#962) * chore: update @types/yargs to version 13.0.4 * chore(package): update lockfile yarn.lock Co-authored-by: Brett Weissbart <phantomtails@gmail.com> * fix(fsapp): Adding deprecated backwards-compatibility functions Will now show an error about xib files needing to be converted to storyboard. Showing deprecation warning about tab.label and tab.icon, but will convert to the new format automatically. For the navigator, shows an error about handleDeepLink not existing, and adds backwards-compatible versions of resetTo, setStyle, setTabBadge, setTitle, and switchToTab that show deprecation warnings. * Update replace-in-file in group flagship to the latest version 🚀 (#953) * fix: update replace-in-file to version 5.0.2 * fix(fsapp): Fix screenwrapper appConfig * Update sinon in group flagship to the latest version 🚀 (#961) chore(package): update lockfile yarn.lock * Update markdownlint-cli to the latest version 🚀 (#956) chore: update markdownlint-cli to version 0.20.0 * fix(fsapp): Update redux and react I was getting errors (unable to access the store when calling connect) with redux 4.0.4, which went away after upgrading to 4.0.5. * Update @types/jest to the latest version 🚀 (#911) chore: update @types/jest to version 24.0.22 * chore: explicitly install node 10 for android ci step (#972) * Update husky to the latest version 🚀 (#970) * chore: update husky to version 4.0.2 * chore(package): update lockfile yarn.lock Co-authored-by: Brett Weissbart <phantomtails@gmail.com> * Update @types/yargs in group flagship to the latest version 🚀 (#969) * chore: update @types/yargs to version 15.0.0 * chore(package): update lockfile yarn.lock Co-authored-by: Brett Weissbart <phantomtails@gmail.com> * chore: update markdownlint-cli to version 0.21.0 * chore: update @types/memoize-one to version 5.1.2 (#893) Co-authored-by: Brett Weissbart <phantomtails@gmail.com> * chore: update @types/react-router-dom to version 5.1.2 (#910) Co-authored-by: Brett Weissbart <phantomtails@gmail.com> * fix: android fastline syntax error due to a trailing comma the script is not smart enough to decide if a comma is required and causing build errors. For now, the easiest way to fix the errors is to rearrange these lines * chore(release): publish v7.10.0 * chore(release): publish v7.10.0 * feat(flagship): update podfile to use cocoapods cdn BREAKING CHANGE: This requires updating CocoaPods (including in CI) to v1.7.2+ in order for pod install to work with the CDN. This allows CocoaPods to pull from their own CDN which avoids rate limiting when pulling sources from GitHub instead. * fix(flagship): Latest react-native-payments and react-native-swiper Also: - added supportLibVersion to the gradle file - advises what to do instead of calling setOnNavigatorEvent - fix for NativeModules.StatusBarManager.HEIGHT - fix for instances.filter being called on an object instead of an array * chore: empty commit to restart coveralls * chore(release): publish v8.0.0 * fix(flagship): Updated modules and fixed pirateship Android Jetifier doesn't run on hoisted modules, so this makes @brandingbrand/react-native-payments get updated. Also updated path-to-regexp to v6, react-native-svg to v10, react-native-webview to v8, react-native-video to 5, and removed the unused uglifyjs-webpack-plugin. Also updated all packages to the latest in-range version, excluding the @babel modules and modules that have it as a higher-versioned dependency, such as the @storybook modules. * refactor(fscomponents): FLAGSHIP-59 Updating To Function Component * refactor(fscomponents): FLAGSHIP-58 Updating To Function Component * fix(fscomponents): FLAGSHIP-64 - Make Shelf a function component * refactor(fscomponents): FLAGSHIP-60 Updating To Function Component * feat(fscomponents): Add formik, yup to fscomponents and LoginForm * refactor(fscomponents): FLAGSHIP-63 - Updating To Function Component * fix(flagship): Run react-native link to link assets Assets like fonts need to be linked so the application will have access to them. * refactor(fscomponents): FLAGSHIP-50 Update to a function component * refactor(fscomponents): FLAGSHIP-49 - Make AddressForm a function component * chore(fscomponents): memoize ImageWithOverlay.tsx (#988) * chore(fscomponents): convert Loading.tsx to functional component (#983) Co-authored-by: Brett Weissbart <phantomtails@gmail.com> * refactor(fscomponents): FLAGSHIP-51 Updating To Function Component (#984) * refactor(fscomponents): FLAGSHIP-69 Update to a function component * refactor(fscomponents): FLAGSHIP-55 Updating To Function Component (#985) * refactor(fscomponents): FLAGSHIP-56 Updating To Function Component (#986) * refactor(fscomponents): FLAGSHIP-71 Change to abstract classes * refactor(fscomponents): FLAGSHIP-72 Update to a function component * refactor(fscomponents): FLAGSHIP-74 Updating to function component * refactor(fscomponents): FLAGSHIP-67 Update to function component * chore(fstestproject): get test project working again Added up-to-date metro and babel configs and missing dependencies so the test project works. To run: yarn testproject:init && yarn testproject:run-ios * refactor(fscomponents): FLAGSHIP-101 Adding Accessibility To Component * chore: fix inaccurate comment * refactor(fscomponents): FLAGSHIP-103 Adding Accessibility To Component * refactor(fscomponents): FLAGSHIP-103 Adding New Translations * refactor(fscomponents): FLAGSHIP-65 Updating To Function Component (#1007) * refactor(fscomponents): FLAGSHIP-101 Adding New Translations ADA * refactor(fscomponents): FLAGSHIP-73 Update to a function component (#1008) * refactor(fscomponents): FLAGSHIP-105 Adding Accessibility To Component * refactor(fscomponents): FLAGSHIP-106 Adding New Translations and ADA * refactor(fscomponents): FLAGSHIP-66 Updating to function component (#1009) * refactor(fscomponents): FLAGSHIP-106 Adding Image Alt Text * feat(fscomponents): FLAGSHIP-102 accessibility for Filter * refactor(fscomponents): FLAGSHIP-91 update with translations * feat(fscomponents): FLAGSHIP-104 accessibility for Zoom carousel * refactor(fscomponents): FLAGSHIP-88 Add translations to alert * refactor(fscomponents): FLAGSHIP-85 update with translations * refactor(fscomponents): FLAGSHIP-86 update with translations * refactor(fscomponents): FLAGSHIP-87 update with translations * fix(fscomponents): replace Arial with sans-serif (#1030) * chore(release): publish v8.1.0 * refactor(fscomponents): FLAGSHIP-49 Updating to function component * refactor(fscomponents): FLAGSHIP-106 Adding Accessibility To Component * refactor(fscomponents): FLAGSHIP-96 Add Translation To Component * refactor(fscomponents): FLAGSHIP-95 Add Translation To Component * refactor(fscomponents): FLAGSHIP-97 Add Translations To Component * fix(pirateship): Update tab index for cart count (#1039) The tabs got shifted over one when the "Home" tab was added, but the cart count was being applied to the same index. This makes the cart count show up on the cart icon. * refactor(fscomponents): FLAGSHIP-89 Add Translations To Component * fix(fscomponents): Move story files to all live in the same folder (#1042) Them being in different folders was making them load in unpredictable orders, so they were no longer alphabetized. * feat(fslocator): add customized search functionality * refactor(fscomponents): FLAGSHIP-98 Add Translations To Component * refactor(fscomponents): FLAGSHIP-94 Add Translations To Component * fix(flagship): Update react-native-camera setup for RN61 * chore(release): publish v8.2.0 * feat(fsbazaarvoice): Expand review data source * refactor(fsbazaarvoice): simplify param code since qs strips out undefined params * chore(fsnetwork): fix fsnetwork unit tests Requesting the GitHub homepage with fsnetwork appears to consistently return a 406 error. This points the test at brandingbrand.com which resolves the error. * chore(release): publish v8.3.0 * fix(fsapp): react-native-navigation 4 This will require users to have XCode 11. Co-authored-by: Brett Weissbart <brett@brandingbrand.com> Co-authored-by: Alexandr <alexandrkorsia@gmail.com> Co-authored-by: Maxim <maxshop2010@gmail.com> Co-authored-by: alexsavosh <olexandor.s@gmail.com> Co-authored-by: Mauricio Perez <mauricio.perez@brandingbrand.com> Co-authored-by: Oleksandr Soloviov <olksns@gmail.com> Co-authored-by: Vance Hu <vancehu@users.noreply.github.com> Co-authored-by: Vladimir Sentiurin <volodymyr.sentiurin@gmail.com> Co-authored-by: Nathan Sankbeil <nathan.sankbeil@brandingbrand.com> Co-authored-by: Stefan Neamtu <stefan.neamtu@brandingbrand.com> Co-authored-by: Deema Abdallah <deema.abdallah@brandingbrand.com> Co-authored-by: greenkeeper[bot] <23040076+greenkeeper[bot]@users.noreply.github.com> Co-authored-by: Andrew Schwob <andy.schwob@brandingbrand.com> Co-authored-by: Shaheed Shamsi <shaheed.shamsi@brandingbrand.com> Co-authored-by: KO-HSIN CHU <kohsin.chu@brandingbrand.com> Co-authored-by: Brett Weissbart <phantomtails@gmail.com> Co-authored-by: willybeans <will.wedmedyk@brandingbrand.com> Co-authored-by: hearsh <hearsh.m@gmail.com> Co-authored-by: buticm <mikhail@brandingbrand.com> Co-authored-by: Huizhu Zhang <huizhu.zhang@brandingbrand.com> Co-authored-by: rosahbruno <rosahbruno@gmail.com> Co-authored-by: griffithcaleb <38706174+griffithcaleb@users.noreply.github.com> Co-authored-by: huizhuz <huizhuz@outlook.com> Co-authored-by: Nick Richter <nick@brandingbrand.com> Co-authored-by: Ko-Hsin Chu <chukohsin@gmail.com>

* fix(flagship): add targeted device to both Debug and Release config * feat: Write Reviews Baazarvoice implementation * refactor: move denormalize function to separate file Keeping BazaarvoiceDataSource.ts clean * feat: Write review submission typings * fix: update react-native-htmlview to version 0.14.0 * feat(fsengagement): add new carousel option and full screen background * chore(release): publish v4.1.0 * chore: update react native cli dependency to 1.11.2 This should resolve an issue we're seeing in CI as described here: react-native-community/cli#586 * feat(fscomponents): add some option props to zoomCarousel **Description** added and implemented the following optional props: * hideZoomButton * A bool to show/hide zoom functionality * containerStyle * StyleProp to ensure that all wrapping elements are styled as desired * renderImageWeb * A function that returns a react node * feat(fscomponents): add nextArrowOnBlur prop to pass through * feat(fscomponents): extend changes to non web-specific zoomcarousel change containerStyle to fillContainer: bool * chore: pin react-native-permissions version react-native-permissions released a breaking change with 1.2.0 (way to semver guys) that removes support for React Native's built in Async Storage in favor of having a peer dependency for the newly released react native community async storage. Because we do not currently have a dependency on the new async storage package this causes an error. This PR pins react-native-permissions to the last good version until we have time to properly add support for the new async storage package. * fix(fsengagement): update react-native-video there are compile issues of 3.X react-native-video when compiling with react-native 0.59 version 4.x has better support with this react version * fix(fsapp): Put dev menu as first screen When there is a collision between the path matching for other screens and the dev menu, this will make the dev menu take priority. * chore: remove add-keys scripts in favor of more generic versions BREAKING CHANGE: This removes the add-keys-ios and add-keys-android scripts as they required an internal BB workflow to work. The new scripts, add-keys-ios-internal and add-keys-android-internal, can be configured with the environment files with passwords being passed in as environment variables. For usage instructions, see the new wiki article: https://github.com/brandingbrand/flagship/wiki/Signing-Your-Apps * chore: pin react-native-sensitive-info to 5.4.x * feat(fscomponents): support more styling options for MultiCarousel * feat(fscomponents): add hideZoomButton props to ZoomCarousel * fix: Add 'Marquis' feature to Button with title dynamically reflecting CTA state * chore(fscomponents): add missing typedef to modalhalfscreen component * fix(flagship): update string replace to work in new fastfile * build: upgrade deprecated webpack dev server * fix(flagship): fix fastlane build lane Added missing xcargs flags that tells xcode to make an unprovisioned build when "fastlane build" is executed. * chore: tell greenkeeper to ignore more dependencies react, metro-react-babel-preset, and babel should only be updated as part of coordinated React Native upgrades. * fix: Add itemCount to cart interface in fscommerce (#877) * fix: Modify the podspec version to ve 2.6.2 (#878) * feat(fsshopify): account data source implementation * build: upgrade deprecated webpack dev server * fix: remove unnecessary checks * fix(pirateship): Remove duplicate "name" in config (#867) * chore: Update react-native-masked-text * fix: exclude kotlin intermediate build files 3rd party libraries begin using Kotlin and intermediate`*.kotlin_module` files are causing build errors. Added this rule to exclude those files * chore: update react-dom library * chore: Update react-native-touch-id dependency * fix(flagship): Fix renaming edge case for android (#898) The only file/directory with "flagship" in the name was the package directory, which is already being renamed when fixing the package directory structure. Resolves #895 * fix(fsweb): Use yarn.lock for fsweb (#906) Allows us to lock versions of subdependencies when running fsweb. * chore(release): publish v7.4.2 * fix(fsweb): Lock babel runtime in package.json (#905) package-lock.json doesn't get published by npm, so this removes it and locks the version in package.json. This still leaves us open to other package updates breaking web, so I will be following up to see if yarn.lock doesn't have this issue. * chore(release): publish v7.4.3 * chore: fix merge confict * chore: fix merge confict * feat(fscomponents): add custom modal content logic and test view * feat(fscomponents): add condition to render custom test modal content * Update README.md * chore(release): publish v7.5.0 * chore(release): publish v7.5.1 * chore(release): publish v7.5.2 * chore(release): publish v7.5.3 * chore(release): publish v7.5.4 * chore(pirateship): update react-native-svg library (#889) * chore: tell greenkeeper to ignore react and react native types These types should be updated in sync with Flagship updates to the React and React Native libraries. * feat(fsshopify): add safe undefined handler * feat(fsshopify): add safe undefined handler * feat(flagship): Add option to only include the default env (#925) * feat(flagship): Add option to only include the default env * chore(release): publish v7.6.0 * refactor: CreditCardNumber to avoid getDerivedStateFromProps (#926) * chore: Update generating info plist (#924) * feat(flagship): deprecate appcenter.apiconfig configuration option This deprecates the appcenter.apiConfig configuration option in favor of using the APPCENTER_API_TOKEN environment variable. This makes the key optional in the typedef and updates the Fastfiles for iOS and Android such that not including this option will not break the builds. * chore(release): publish v7.7.0 * chore: update dev dependencies to alleviate security issues (#932) This updates commitlint, jest, lerna, and typedoc to their latest versions. Because some of the concerns were not yet addressed by their parent packages, I also had to add custom resolutions for handlebars and https-proxy-agent. * chore(release): publish v7.7.1 * fix(fsbazaarvoice): fix review id normalizer (#936) review.id is normalized from `ProductId` which is not unique, on the contrary, the values are usually the same because the reviews are usually from the same product. `Id` provides unique values so using that instead * Update typedoc to the latest version 🚀 (#922) * chore: update typedoc to version 0.15.1 * Update yargs in group flagship to the latest version 🚀 (#929) * fix: update yargs to version 15.0.1 * Update husky to the latest version 🚀 (#930) chore: update husky to version 3.1.0 * chore: add error message if user runs tsc on top level (#944) * feat: update webpack dependencies - Update versions of terser-webpack-plugin, marked, and copy-webpack-plugin - Replaced uglify with terser for js minification in fsweb. The Uglify webpack plugin is no longer actively maintained. Test: - cd packages/pirateship - yarn run init:web --env shopify - cd web - yarn run start-prod - Server should listen to localhost:8080 - Inspect the bundle and verify it's minified and that the application is functional * feat(fsengagement): add animated card list for demo (#954) feat(fsengagement): add animated card list * feat(fsengagement): add image grid component (#947) * feat(fsengagement): add image grid component Ticket: https://jira.brandingbrand.com/browse/PARATROOPER-39 Description: -add image grid component to fsengagement * comments changes * chore(release): publish v7.8.0 * fix(fscomponents): ModalHalfScreen listener height update (#957) * feat(flagship): add Android App Bundle (.aab) Support (#950) https://developer.android.com/guide/app-bundle Added a new Fastfile lane: appcenter_app_bundle * feat(pirateship): add enagement to pirateship demo (#959) * feat(pirateship): add enagement to pirateship demo * feat(pirateship): simplify story map * chore(pirateship): update provisioning profile (#960) * Update @types/yargs in group flagship to the latest version 🚀 (#962) * chore: update @types/yargs to version 13.0.4 * chore(package): update lockfile yarn.lock Co-authored-by: Brett Weissbart <phantomtails@gmail.com> * Update replace-in-file in group flagship to the latest version 🚀 (#953) * fix: update replace-in-file to version 5.0.2 * Update sinon in group flagship to the latest version 🚀 (#961) chore(package): update lockfile yarn.lock * Update markdownlint-cli to the latest version 🚀 (#956) chore: update markdownlint-cli to version 0.20.0 * Update @types/jest to the latest version 🚀 (#911) chore: update @types/jest to version 24.0.22 * chore: explicitly install node 10 for android ci step (#972) * Update husky to the latest version 🚀 (#970) * chore: update husky to version 4.0.2 * chore(package): update lockfile yarn.lock Co-authored-by: Brett Weissbart <phantomtails@gmail.com> * Update @types/yargs in group flagship to the latest version 🚀 (#969) * chore: update @types/yargs to version 15.0.0 * chore(package): update lockfile yarn.lock Co-authored-by: Brett Weissbart <phantomtails@gmail.com> * chore: update markdownlint-cli to version 0.21.0 * chore: update @types/memoize-one to version 5.1.2 (#893) Co-authored-by: Brett Weissbart <phantomtails@gmail.com> * chore: update @types/react-router-dom to version 5.1.2 (#910) Co-authored-by: Brett Weissbart <phantomtails@gmail.com> * fix: android fastline syntax error due to a trailing comma the script is not smart enough to decide if a comma is required and causing build errors. For now, the easiest way to fix the errors is to rearrange these lines * chore(release): publish v7.10.0 * chore(release): publish v7.10.0 * feat(flagship): update podfile to use cocoapods cdn BREAKING CHANGE: This requires updating CocoaPods (including in CI) to v1.7.2+ in order for pod install to work with the CDN. This allows CocoaPods to pull from their own CDN which avoids rate limiting when pulling sources from GitHub instead. * chore: empty commit to restart coveralls * chore(release): publish v8.0.0 * refactor(fscomponents): FLAGSHIP-59 Updating To Function Component * refactor(fscomponents): FLAGSHIP-58 Updating To Function Component * fix(fscomponents): FLAGSHIP-64 - Make Shelf a function component * refactor(fscomponents): FLAGSHIP-60 Updating To Function Component * feat(fscomponents): Add formik, yup to fscomponents and LoginForm * refactor(fscomponents): FLAGSHIP-63 - Updating To Function Component * refactor(fscomponents): FLAGSHIP-50 Update to a function component * refactor(fscomponents): FLAGSHIP-49 - Make AddressForm a function component * chore(fscomponents): memoize ImageWithOverlay.tsx (#988) * chore(fscomponents): convert Loading.tsx to functional component (#983) Co-authored-by: Brett Weissbart <phantomtails@gmail.com> * refactor(fscomponents): FLAGSHIP-51 Updating To Function Component (#984) * refactor(fscomponents): FLAGSHIP-69 Update to a function component * refactor(fscomponents): FLAGSHIP-55 Updating To Function Component (#985) * refactor(fscomponents): FLAGSHIP-56 Updating To Function Component (#986) * refactor(fscomponents): FLAGSHIP-71 Change to abstract classes * refactor(fscomponents): FLAGSHIP-72 Update to a function component * refactor(fscomponents): FLAGSHIP-74 Updating to function component * refactor(fscomponents): FLAGSHIP-67 Update to function component * chore(fstestproject): get test project working again Added up-to-date metro and babel configs and missing dependencies so the test project works. To run: yarn testproject:init && yarn testproject:run-ios * refactor(fscomponents): FLAGSHIP-101 Adding Accessibility To Component * chore: fix inaccurate comment * refactor(fscomponents): FLAGSHIP-103 Adding Accessibility To Component * refactor(fscomponents): FLAGSHIP-103 Adding New Translations * refactor(fscomponents): FLAGSHIP-65 Updating To Function Component (#1007) * refactor(fscomponents): FLAGSHIP-101 Adding New Translations ADA * refactor(fscomponents): FLAGSHIP-73 Update to a function component (#1008) * refactor(fscomponents): FLAGSHIP-105 Adding Accessibility To Component * refactor(fscomponents): FLAGSHIP-106 Adding New Translations and ADA * refactor(fscomponents): FLAGSHIP-66 Updating to function component (#1009) * refactor(fscomponents): FLAGSHIP-106 Adding Image Alt Text * feat(fscomponents): FLAGSHIP-102 accessibility for Filter * refactor(fscomponents): FLAGSHIP-91 update with translations * feat(fscomponents): FLAGSHIP-104 accessibility for Zoom carousel * refactor(fscomponents): FLAGSHIP-88 Add translations to alert * refactor(fscomponents): FLAGSHIP-85 update with translations * refactor(fscomponents): FLAGSHIP-86 update with translations * refactor(fscomponents): FLAGSHIP-87 update with translations * fix(fscomponents): replace Arial with sans-serif (#1030) * chore(release): publish v8.1.0 * refactor(fscomponents): FLAGSHIP-49 Updating to function component * refactor(fscomponents): FLAGSHIP-106 Adding Accessibility To Component * refactor(fscomponents): FLAGSHIP-96 Add Translation To Component * refactor(fscomponents): FLAGSHIP-95 Add Translation To Component * refactor(fscomponents): FLAGSHIP-97 Add Translations To Component * fix(pirateship): Update tab index for cart count (#1039) The tabs got shifted over one when the "Home" tab was added, but the cart count was being applied to the same index. This makes the cart count show up on the cart icon. * refactor(fscomponents): FLAGSHIP-89 Add Translations To Component * fix(fscomponents): Move story files to all live in the same folder (#1042) Them being in different folders was making them load in unpredictable orders, so they were no longer alphabetized. * feat(fslocator): add customized search functionality * refactor(fscomponents): FLAGSHIP-98 Add Translations To Component * refactor(fscomponents): FLAGSHIP-94 Add Translations To Component * chore(release): publish v8.2.0 * feat(fsbazaarvoice): Expand review data source * refactor(fsbazaarvoice): simplify param code since qs strips out undefined params * chore(fsnetwork): fix fsnetwork unit tests Requesting the GitHub homepage with fsnetwork appears to consistently return a 406 error. This points the test at brandingbrand.com which resolves the error. * chore(release): publish v8.3.0 * test(fsnetwork): fix network test with new url (#1074) * feat(fsbazaarvoice): Add recommended ratio to normalized data (#1077) * chore(release): publish v8.4.0 * chore(deps): bump acorn from 5.7.3 to 5.7.4 (#1083) Bumps [acorn](https://github.com/acornjs/acorn) from 5.7.3 to 5.7.4. - [Release notes](https://github.com/acornjs/acorn/releases) - [Commits](acornjs/acorn@5.7.3...5.7.4) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * feat(fsapp): Allow setting the application root tag (#1082) Right now the app can only be injected into an element with the id "root". This change allows passing a css selector or HTML element into the config with the key "root", which will cause the app to be loaded into the corresponding element on the page. Co-authored-by: Justin Endler <justin.endler@brandingbrand.com> Co-authored-by: Pavle Milicevic <pavle.milicevic@brandingbrand.com> Co-authored-by: DavidRhodesBB <41645989+DavidRhodesBB@users.noreply.github.com> Co-authored-by: greenkeeper[bot] <greenkeeper[bot]@users.noreply.github.com> Co-authored-by: Brett Weissbart <brett@brandingbrand.com> Co-authored-by: andy.schwob@brandingbrand.com <Andy.Schwob@ASchwob-L210.local> Co-authored-by: jcarvin <j.d.carvin@gmail.com> Co-authored-by: Nick Burkhart <nick.burkhart@brandingbrand.com> Co-authored-by: Ko-Hsin Chu <chukohsin@gmail.com> Co-authored-by: Oleksandr Soloviov <olksns@gmail.com> Co-authored-by: alexsavosh <olexandor.s@gmail.com> Co-authored-by: Alexandr <alexandrkorsia@gmail.com> Co-authored-by: Maxim <maxshop2010@gmail.com> Co-authored-by: Mauricio Perez <mauricio.perez@brandingbrand.com> Co-authored-by: Vance Hu <vancehu@users.noreply.github.com> Co-authored-by: Vladimir Sentiurin <volodymyr.sentiurin@gmail.com> Co-authored-by: Nathan Sankbeil <nathan.sankbeil@brandingbrand.com> Co-authored-by: Stefan Neamtu <stefan.neamtu@brandingbrand.com> Co-authored-by: Deema Abdallah <deema.abdallah@brandingbrand.com> Co-authored-by: greenkeeper[bot] <23040076+greenkeeper[bot]@users.noreply.github.com> Co-authored-by: Andrew Schwob <andy.schwob@brandingbrand.com> Co-authored-by: Shaheed Shamsi <shaheed.shamsi@brandingbrand.com> Co-authored-by: KO-HSIN CHU <kohsin.chu@brandingbrand.com> Co-authored-by: Brett Weissbart <phantomtails@gmail.com> Co-authored-by: willybeans <will.wedmedyk@brandingbrand.com> Co-authored-by: hearsh <hearsh.m@gmail.com> Co-authored-by: buticm <mikhail@brandingbrand.com> Co-authored-by: Huizhu Zhang <huizhu.zhang@brandingbrand.com> Co-authored-by: rosahbruno <rosahbruno@gmail.com> Co-authored-by: griffithcaleb <38706174+griffithcaleb@users.noreply.github.com> Co-authored-by: huizhuz <huizhuz@outlook.com> Co-authored-by: Nick Richter <nick@brandingbrand.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

@storybook

* add image carousel component * chore(fsengagement): upgrade rnn to version 2.26.3 * chore(fsapp): upgrade fsapp rnn to version 2.26.3 BREAKING CHANGE * chore(fsapp): update yarn lock for rnn v 2.26.3 BREAKING CHANGE * chore(fsshopify): upgrade rnn to version 2.26.3 BREAKING CHANGE * chore(fstestproject): upgrade rnn to version 2.26.3 BREAKING CHANGE * chore(pirateship): upgrade rnn to version 2.26.3 BREAKING CHANGE * chore: Remove old React-Native-Navigation types RNN 2 provides its own types * feat: setup native side of android for react-native-navigation 2 * feat: setup native side of ios for react-native-navigation 2 BREAKING CHANGE: splash screens will need to be converted to storyboards * feat: update fsapp to use react-native-navigation 2 - Use global event handlers for popToRoot on tab press for Android and restoring screen on load option - Add requirement for tabs to have ids BREAKING CHANGE: Tabs must now have ids defined in their configuration * feat: update pirateship to use react-native-navigation 2 * refactor: Use react native community version of AsyncStorage * feat(fsengagement): add new zones * fix: fix codepush integration with RNN v2 * fix(fsapp): RNN v2 allow passing static styling as a function RNN v2 by default is passing static styling as a function so passProps info can be included. Updated to support the default behavior. This is not breaking the backward-compatible logic * feat(fsengagement): add gridwall and product carousel * feat(fsengagement): cache last update + add isNew flag to each message * feat(fsengagement): add gridwall and product carousel (#816) add image carousel component * feat(fsengagement): add gestures and animations * feat(fsengagement): add gesture handler for full screen cards * feat(fsengagement): fix typo * feat(fsengagement): adjust gesture handler * feat(fsengagement): add support for video on title card * feat(fsengagement): fix yarn.lock * feat(fsengagement): move panhandler to constructor * fix(flagship): Fix overwriting launch screen file The init script was not updated to replace the new storyboard launch screen rather than the old xib. The config option probably should also be updated to reflect the new storyboard expectation (ie. rename `launchScreen.ios.xib` to something like `launchScreen.ios.storyboard`) * fix(fsengagement): RNN2 - fix deeplinking animations from story (#871) * feat(fsengagement): fix animation issues for deeplinks * fix(fsengagement): RNN2 - fix deeplinking animations from story * chore(release): publish v8.1.1-rnn2.0 * chore: Update README.md * fix: bump react-native-device-info (#872) * chore(release): publish v8.1.3-rnn2.0 * fix(fsengagement): refactor animated story modal and fix deeplinking (#873) * feat(fsengagement): fix animation issues for deeplinks * fix(fsengagement): RNN2 - fix deeplinking animations from story * fix(fsengagement): add reverse jetifier * chore(release): publish v8.2.0-rnn2.0 * feat(flagship): Update to RN60 * feat: Migrate to RNN 3 and RN 60 * fix(fsengage): Async analytics fixes Also some fixes specifically for RN60 * fix(fsengage): Fix analytics test for async * fix(fsengage): Add queue for Google analytics race conditions * Merge develop into RN61 (#923) chore: merge develop into rn61 * feat: update podfile to use cocoapods cdn (#958) * feat: update podfile to use cocoapods cdn BREAKING CHANGE: This requires updating CocoaPods (including in CI) to v1.7.2+ in order for pod install to work with the CDN. This allows CocoaPods to pull from their own CDN which avoids rate limiting when pulling sources from GitHub instead. * chore: ensure android ci step uses node 10 * Update to react-native 0.61.5 and Typescript 3.7.4 (#915) * chore: tell greenkeeper to ignore more dependencies react, metro-react-babel-preset, and babel should only be updated as part of coordinated React Native upgrades. * fix: Add itemCount to cart interface in fscommerce (#877) * fix: Modify the podspec version to ve 2.6.2 (#878) * feat(fsshopify): account data source implementation * build: upgrade deprecated webpack dev server * fix: remove unnecessary checks * fix(pirateship): Remove duplicate "name" in config (#867) * fix(fscomponents): Update form tests * chore: Update react-native-masked-text * fix(flagship): Fix dependencies * fix: exclude kotlin intermediate build files 3rd party libraries begin using Kotlin and intermediate`*.kotlin_module` files are causing build errors. Added this rule to exclude those files * chore: update react-dom library * chore: Update react-native-touch-id dependency * fix(flagship): Fix renaming edge case for android (#898) The only file/directory with "flagship" in the name was the package directory, which is already being renamed when fixing the package directory structure. Resolves #895 * fix(fsweb): Use yarn.lock for fsweb (#906) Allows us to lock versions of subdependencies when running fsweb. * chore(release): publish v7.4.2 * fix(fsapp): Basic React Native Navigation Web Wrapper Not showing modals as modals (pushing the screen instead) and not running the slide menu, but most screen transitions should work. * fix(fsapp): Support RNN side menus in web * fix(fsweb): Lock babel runtime in package.json (#905) package-lock.json doesn't get published by npm, so this removes it and locks the version in package.json. This still leaves us open to other package updates breaking web, so I will be following up to see if yarn.lock doesn't have this issue. * chore(release): publish v7.4.3 * fix(fsapp): Add support for basic modals to navigator * fix(pirateship): Fix modal dismissal * chore: fix merge confict * chore: fix merge confict * fix(flagship): Update yarn.lock * fix(flagship): Update packages to latest in range Also makes some updates for packages that give warnings * feat(fscomponents): add custom modal content logic and test view * fix(flagship): Upgrade to RN61 and Typescript 3.7.2 * fix(fsapp) Fix circular dependencies * feat(fscomponents): add condition to render custom test modal content * fix: Fix default viewport for storybook * Update README.md * chore(release): publish v7.5.0 * fix(flagship) Fixes for autolinking * chore(release): publish v7.5.1 * chore(release): publish v7.5.2 * chore(release): publish v7.5.3 * chore(release): publish v7.5.4 * fix(fsweb) Babel Update Replace deprecated @babel/polyfill with core-js 3, update versions of babel besides runtime to 7.7.2. Storybook 5.0 was using core-js 2, so this upgrades to 5.2. * chore(pirateship): update react-native-svg library (#889) * chore: tell greenkeeper to ignore react and react native types These types should be updated in sync with Flagship updates to the React and React Native libraries. * feat(fsshopify): add safe undefined handler * feat(fsshopify): add safe undefined handler * fix(flagship): Update various modules * fix(fsapp): Fixes for develop merge Set path-to-regexp in fsweb to match react-router and fix a typescript error. * feat(flagship): Add option to only include the default env (#925) * feat(flagship): Add option to only include the default env * chore(release): publish v7.6.0 * fix(fsapp): Swap NavWrapper to Navigator This should make updates from previous versions easier. * refactor: CreditCardNumber to avoid getDerivedStateFromProps (#926) * chore: Update generating info plist (#924) * feat(flagship): deprecate appcenter.apiconfig configuration option This deprecates the appcenter.apiConfig configuration option in favor of using the APPCENTER_API_TOKEN environment variable. This makes the key optional in the typedef and updates the Fastfiles for iOS and Android such that not including this option will not break the builds. * chore(release): publish v7.7.0 * chore: update dev dependencies to alleviate security issues (#932) This updates commitlint, jest, lerna, and typedoc to their latest versions. Because some of the concerns were not yet addressed by their parent packages, I also had to add custom resolutions for handlebars and https-proxy-agent. * chore(release): publish v7.7.1 * fix(fsbazaarvoice): fix review id normalizer (#936) review.id is normalized from `ProductId` which is not unique, on the contrary, the values are usually the same because the reviews are usually from the same product. `Id` provides unique values so using that instead * Update typedoc to the latest version 🚀 (#922) * chore: update typedoc to version 0.15.1 * Update yargs in group flagship to the latest version 🚀 (#929) * fix: update yargs to version 15.0.1 * Update husky to the latest version 🚀 (#930) chore: update husky to version 3.1.0 * chore: add error message if user runs tsc on top level (#944) * Merge develop into rnn2 (#952) * fix(flagship): add targeted device to both Debug and Release config * feat: Write Reviews Baazarvoice implementation * refactor: move denormalize function to separate file Keeping BazaarvoiceDataSource.ts clean * feat: Write review submission typings * fix: update react-native-htmlview to version 0.14.0 * feat(fsengagement): add new carousel option and full screen background * chore(release): publish v4.1.0 * chore: update react native cli dependency to 1.11.2 This should resolve an issue we're seeing in CI as described here: react-native-community/cli#586 * feat(fscomponents): add some option props to zoomCarousel **Description** added and implemented the following optional props: * hideZoomButton * A bool to show/hide zoom functionality * containerStyle * StyleProp to ensure that all wrapping elements are styled as desired * renderImageWeb * A function that returns a react node * feat(fscomponents): add nextArrowOnBlur prop to pass through * feat(fscomponents): extend changes to non web-specific zoomcarousel change containerStyle to fillContainer: bool * chore: pin react-native-permissions version react-native-permissions released a breaking change with 1.2.0 (way to semver guys) that removes support for React Native's built in Async Storage in favor of having a peer dependency for the newly released react native community async storage. Because we do not currently have a dependency on the new async storage package this causes an error. This PR pins react-native-permissions to the last good version until we have time to properly add support for the new async storage package. * fix(fsengagement): update react-native-video there are compile issues of 3.X react-native-video when compiling with react-native 0.59 version 4.x has better support with this react version * fix(fsapp): Put dev menu as first screen When there is a collision between the path matching for other screens and the dev menu, this will make the dev menu take priority. * chore: remove add-keys scripts in favor of more generic versions BREAKING CHANGE: This removes the add-keys-ios and add-keys-android scripts as they required an internal BB workflow to work. The new scripts, add-keys-ios-internal and add-keys-android-internal, can be configured with the environment files with passwords being passed in as environment variables. For usage instructions, see the new wiki article: https://github.com/brandingbrand/flagship/wiki/Signing-Your-Apps * chore: pin react-native-sensitive-info to 5.4.x * feat(fscomponents): support more styling options for MultiCarousel * feat(fscomponents): add hideZoomButton props to ZoomCarousel * fix: Add 'Marquis' feature to Button with title dynamically reflecting CTA state * chore(fscomponents): add missing typedef to modalhalfscreen component * fix(flagship): update string replace to work in new fastfile * fix: get default env from initial script * build: upgrade deprecated webpack dev server * fix(flagship): fix fastlane build lane Added missing xcargs flags that tells xcode to make an unprovisioned build when "fastlane build" is executed. * chore: tell greenkeeper to ignore more dependencies react, metro-react-babel-preset, and babel should only be updated as part of coordinated React Native upgrades. * fix: Add itemCount to cart interface in fscommerce (#877) * fix: Modify the podspec version to ve 2.6.2 (#878) * feat(fsshopify): account data source implementation * build: upgrade deprecated webpack dev server * fix: remove unnecessary checks * fix(pirateship): Remove duplicate "name" in config (#867) * chore: Update react-native-masked-text * fix: exclude kotlin intermediate build files 3rd party libraries begin using Kotlin and intermediate`*.kotlin_module` files are causing build errors. Added this rule to exclude those files * chore: update react-dom library * chore: Update react-native-touch-id dependency * fix(flagship): Fix renaming edge case for android (#898) The only file/directory with "flagship" in the name was the package directory, which is already being renamed when fixing the package directory structure. Resolves #895 * fix(fsweb): Use yarn.lock for fsweb (#906) Allows us to lock versions of subdependencies when running fsweb. * chore(release): publish v7.4.2 * fix(fsweb): Lock babel runtime in package.json (#905) package-lock.json doesn't get published by npm, so this removes it and locks the version in package.json. This still leaves us open to other package updates breaking web, so I will be following up to see if yarn.lock doesn't have this issue. * chore(release): publish v7.4.3 * chore: fix merge confict * chore: fix merge confict * feat(fscomponents): add custom modal content logic and test view * feat(fscomponents): add condition to render custom test modal content * Update README.md * chore(release): publish v7.5.0 * chore(release): publish v7.5.1 * chore(release): publish v7.5.2 * chore(release): publish v7.5.3 * chore(release): publish v7.5.4 * chore(pirateship): update react-native-svg library (#889) * chore: tell greenkeeper to ignore react and react native types These types should be updated in sync with Flagship updates to the React and React Native libraries. * feat(fsshopify): add safe undefined handler * feat(fsshopify): add safe undefined handler * feat(flagship): Add option to only include the default env (#925) * feat(flagship): Add option to only include the default env * chore(release): publish v7.6.0 * refactor: CreditCardNumber to avoid getDerivedStateFromProps (#926) * chore: Update generating info plist (#924) * feat(flagship): deprecate appcenter.apiconfig configuration option This deprecates the appcenter.apiConfig configuration option in favor of using the APPCENTER_API_TOKEN environment variable. This makes the key optional in the typedef and updates the Fastfiles for iOS and Android such that not including this option will not break the builds. * chore(release): publish v7.7.0 * chore: update dev dependencies to alleviate security issues (#932) This updates commitlint, jest, lerna, and typedoc to their latest versions. Because some of the concerns were not yet addressed by their parent packages, I also had to add custom resolutions for handlebars and https-proxy-agent. * chore(release): publish v7.7.1 * fix(fsbazaarvoice): fix review id normalizer (#936) review.id is normalized from `ProductId` which is not unique, on the contrary, the values are usually the same because the reviews are usually from the same product. `Id` provides unique values so using that instead * Update typedoc to the latest version 🚀 (#922) * chore: update typedoc to version 0.15.1 * Update yargs in group flagship to the latest version 🚀 (#929) * fix: update yargs to version 15.0.1 * Update husky to the latest version 🚀 (#930) chore: update husky to version 3.1.0 * chore: add error message if user runs tsc on top level (#944) * feat: update webpack dependencies - Update versions of terser-webpack-plugin, marked, and copy-webpack-plugin - Replaced uglify with terser for js minification in fsweb. The Uglify webpack plugin is no longer actively maintained. Test: - cd packages/pirateship - yarn run init:web --env shopify - cd web - yarn run start-prod - Server should listen to localhost:8080 - Inspect the bundle and verify it's minified and that the application is functional * feat(fsengagement): add animated card list for demo (#954) feat(fsengagement): add animated card list * feat(fsengagement): add image grid component (#947) * feat(fsengagement): add image grid component Ticket: https://jira.brandingbrand.com/browse/PARATROOPER-39 Description: -add image grid component to fsengagement * comments changes * feat(fsengagement): add language localization (#913) feat(fsengagement): add language localization Adds optional language localization * chore(release): publish v7.8.0 * fix(fscomponents): ModalHalfScreen listener height update (#957) * feat(flagship): add Android App Bundle (.aab) Support (#950) https://developer.android.com/guide/app-bundle Added a new Fastfile lane: appcenter_app_bundle * feat(pirateship): add enagement to pirateship demo (#959) * feat(pirateship): add enagement to pirateship demo * feat(pirateship): simplify story map * chore(pirateship): update provisioning profile (#960) * Update @types/yargs in group flagship to the latest version 🚀 (#962) * chore: update @types/yargs to version 13.0.4 * chore(package): update lockfile yarn.lock Co-authored-by: Brett Weissbart <phantomtails@gmail.com> * fix(fsapp): Adding deprecated backwards-compatibility functions Will now show an error about xib files needing to be converted to storyboard. Showing deprecation warning about tab.label and tab.icon, but will convert to the new format automatically. For the navigator, shows an error about handleDeepLink not existing, and adds backwards-compatible versions of resetTo, setStyle, setTabBadge, setTitle, and switchToTab that show deprecation warnings. * Update replace-in-file in group flagship to the latest version 🚀 (#953) * fix: update replace-in-file to version 5.0.2 * fix(fsapp): Fix screenwrapper appConfig * Update sinon in group flagship to the latest version 🚀 (#961) chore(package): update lockfile yarn.lock * Update markdownlint-cli to the latest version 🚀 (#956) chore: update markdownlint-cli to version 0.20.0 * fix(fsapp): Update redux and react I was getting errors (unable to access the store when calling connect) with redux 4.0.4, which went away after upgrading to 4.0.5. * Update @types/jest to the latest version 🚀 (#911) chore: update @types/jest to version 24.0.22 * chore: explicitly install node 10 for android ci step (#972) * Update husky to the latest version 🚀 (#970) * chore: update husky to version 4.0.2 * chore(package): update lockfile yarn.lock Co-authored-by: Brett Weissbart <phantomtails@gmail.com> * Update @types/yargs in group flagship to the latest version 🚀 (#969) * chore: update @types/yargs to version 15.0.0 * chore(package): update lockfile yarn.lock Co-authored-by: Brett Weissbart <phantomtails@gmail.com> * chore: update markdownlint-cli to version 0.21.0 * chore: update @types/memoize-one to version 5.1.2 (#893) Co-authored-by: Brett Weissbart <phantomtails@gmail.com> * chore: update @types/react-router-dom to version 5.1.2 (#910) Co-authored-by: Brett Weissbart <phantomtails@gmail.com> * fix: android fastline syntax error due to a trailing comma the script is not smart enough to decide if a comma is required and causing build errors. For now, the easiest way to fix the errors is to rearrange these lines * chore(release): publish v7.10.0 * chore(release): publish v7.10.0 * feat(flagship): update podfile to use cocoapods cdn BREAKING CHANGE: This requires updating CocoaPods (including in CI) to v1.7.2+ in order for pod install to work with the CDN. This allows CocoaPods to pull from their own CDN which avoids rate limiting when pulling sources from GitHub instead. * fix(flagship): Latest react-native-payments and react-native-swiper Also: - added supportLibVersion to the gradle file - advises what to do instead of calling setOnNavigatorEvent - fix for NativeModules.StatusBarManager.HEIGHT - fix for instances.filter being called on an object instead of an array * chore: empty commit to restart coveralls * chore(release): publish v8.0.0 * fix(flagship): Updated modules and fixed pirateship Android Jetifier doesn't run on hoisted modules, so this makes @brandingbrand/react-native-payments get updated. Also updated path-to-regexp to v6, react-native-svg to v10, react-native-webview to v8, react-native-video to 5, and removed the unused uglifyjs-webpack-plugin. Also updated all packages to the latest in-range version, excluding the @babel modules and modules that have it as a higher-versioned dependency, such as the @storybook modules. * refactor(fscomponents): FLAGSHIP-59 Updating To Function Component * refactor(fscomponents): FLAGSHIP-58 Updating To Function Component * fix(fscomponents): FLAGSHIP-64 - Make Shelf a function component * refactor(fscomponents): FLAGSHIP-60 Updating To Function Component * feat(fscomponents): Add formik, yup to fscomponents and LoginForm * refactor(fscomponents): FLAGSHIP-63 - Updating To Function Component * fix(flagship): Run react-native link to link assets Assets like fonts need to be linked so the application will have access to them. * refactor(fscomponents): FLAGSHIP-50 Update to a function component * refactor(fscomponents): FLAGSHIP-49 - Make AddressForm a function component * chore(fscomponents): memoize ImageWithOverlay.tsx (#988) * chore(fscomponents): convert Loading.tsx to functional component (#983) Co-authored-by: Brett Weissbart <phantomtails@gmail.com> * refactor(fscomponents): FLAGSHIP-51 Updating To Function Component (#984) * refactor(fscomponents): FLAGSHIP-69 Update to a function component * refactor(fscomponents): FLAGSHIP-55 Updating To Function Component (#985) * refactor(fscomponents): FLAGSHIP-56 Updating To Function Component (#986) * refactor(fscomponents): FLAGSHIP-71 Change to abstract classes * refactor(fscomponents): FLAGSHIP-72 Update to a function component * refactor(fscomponents): FLAGSHIP-74 Updating to function component * refactor(fscomponents): FLAGSHIP-67 Update to function component * chore(fstestproject): get test project working again Added up-to-date metro and babel configs and missing dependencies so the test project works. To run: yarn testproject:init && yarn testproject:run-ios * refactor(fscomponents): FLAGSHIP-101 Adding Accessibility To Component * chore: fix inaccurate comment * refactor(fscomponents): FLAGSHIP-103 Adding Accessibility To Component * refactor(fscomponents): FLAGSHIP-103 Adding New Translations * refactor(fscomponents): FLAGSHIP-65 Updating To Function Component (#1007) * refactor(fscomponents): FLAGSHIP-101 Adding New Translations ADA * refactor(fscomponents): FLAGSHIP-73 Update to a function component (#1008) * refactor(fscomponents): FLAGSHIP-105 Adding Accessibility To Component * refactor(fscomponents): FLAGSHIP-106 Adding New Translations and ADA * refactor(fscomponents): FLAGSHIP-66 Updating to function component (#1009) * refactor(fscomponents): FLAGSHIP-106 Adding Image Alt Text * feat(fscomponents): FLAGSHIP-102 accessibility for Filter * refactor(fscomponents): FLAGSHIP-91 update with translations * feat(fscomponents): FLAGSHIP-104 accessibility for Zoom carousel * refactor(fscomponents): FLAGSHIP-88 Add translations to alert * refactor(fscomponents): FLAGSHIP-85 update with translations * refactor(fscomponents): FLAGSHIP-86 update with translations * refactor(fscomponents): FLAGSHIP-87 update with translations * fix(fscomponents): replace Arial with sans-serif (#1030) * chore(release): publish v8.1.0 * refactor(fscomponents): FLAGSHIP-49 Updating to function component * refactor(fscomponents): FLAGSHIP-106 Adding Accessibility To Component * refactor(fscomponents): FLAGSHIP-96 Add Translation To Component * refactor(fscomponents): FLAGSHIP-95 Add Translation To Component * refactor(fscomponents): FLAGSHIP-97 Add Translations To Component * fix(pirateship): Update tab index for cart count (#1039) The tabs got shifted over one when the "Home" tab was added, but the cart count was being applied to the same index. This makes the cart count show up on the cart icon. * refactor(fscomponents): FLAGSHIP-89 Add Translations To Component * fix(fscomponents): Move story files to all live in the same folder (#1042) Them being in different folders was making them load in unpredictable orders, so they were no longer alphabetized. * feat(fslocator): add customized search functionality * refactor(fscomponents): FLAGSHIP-98 Add Translations To Component * refactor(fscomponents): FLAGSHIP-94 Add Translations To Component * fix(flagship): Update react-native-camera setup for RN61 * chore(release): publish v8.2.0 * feat(fsbazaarvoice): Expand review data source * refactor(fsbazaarvoice): simplify param code since qs strips out undefined params * chore(fsnetwork): fix fsnetwork unit tests Requesting the GitHub homepage with fsnetwork appears to consistently return a 406 error. This points the test at brandingbrand.com which resolves the error. * chore(release): publish v8.3.0 * fix(fsapp): react-native-navigation 4 This will require users to have XCode 11. Co-authored-by: Brett Weissbart <brett@brandingbrand.com> Co-authored-by: Alexandr <alexandrkorsia@gmail.com> Co-authored-by: Maxim <maxshop2010@gmail.com> Co-authored-by: alexsavosh <olexandor.s@gmail.com> Co-authored-by: Mauricio Perez <mauricio.perez@brandingbrand.com> Co-authored-by: Oleksandr Soloviov <olksns@gmail.com> Co-authored-by: Vance Hu <vancehu@users.noreply.github.com> Co-authored-by: Vladimir Sentiurin <volodymyr.sentiurin@gmail.com> Co-authored-by: Nathan Sankbeil <nathan.sankbeil@brandingbrand.com> Co-authored-by: Stefan Neamtu <stefan.neamtu@brandingbrand.com> Co-authored-by: Deema Abdallah <deema.abdallah@brandingbrand.com> Co-authored-by: greenkeeper[bot] <23040076+greenkeeper[bot]@users.noreply.github.com> Co-authored-by: Andrew Schwob <andy.schwob@brandingbrand.com> Co-authored-by: Shaheed Shamsi <shaheed.shamsi@brandingbrand.com> Co-authored-by: KO-HSIN CHU <kohsin.chu@brandingbrand.com> Co-authored-by: Brett Weissbart <phantomtails@gmail.com> Co-authored-by: willybeans <will.wedmedyk@brandingbrand.com> Co-authored-by: hearsh <hearsh.m@gmail.com> Co-authored-by: buticm <mikhail@brandingbrand.com> Co-authored-by: Huizhu Zhang <huizhu.zhang@brandingbrand.com> Co-authored-by: rosahbruno <rosahbruno@gmail.com> Co-authored-by: griffithcaleb <38706174+griffithcaleb@users.noreply.github.com> Co-authored-by: huizhuz <huizhuz@outlook.com> Co-authored-by: Nick Richter <nick@brandingbrand.com> Co-authored-by: Ko-Hsin Chu <chukohsin@gmail.com> * Merge develop into feature/rn-60 (#1088) * fix(flagship): add targeted device to both Debug and Release config * feat: Write Reviews Baazarvoice implementation * refactor: move denormalize function to separate file Keeping BazaarvoiceDataSource.ts clean * feat: Write review submission typings * fix: update react-native-htmlview to version 0.14.0 * feat(fsengagement): add new carousel option and full screen background * chore(release): publish v4.1.0 * chore: update react native cli dependency to 1.11.2 This should resolve an issue we're seeing in CI as described here: react-native-community/cli#586 * feat(fscomponents): add some option props to zoomCarousel **Description** added and implemented the following optional props: * hideZoomButton * A bool to show/hide zoom functionality * containerStyle * StyleProp to ensure that all wrapping elements are styled as desired * renderImageWeb * A function that returns a react node * feat(fscomponents): add nextArrowOnBlur prop to pass through * feat(fscomponents): extend changes to non web-specific zoomcarousel change containerStyle to fillContainer: bool * chore: pin react-native-permissions version react-native-permissions released a breaking change with 1.2.0 (way to semver guys) that removes support for React Native's built in Async Storage in favor of having a peer dependency for the newly released react native community async storage. Because we do not currently have a dependency on the new async storage package this causes an error. This PR pins react-native-permissions to the last good version until we have time to properly add support for the new async storage package. * fix(fsengagement): update react-native-video there are compile issues of 3.X react-native-video when compiling with react-native 0.59 version 4.x has better support with this react version * fix(fsapp): Put dev menu as first screen When there is a collision between the path matching for other screens and the dev menu, this will make the dev menu take priority. * chore: remove add-keys scripts in favor of more generic versions BREAKING CHANGE: This removes the add-keys-ios and add-keys-android scripts as they required an internal BB workflow to work. The new scripts, add-keys-ios-internal and add-keys-android-internal, can be configured with the environment files with passwords being passed in as environment variables. For usage instructions, see the new wiki article: https://github.com/brandingbrand/flagship/wiki/Signing-Your-Apps * chore: pin react-native-sensitive-info to 5.4.x * feat(fscomponents): support more styling options for MultiCarousel * feat(fscomponents): add hideZoomButton props to ZoomCarousel * fix: Add 'Marquis' feature to Button with title dynamically reflecting CTA state * chore(fscomponents): add missing typedef to modalhalfscreen component * fix(flagship): update string replace to work in new fastfile * build: upgrade deprecated webpack dev server * fix(flagship): fix fastlane build lane Added missing xcargs flags that tells xcode to make an unprovisioned build when "fastlane build" is executed. * chore: tell greenkeeper to ignore more dependencies react, metro-react-babel-preset, and babel should only be updated as part of coordinated React Native upgrades. * fix: Add itemCount to cart interface in fscommerce (#877) * fix: Modify the podspec version to ve 2.6.2 (#878) * feat(fsshopify): account data source implementation * build: upgrade deprecated webpack dev server * fix: remove unnecessary checks * fix(pirateship): Remove duplicate "name" in config (#867) * chore: Update react-native-masked-text * fix: exclude kotlin intermediate build files 3rd party libraries begin using Kotlin and intermediate`*.kotlin_module` files are causing build errors. Added this rule to exclude those files * chore: update react-dom library * chore: Update react-native-touch-id dependency * fix(flagship): Fix renaming edge case for android (#898) The only file/directory with "flagship" in the name was the package directory, which is already being renamed when fixing the package directory structure. Resolves #895 * fix(fsweb): Use yarn.lock for fsweb (#906) Allows us to lock versions of subdependencies when running fsweb. * chore(release): publish v7.4.2 * fix(fsweb): Lock babel runtime in package.json (#905) package-lock.json doesn't get published by npm, so this removes it and locks the version in package.json. This still leaves us open to other package updates breaking web, so I will be following up to see if yarn.lock doesn't have this issue. * chore(release): publish v7.4.3 * chore: fix merge confict * chore: fix merge confict * feat(fscomponents): add custom modal content logic and test view * feat(fscomponents): add condition to render custom test modal content * Update README.md * chore(release): publish v7.5.0 * chore(release): publish v7.5.1 * chore(release): publish v7.5.2 * chore(release): publish v7.5.3 * chore(release): publish v7.5.4 * chore(pirateship): update react-native-svg library (#889) * chore: tell greenkeeper to ignore react and react native types These types should be updated in sync with Flagship updates to the React and React Native libraries. * feat(fsshopify): add safe undefined handler * feat(fsshopify): add safe undefined handler * feat(flagship): Add option to only include the default env (#925) * feat(flagship): Add option to only include the default env * chore(release): publish v7.6.0 * refactor: CreditCardNumber to avoid getDerivedStateFromProps (#926) * chore: Update generating info plist (#924) * feat(flagship): deprecate appcenter.apiconfig configuration option This deprecates the appcenter.apiConfig configuration option in favor of using the APPCENTER_API_TOKEN environment variable. This makes the key optional in the typedef and updates the Fastfiles for iOS and Android such that not including this option will not break the builds. * chore(release): publish v7.7.0 * chore: update dev dependencies to alleviate security issues (#932) This updates commitlint, jest, lerna, and typedoc to their latest versions. Because some of the concerns were not yet addressed by their parent packages, I also had to add custom resolutions for handlebars and https-proxy-agent. * chore(release): publish v7.7.1 * fix(fsbazaarvoice): fix review id normalizer (#936) review.id is normalized from `ProductId` which is not unique, on the contrary, the values are usually the same because the reviews are usually from the same product. `Id` provides unique values so using that instead * Update typedoc to the latest version 🚀 (#922) * chore: update typedoc to version 0.15.1 * Update yargs in group flagship to the latest version 🚀 (#929) * fix: update yargs to version 15.0.1 * Update husky to the latest version 🚀 (#930) chore: update husky to version 3.1.0 * chore: add error message if user runs tsc on top level (#944) * feat: update webpack dependencies - Update versions of terser-webpack-plugin, marked, and copy-webpack-plugin - Replaced uglify with terser for js minification in fsweb. The Uglify webpack plugin is no longer actively maintained. Test: - cd packages/pirateship - yarn run init:web --env shopify - cd web - yarn run start-prod - Server should listen to localhost:8080 - Inspect the bundle and verify it's minified and that the application is functional * feat(fsengagement): add animated card list for demo (#954) feat(fsengagement): add animated card list * feat(fsengagement): add image grid component (#947) * feat(fsengagement): add image grid component Ticket: https://jira.brandingbrand.com/browse/PARATROOPER-39 Description: -add image grid component to fsengagement * comments changes * chore(release): publish v7.8.0 * fix(fscomponents): ModalHalfScreen listener height update (#957) * feat(flagship): add Android App Bundle (.aab) Support (#950) https://developer.android.com/guide/app-bundle Added a new Fastfile lane: appcenter_app_bundle * feat(pirateship): add enagement to pirateship demo (#959) * feat(pirateship): add enagement to pirateship demo * feat(pirateship): simplify story map * chore(pirateship): update provisioning profile (#960) * Update @types/yargs in group flagship to the latest version 🚀 (#962) * chore: update @types/yargs to version 13.0.4 * chore(package): update lockfile yarn.lock Co-authored-by: Brett Weissbart <phantomtails@gmail.com> * Update replace-in-file in group flagship to the latest version 🚀 (#953) * fix: update replace-in-file to version 5.0.2 * Update sinon in group flagship to the latest version 🚀 (#961) chore(package): update lockfile yarn.lock * Update markdownlint-cli to the latest version 🚀 (#956) chore: update markdownlint-cli to version 0.20.0 * Update @types/jest to the latest version 🚀 (#911) chore: update @types/jest to version 24.0.22 * chore: explicitly install node 10 for android ci step (#972) * Update husky to the latest version 🚀 (#970) * chore: update husky to version 4.0.2 * chore(package): update lockfile yarn.lock Co-authored-by: Brett Weissbart <phantomtails@gmail.com> * Update @types/yargs in group flagship to the latest version 🚀 (#969) * chore: update @types/yargs to version 15.0.0 * chore(package): update lockfile yarn.lock Co-authored-by: Brett Weissbart <phantomtails@gmail.com> * chore: update markdownlint-cli to version 0.21.0 * chore: update @types/memoize-one to version 5.1.2 (#893) Co-authored-by: Brett Weissbart <phantomtails@gmail.com> * chore: update @types/react-router-dom to version 5.1.2 (#910) Co-authored-by: Brett Weissbart <phantomtails@gmail.com> * fix: android fastline syntax error due to a trailing comma the script is not smart enough to decide if a comma is required and causing build errors. For now, the easiest way to fix the errors is to rearrange these lines * chore(release): publish v7.10.0 * chore(release): publish v7.10.0 * feat(flagship): update podfile to use cocoapods cdn BREAKING CHANGE: This requires updating CocoaPods (including in CI) to v1.7.2+ in order for pod install to work with the CDN. This allows CocoaPods to pull from their own CDN which avoids rate limiting when pulling sources from GitHub instead. * chore: empty commit to restart coveralls * chore(release): publish v8.0.0 * refactor(fscomponents): FLAGSHIP-59 Updating To Function Component * refactor(fscomponents): FLAGSHIP-58 Updating To Function Component * fix(fscomponents): FLAGSHIP-64 - Make Shelf a function component * refactor(fscomponents): FLAGSHIP-60 Updating To Function Component * feat(fscomponents): Add formik, yup to fscomponents and LoginForm * refactor(fscomponents): FLAGSHIP-63 - Updating To Function Component * refactor(fscomponents): FLAGSHIP-50 Update to a function component * refactor(fscomponents): FLAGSHIP-49 - Make AddressForm a function component * chore(fscomponents): memoize ImageWithOverlay.tsx (#988) * chore(fscomponents): convert Loading.tsx to functional component (#983) Co-authored-by: Brett Weissbart <phantomtails@gmail.com> * refactor(fscomponents): FLAGSHIP-51 Updating To Function Component (#984) * refactor(fscomponents): FLAGSHIP-69 Update to a function component * refactor(fscomponents): FLAGSHIP-55 Updating To Function Component (#985) * refactor(fscomponents): FLAGSHIP-56 Updating To Function Component (#986) * refactor(fscomponents): FLAGSHIP-71 Change to abstract classes * refactor(fscomponents): FLAGSHIP-72 Update to a function component * refactor(fscomponents): FLAGSHIP-74 Updating to function component * refactor(fscomponents): FLAGSHIP-67 Update to function component * chore(fstestproject): get test project working again Added up-to-date metro and babel configs and missing dependencies so the test project works. To run: yarn testproject:init && yarn testproject:run-ios * refactor(fscomponents): FLAGSHIP-101 Adding Accessibility To Component * chore: fix inaccurate comment * refactor(fscomponents): FLAGSHIP-103 Adding Accessibility To Component * refactor(fscomponents): FLAGSHIP-103 Adding New Translations * refactor(fscomponents): FLAGSHIP-65 Updating To Function Component (#1007) * refactor(fscomponents): FLAGSHIP-101 Adding New Translations ADA * refactor(fscomponents): FLAGSHIP-73 Update to a function component (#1008) * refactor(fscomponents): FLAGSHIP-105 Adding Accessibility To Component * refactor(fscomponents): FLAGSHIP-106 Adding New Translations and ADA * refactor(fscomponents): FLAGSHIP-66 Updating to function component (#1009) * refactor(fscomponents): FLAGSHIP-106 Adding Image Alt Text * feat(fscomponents): FLAGSHIP-102 accessibility for Filter * refactor(fscomponents): FLAGSHIP-91 update with translations * feat(fscomponents): FLAGSHIP-104 accessibility for Zoom carousel * refactor(fscomponents): FLAGSHIP-88 Add translations to alert * refactor(fscomponents): FLAGSHIP-85 update with translations * refactor(fscomponents): FLAGSHIP-86 update with translations * refactor(fscomponents): FLAGSHIP-87 update with translations * fix(fscomponents): replace Arial with sans-serif (#1030) * chore(release): publish v8.1.0 * refactor(fscomponents): FLAGSHIP-49 Updating to function component * refactor(fscomponents): FLAGSHIP-106 Adding Accessibility To Component * refactor(fscomponents): FLAGSHIP-96 Add Translation To Component * refactor(fscomponents): FLAGSHIP-95 Add Translation To Component * refactor(fscomponents): FLAGSHIP-97 Add Translations To Component * fix(pirateship): Update tab index for cart count (#1039) The tabs got shifted over one when the "Home" tab was added, but the cart count was being applied to the same index. This makes the cart count show up on the cart icon. * refactor(fscomponents): FLAGSHIP-89 Add Translations To Component * fix(fscomponents): Move story files to all live in the same folder (#1042) Them being in different folders was making them load in unpredictable orders, so they were no longer alphabetized. * feat(fslocator): add customized search functionality * refactor(fscomponents): FLAGSHIP-98 Add Translations To Component * refactor(fscomponents): FLAGSHIP-94 Add Translations To Component * chore(release): publish v8.2.0 * feat(fsbazaarvoice): Expand review data source * refactor(fsbazaarvoice): simplify param code since qs strips out undefined params * chore(fsnetwork): fix fsnetwork unit tests Requesting the GitHub homepage with fsnetwork appears to consistently return a 406 error. This points the test at brandingbrand.com which resolves the error. * chore(release): publish v8.3.0 * test(fsnetwork): fix network test with new url (#1074) * feat(fsbazaarvoice): Add recommended ratio to normalized data (#1077) * chore(release): publish v8.4.0 * chore(deps): bump acorn from 5.7.3 to 5.7.4 (#1083) Bumps [acorn](https://github.com/acornjs/acorn) from 5.7.3 to 5.7.4. - [Release notes](https://github.com/acornjs/acorn/releases) - [Commits](acornjs/acorn@5.7.3...5.7.4) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * feat(fsapp): Allow setting the application root tag (#1082) Right now the app can only be injected into an element with the id "root". This change allows passing a css selector or HTML element into the config with the key "root", which will cause the app to be loaded into the corresponding element on the page. Co-authored-by: Justin Endler <justin.endler@brandingbrand.com> Co-authored-by: Pavle Milicevic <pavle.milicevic@brandingbrand.com> Co-authored-by: DavidRhodesBB <41645989+DavidRhodesBB@users.noreply.github.com> Co-authored-by: greenkeeper[bot] <greenkeeper[bot]@users.noreply.github.com> Co-authored-by: Brett Weissbart <brett@brandingbrand.com> Co-authored-by: andy.schwob@brandingbrand.com <Andy.Schwob@ASchwob-L210.local> Co-authored-by: jcarvin <j.d.carvin@gmail.com> Co-authored-by: Nick Burkhart <nick.burkhart@brandingbrand.com> Co-authored-by: Ko-Hsin Chu <chukohsin@gmail.com> Co-authored-by: Oleksandr Soloviov <olksns@gmail.com> Co-authored-by: alexsavosh <olexandor.s@gmail.com> Co-authored-by: Alexandr <alexandrkorsia@gmail.com> Co-authored-by: Maxim <maxshop2010@gmail.com> Co-authored-by: Mauricio Perez <mauricio.perez@brandingbrand.com> Co-authored-by: Vance Hu <vancehu@users.noreply.github.com> Co-authored-by: Vladimir Sentiurin <volodymyr.sentiurin@gmail.com> Co-authored-by: Nathan Sankbeil <nathan.sankbeil@brandingbrand.com> Co-authored-by: Stefan Neamtu <stefan.neamtu@brandingbrand.com> Co-authored-by: Deema Abdallah <deema.abdallah@brandingbrand.com> Co-authored-by: greenkeeper[bot] <23040076+greenkeeper[bot]@users.noreply.github.com> Co-authored-by: Andrew Schwob <andy.schwob@brandingbrand.com> Co-authored-by: Shaheed Shamsi <shaheed.shamsi@brandingbrand.com> Co-authored-by: KO-HSIN CHU <kohsin.chu@brandingbrand.com> Co-authored-by: Brett Weissbart <phantomtails@gmail.com> Co-authored-by: willybeans <will.wedmedyk@brandingbrand.com> Co-authored-by: hearsh <hearsh.m@gmail.com> Co-authored-by: buticm <mikhail@brandingbrand.com> Co-authored-by: Huizhu Zhang <huizhu.zhang@brandingbrand.com> Co-authored-by: rosahbruno <rosahbruno@gmail.com> Co-authored-by: griffithcaleb <38706174+griffithcaleb@users.noreply.github.com> Co-authored-by: huizhuz <huizhuz@outlook.com> Co-authored-by: Nick Richter <nick@brandingbrand.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * chore: fix type conflicts for storybook This allows storybook to run by fixing typing issues that arose in a couple files due to differences between RN and web APIs. * fix(flagship): Downgrade typedoc to 15 (#1091) typedoc 16 isn't compatible with the latest version of typedoc-plugin-monorepo, because it gets rid of OptionsReadMode. This change will allow build:docs to work again. * chore: tag packages as 9.0.0 * chore: change travis build to xcode 11.3 Co-authored-by: andy.schwob@brandingbrand.com <Andy.Schwob@ASchwob-L210.local> Co-authored-by: Ko-Hsin Chu <chukohsin@gmail.com> Co-authored-by: Ko-Hsin Chu <kohsin.chu@Ko-Hsins-MacBook-Pro.local> Co-authored-by: Nathan Sankbeil <nathan.sankbeil@brandingbrand.com> Co-authored-by: Vance Hu <vance.hu@brandingbrand.com> Co-authored-by: Andrew Schwob <andy.schwob@brandingbrand.com> Co-authored-by: Cauldrath <ben@brandingbrand.com> Co-authored-by: Vance Hu <vancehu@users.noreply.github.com> Co-authored-by: Alexandr <alexandrkorsia@gmail.com> Co-authored-by: Maxim <maxshop2010@gmail.com> Co-authored-by: alexsavosh <olexandor.s@gmail.com> Co-authored-by: Mauricio Perez <mauricio.perez@brandingbrand.com> Co-authored-by: Oleksandr Soloviov <olksns@gmail.com> Co-authored-by: Vladimir Sentiurin <volodymyr.sentiurin@gmail.com> Co-authored-by: Stefan Neamtu <stefan.neamtu@brandingbrand.com> Co-authored-by: Deema Abdallah <deema.abdallah@brandingbrand.com> Co-authored-by: greenkeeper[bot] <23040076+greenkeeper[bot]@users.noreply.github.com> Co-authored-by: Shaheed Shamsi <shaheed.shamsi@brandingbrand.com> Co-authored-by: KO-HSIN CHU <kohsin.chu@brandingbrand.com> Co-authored-by: willybeans <will.wedmedyk@brandingbrand.com> Co-authored-by: hearsh <hearsh.m@gmail.com> Co-authored-by: buticm <mikhail@brandingbrand.com> Co-authored-by: Huizhu Zhang <huizhu.zhang@brandingbrand.com> Co-authored-by: rosahbruno <rosahbruno@gmail.com> Co-authored-by: griffithcaleb <38706174+griffithcaleb@users.noreply.github.com> Co-authored-by: huizhuz <huizhuz@outlook.com> Co-authored-by: Nick Richter <nick@brandingbrand.com> Co-authored-by: Justin Endler <justin.endler@brandingbrand.com> Co-authored-by: Pavle Milicevic <pavle.milicevic@brandingbrand.com> Co-authored-by: DavidRhodesBB <41645989+DavidRhodesBB@users.noreply.github.com> Co-authored-by: greenkeeper[bot] <greenkeeper[bot]@users.noreply.github.com> Co-authored-by: jcarvin <j.d.carvin@gmail.com> Co-authored-by: Nick Burkhart <nick.burkhart@brandingbrand.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

fix: Add itemCount to cart interface in fscommerce

1f4bc88

bweissbart approved these changes Oct 23, 2019

View reviewed changes

bweissbart merged commit 53b02c3 into brandingbrand:develop Oct 23, 2019

bweissbart mentioned this pull request Nov 8, 2019

Add itemCount to cart interface in fscommerce #169

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: Add itemCount to cart interface in fscommerce #877

fix: Add itemCount to cart interface in fscommerce #877

olkorsia commented Oct 23, 2019

fix: Add itemCount to cart interface in fscommerce #877

fix: Add itemCount to cart interface in fscommerce #877

Conversation

olkorsia commented Oct 23, 2019