Merge branch 'development'

.gitignore

@@ -25,4 +25,6 @@ yarn-error.log*
 yalc.lock
 
 # Generated OpenAPI types file - we don't use it after parsing it into individual interfaces/types/etc
-src/generated/supabase-types.ts
+src/generated/supabase-types.ts
+
+.eslintcache

package.json

@@ -20,7 +20,7 @@
         "glamor": "2.20.40",
         "humanize-plus": "1.8.2",
         "immutable": "4.0.0",
-        "jotai": "1.7.1",
+        "jotai": "1.7.2",
         "keymirror": "0.1.1",
         "lodash": "4.17.21",
         "luxon": "2.4.0",
@@ -91,7 +91,7 @@
     },
     "lint-staged": {
         "*.{ts,tsx,json,md}": "prettier --ignore-unknown --write",
-        "*.{ts,tsx}": "eslint --fix"
+        "*.{ts,tsx}": "eslint --cache --fix"
     },
     "name": "beets",
     "private": true,
@@ -104,7 +104,7 @@
         "eject": "react-scripts eject",
         "format:check": "prettier src --ignore-unknown --check",
         "format:fix": "prettier src --ignore-unknown --write",
-        "lint": "eslint 'src/**/*.{ts,tsx}'",
+        "lint": "eslint 'src/**/*.{ts,tsx}' --cache",
         "lint:fix": "npm run lint -- --fix",
         "migrations:create": "node-pg-migrate --migrations-dir src/scripts/migrations --template-file-name src/scripts/migrations/utils/migration-template.ts create",
         "migrations:down": "node-pg-migrate --migrations-dir src/scripts/migrations/dist down",

src/components/files/file-select-menu.tsx

@@ -62,7 +62,7 @@ const FileSelectMenu: React.FC<PropsWithChildren<FileSelectMenuProps>> = (
         assigned,
         children,
         hasFilter,
-        hasTitle,
+        hasTitle = true,
         isMultiSelect = false,
         onDeselect,
         onSelect,
@@ -84,6 +84,12 @@ const FileSelectMenu: React.FC<PropsWithChildren<FileSelectMenuProps>> = (
 
     const options: Array<SelectMenuItem<FileRecord>> = useMemo(() => {
         let filteredFiles: List<FileRecord> = files ?? List();
+        // We can't show the filter popover without the title component being rendered, so don't
+        // apply the filters without the user understanding where they came from
+        if (!hasTitle) {
+            return toSelectMenuItems(filteredFiles);
+        }
+
         if (showAssigned) {
             filteredFiles = assigned ?? List();
         }