Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Windows/Linux support for keyboard shortcuts #186

Merged
merged 2 commits into from
Apr 24, 2022
Merged

Add Windows/Linux support for keyboard shortcuts #186

merged 2 commits into from
Apr 24, 2022

Conversation

khaki32
Copy link
Contributor

@khaki32 khaki32 commented Apr 24, 2022

Adds support for non Mac systems to use the Save File and Duplicate Selection keyboard shortcuts.

@khaki32
Copy link
Contributor Author

khaki32 commented Apr 24, 2022

I just realized that this isn't visualized: oops. I want to add that the correct key (cmd or ctrl) is shown based on the user's system.

Copy link
Owner

@brandongregoryscott brandongregoryscott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution! 👍

@brandongregoryscott
Copy link
Owner

brandongregoryscott commented Apr 24, 2022

I just realized that this isn't visualized: oops. I want to add that the correct key (cmd or ctrl) is shown based on the user's system.

Ah, yeah - I had thought about that too - ideally I think it would be limited based on the user's OS but I'm not sure it's a huge deal if both ctrl or cmd triggers the shortcuts while on Mac for the time being. If you want to add it in, feel free and I can hold off on merging 👍

Edit: oh, I understand what you mean:

image

@brandongregoryscott brandongregoryscott merged commit 3b80ba2 into brandongregoryscott:development Apr 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants