#531 Temporary fix for BottomSheet to show also when ReducedMotion is on #604
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PavelFilo
approved these changes
Jul 25, 2024
github-actions
bot
added
pr: fix & ship 🚢
This was referenced Jul 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BottomSheetdidn't appear on three-dots button press in Vehicles screen and Ticket History screenThe issue is probably caused when ReducedMotion is enabled. Note that
ReducedMotionis also enabled when battery is <10% (on ios).Quick explanation of the problem and the fix:
With newer version of
react-native-reanimatedthat included support forReducedMotion,BottomSheethas problem to appear ifReducedMotionis enabled. It's supposed to be fixed in BottomSheet version 4.6.3 (latests at this time), but people write it's still buggy, and the upgrade to newer version should be done with proper testing, not as quick fix.So I decided to use the hot-fix: disable
animateOnMountwhenReducedMotionis used.People also mentioned problem with this hot-fix with
.dismiss(), but we use.close()instead of.dismiss()and it worked okay when I tested it.Tested locally on iphone 15 on physical device with ReducedMotion enabled ✅
See more in the issue thread: gorhom/react-native-bottom-sheet#1560