This repository has been archived by the owner on May 12, 2020. It is now read-only.
Block coin miners by default with Brave shields up #74
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bbondy
force-pushed
the
block-coin-miners
branch
from
8aae309
to
16d6809
Compare
Testing notes: 1. Close Brave 2. Use new test data file uploaded to the PR. 3. Open Brave 4. Visit https://cnhv.co/6or 5. Turn off shieods Step 4 should not load the page, but if you turn shields down it will.
bbondy
force-pushed
the
block-coin-miners
branch
from
16d6809
to
5be1243
Compare
bbondy
changed the title
|
Agree 100%. |
lukemulks
approved these changes
Sep 18, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Coin mining in the browser is sometimes abused and can lead to greater CPU usage, especially bad on mobile.
I'm in favour of it.