Skip to content
This repository has been archived by the owner on Jun 6, 2019. It is now read-only.

Adds validation function for passphrase #45

Merged
merged 1 commit into from
Mar 20, 2018
Merged

Adds validation function for passphrase #45

merged 1 commit into from
Mar 20, 2018

Conversation

NejcZdovc
Copy link
Contributor

@NejcZdovc NejcZdovc commented Mar 19, 2018 •
edited
Loading

We need to have this function to complete brave/browser-laptop#13424

@NejcZdovc NejcZdovc force-pushed the valid-pass branch 2 times, most recently from c103f07 to d101e90 Compare March 19, 2018 23:12
@NejcZdovc NejcZdovc requested a review from mrose17 March 19, 2018 23:12
@NejcZdovc NejcZdovc self-assigned this Mar 19, 2018
mrose17
mrose17 suggested changes Mar 19, 2018
View reviewed changes
Copy link
Contributor

@mrose17 mrose17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the second argument to memo should be an object, (e.g., { reason: '...' }) not just a string (e.g., '...')

@NejcZdovc NejcZdovc requested a review from mrose17 March 20, 2018 19:42
mrose17
mrose17 approved these changes Mar 20, 2018
View reviewed changes
Copy link
Contributor

@mrose17 mrose17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@NejcZdovc NejcZdovc merged commit 7ae5250 into brave-intl:master Mar 20, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mrose17 mrose17 mrose17 approved these changes

Assignees

@NejcZdovc NejcZdovc

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@NejcZdovc @mrose17