Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

don't take current balance into account #19

Merged
merged 3 commits into from
Jun 4, 2018
Merged

don't take current balance into account #19

merged 3 commits into from
Jun 4, 2018

Conversation

evq
Copy link
Contributor

@evq evq commented May 31, 2018 •
edited
Loading

@evq evq requested a review from nvonpentz May 31, 2018 17:14
@nvonpentz
Copy link
Collaborator

It looks these changes increase the amount of grants needed for VerifyAndConsume from tx amount - user balance to just tx amount. This looks good to me.

I see that we raise an error if too many grants are included. How do we determine if not enough grants are included to cover the tx amount?

@evq evq merged commit 5eea093 into master Jun 4, 2018
@evq evq deleted the useGrantsFirst branch June 4, 2018 22:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nvonpentz nvonpentz nvonpentz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@evq @nvonpentz