Bump MACOSX_DEPLOYMENT_TARGET to 10.13 #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alucarded
force-pushed
the
min_version_bump
branch
from
d865e06
to
0730246
Compare
alucarded
changed the title
|
@simonhong Why it is not reviewed yet, is there any issues in this PR. |
alucarded
changed the title
|
@mherrmann Curious we also have this issue in our CI build? |
|
@simonhong we use pre-built copies of Sparkle and it's possible that this issue started occurring after our latest actual build of the binaries. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #25
Build started failing after switching to latest macOS Ventura 13.4 and Xcode 14.3.
Also, the supported deployment target versions start at 10.13 there:
../Sparkle.xcodeproj: warning: The macOS deployment target 'MACOSX_DEPLOYMENT_TARGET' is set to 10.9, but the range of supported deployment target versions is 10.13 to 13.3.99. (in target 'Autoupdate' from project 'Sparkle')