Tighten debounce patterns #899
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fmarier
force-pushed
the
tighten-debounce-patterns
branch
2 times, most recently
from
d314b74 to
fc1033e
Compare
The query string is not likely to be as stable as the rest of the URL and as long as it contains the required param then we can debounce.
fmarier
force-pushed
the
tighten-debounce-patterns
branch
from
fc1033e to
4af91ef
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are three different things going on in this PR (see the three individual commits for a short description).
The patterns that were tightened are based on all of the samples I could find in my investigation.
Sample URLs that were either missing from GitHub paper trail or where the URLs we had no longer worked: