Narrow selector on deamp to not affect non-AMP links #68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@pes10k have you tested this? I'm not seeing any change in behaviour, but maybe I'm messing up the testing. |
|
I tested though manual code injection. But you still see the photo close button selected by that selector?
… On May 4, 2022, at 16:24, Shivan Kaul Sahib ***@***.***> wrote:
@pes10k have you tested this? I'm not seeing any change in behaviour, but maybe I'm messing up the testing.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you were mentioned.
|
|
Ah, was not using the right |
ShivanKaul
approved these changes
May 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
from Slack
Hi! I got some feedback for De-Amp. On Desktop and Android, when I click close button on Google image search, it move to google search top page. And it works correctly(close the side panel) if De-Amp is disabled.