This repository has been archived by the owner on Jan 8, 2024. It is now read-only.
Report exception/important matches through engine.matches API
#4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antonok-edm
force-pushed
the
important-signature
branch
from
0204579 to
b53294f
Compare
32 tasks
antonok-edm
force-pushed
the
important-signature
branch
from
c84d841 to
31c37af
Compare
antonok-edm
changed the title
engine.matches APIengine.matches API
23 tasks
bbondy
approved these changes
Jan 21, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This introduces a new boolean output argument to
engine.matchesthat represents whether or not a matched network filter isimportant.Additionally, this changes
saved_from_exceptionto justdid_match_exceptionand usestrueas the return value only when a filter matches. This way, it's possible to determine whether or not an exception matched even if no filter was matched.Depends on changes from brave/adblock-rust/pull/42
Intended as part of the fix for brave/brave-browser#5440