Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filter list not fully working #313

Open
ghost opened this issue Sep 26, 2023 · 3 comments
Open

Filter list not fully working #313

ghost opened this issue Sep 26, 2023 · 3 comments

Comments

@ghost
Copy link

ghost commented Sep 26, 2023

I have added some ag filter lists as a custom filter to the shields which is based on adblock plus syntax. but those filter lists does not fully working with shields. Kindly resolve the issue.

@antonok-edm
Copy link
Collaborator

@Green-Leaves500 could you provide a link to the lists and/or specific filters that are not working?

@antonok-edm
Copy link
Collaborator

Looking at mail.com-related filters:

mail.com#?##content > .content-wrapper > .mod-container > .container-headline:has(> p:contains(/^SPONSORED NEWS$/))
mail.com#?#.content-wrapper > div[data-mod-name="container"]:has(> div > p:contains(/sponsored news/i))
mail.com#?#.blocks > div.block:has(> div.ad-container)
mail.com#?#.content-wrapper > div.mod-container > div.blocks > div.block > div.mod-taboolateasers:upward(div.mod-container)

Only the 3rd one uses supported syntax at the moment. The other 3 use :contains or :upward, which are procedural filters (see #293). I am working on them, but it won't work quite yet.

In the other list, related to gmx.com:

web.de,gmx.net,gmx.at,gmx.ch,gmx.com#$##abd-container { display: block !important; }

We don't support the #$#-syntax for :style(). That may also come at some point in the future, but not for now.


Generally, my recommendation is to stick with uBlock Origin-flavor syntax when possible. For example, Easylist Cookie List is very well supported by adblock-rust/Brave.

@superlex
Copy link

@Green-Leaves500
They know it :)
#236
#293

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants