Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support AdGuard scriptlet syntax #324

Open
antonok-edm opened this issue Nov 16, 2023 · 1 comment
Open

support AdGuard scriptlet syntax #324

antonok-edm opened this issue Nov 16, 2023 · 1 comment
Labels
enhancement New feature or request uBO-parity pending features that are already available in uBO

Comments

@antonok-edm
Copy link
Collaborator

AdGuard uses #%#//scriptlet(...) for scriptlet injection syntax, whereas uBO filter lists generally use +js(...). AdGuard's syntax requires quoting, which is supported in adblock-rust as of v0.8.3, so it could now be supported as an additional syntax alias.

@antonok-edm antonok-edm added the enhancement New feature or request label Nov 16, 2023
@superlex
Copy link

superlex commented Nov 30, 2023

Good idea. Currently AG filters lists use uBO scriptlet syntax (##+js(...)), but since uBO now supports the AG one (#%#//scriptlet(...)) probably in the future they will use their own syntax.

However, as of now I think is more important adblock-rust supports AdGuard cosmetic filter variants (#236) and other procedural filters (#293) because this will improve adblocking quality a lot.

@antonok-edm antonok-edm added the uBO-parity pending features that are already available in uBO label May 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request uBO-parity pending features that are already available in uBO
Projects
None yet
Development

No branches or pull requests

2 participants