-
Notifications
You must be signed in to change notification settings - Fork 169
Optimize resource storage memory #517
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
+69
−16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rust Benchmark
Benchmark suite | Current: 7864b74 | Previous: dc5ab3c | Ratio |
---|---|---|---|
rule-match-browserlike/brave-list |
2241563378 ns/iter (± 11411310 ) |
2257715931 ns/iter (± 10970298 ) |
0.99 |
rule-match-first-request/brave-list |
1033504 ns/iter (± 8329 ) |
1027898 ns/iter (± 7402 ) |
1.01 |
blocker_new/brave-list |
153195531 ns/iter (± 1618122 ) |
160723930 ns/iter (± 937821 ) |
0.95 |
blocker_new/brave-list-deserialize |
64567666 ns/iter (± 833904 ) |
69177062 ns/iter (± 1097554 ) |
0.93 |
memory-usage/brave-list-initial |
18344519 ns/iter (± 3 ) |
18858505 ns/iter (± 3 ) |
0.97 |
memory-usage/brave-list-initial/max |
66961309 ns/iter (± 3 ) |
66961309 ns/iter (± 3 ) |
1 |
memory-usage/brave-list-initial/alloc-count |
1616130 ns/iter (± 3 ) |
1616130 ns/iter (± 3 ) |
1 |
memory-usage/brave-list-1000-requests |
2551938 ns/iter (± 3 ) |
2551938 ns/iter (± 3 ) |
1 |
memory-usage/brave-list-1000-requests/alloc-count |
68864 ns/iter (± 3 ) |
68835 ns/iter (± 3 ) |
1.00 |
url_cosmetic_resources/brave-list |
203095 ns/iter (± 2033 ) |
208414 ns/iter (± 1653 ) |
0.97 |
cosmetic-class-id-match/brave-list |
4334884 ns/iter (± 1183117 ) |
4317439 ns/iter (± 1187009 ) |
1.00 |
This comment was automatically generated by workflow using github-action-benchmark.
boocmp
approved these changes
Sep 12, 2025
0e01724
to
6acaa5a
Compare
6acaa5a
to
345e1d7
Compare
antonok-edm
approved these changes
Sep 12, 2025
antonok-edm
approved these changes
Sep 12, 2025
This was referenced Sep 16, 2025
atuchin-m
added a commit
to brave/brave-core
that referenced
this pull request
Sep 17, 2025
The adblock-rust changes to publish: brave/adblock-rust#517 This should partially address the perf issue related to the resource memory usage.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR supports decoding resources before storing it. This optimize memory usage of
ResourceStorage
by ~30%.ResourceImpl
internal struct to store decoded resourcesget_redirect_resource()
)