Skip to content

Conversation

@atuchin-m
Copy link
Collaborator

@atuchin-m atuchin-m commented Sep 26, 2025

Fixing new cargo clippy warnings.

CI builds are breaking for Linux and Windows: https://github.com/brave/adblock-rust/actions/runs/18017996352/job/51267830599?pr=519

Rust 1.90 introduced new linter rules, which broke CI.

@atuchin-m atuchin-m self-assigned this Sep 26, 2025
@atuchin-m atuchin-m requested a review from a team as a code owner September 26, 2025 08:21
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rust Benchmark

Benchmark suite Current: a33b8ef Previous: b9496d8 Ratio
rule-match-browserlike/brave-list 2252296534 ns/iter (± 11247199) 2302005495 ns/iter (± 14715066) 0.98
rule-match-first-request/brave-list 1045612 ns/iter (± 7705) 1033496 ns/iter (± 12609) 1.01
blocker_new/brave-list 154332359 ns/iter (± 641607) 162331363 ns/iter (± 1589318) 0.95
blocker_new/brave-list-deserialize 67196901 ns/iter (± 1422194) 74830341 ns/iter (± 415318) 0.90
memory-usage/brave-list-initial 18344519 ns/iter (± 3) 18344503 ns/iter (± 3) 1.00
memory-usage/brave-list-initial/max 66961309 ns/iter (± 3) 66961277 ns/iter (± 3) 1.00
memory-usage/brave-list-initial/alloc-count 1616130 ns/iter (± 3) 1616082 ns/iter (± 3) 1.00
memory-usage/brave-list-1000-requests 2551938 ns/iter (± 3) 2551890 ns/iter (± 3) 1.00
memory-usage/brave-list-1000-requests/alloc-count 68864 ns/iter (± 3) 68816 ns/iter (± 3) 1.00
url_cosmetic_resources/brave-list 204806 ns/iter (± 2057) 206268 ns/iter (± 3103) 0.99
cosmetic-class-id-match/brave-list 4267320 ns/iter (± 1177973) 4307309 ns/iter (± 1213491) 0.99

This comment was automatically generated by workflow using github-action-benchmark.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Performance Alert ⚠️

Possible performance regression was detected for benchmark 'Rust Benchmark'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.10.

Benchmark suite Current: 01eadb0 Previous: 3652b04 Ratio
blocker_new/brave-list-deserialize 70982453 ns/iter (± 910681) 63494627 ns/iter (± 260374) 1.12

This comment was automatically generated by workflow using github-action-benchmark.

@atuchin-m atuchin-m enabled auto-merge (squash) September 29, 2025 18:58
@atuchin-m atuchin-m merged commit ea5dc7a into master Sep 29, 2025
9 checks passed
@atuchin-m atuchin-m deleted the fix-cargo-clippy-2 branch September 29, 2025 19:15
atuchin-m added a commit that referenced this pull request Oct 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants