-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add a dismissible conversion change warning #1249
Conversation
Sharing my feedback from Slack, but it's not a blocker. I'd prefer to display the link more cleanly as one of these: |
[puLL-Merge] - brave/ads-ui@1249 DescriptionThis PR makes significant changes to the conversion tracking functionality in the Brave Ads UI. It simplifies the conversion setup process, updates the user interface, and adds a new alert about changes to conversion reporting. ChangesChanges
Possible Issues
Security HotspotsNo significant security issues were identified in this change. However, ensure that the new ConversionAlert component doesn't expose any sensitive information and that the link to the help center is correctly implemented to prevent potential phishing attempts. |
This was introduced nearly a month ago in #1249. It can now be removed as all that need to have seen it will have done so.
This was introduced nearly a month ago in #1249. It can now be removed as all that need to have seen it will have done so.
Lets the end user know conversions have stricter enforcement: