Skip to content

Commit

Permalink
Merge pull request #5055 from brave/pr5046_android_download_problem_1…
Browse files Browse the repository at this point in the history
….7.x

Adds approproate Android permissions for download
  • Loading branch information
kjozwiak authored Mar 25, 2020
2 parents 618ff44 + aa3b17f commit 44fb3aa
Show file tree
Hide file tree
Showing 2 changed files with 11 additions and 2 deletions.
1 change: 1 addition & 0 deletions android/java/res_template/xml/file_paths.xml
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@
<!-- for the ContentProvider. -->

<paths xmlns:android="http://schemas.android.com/apk/res/android">
<root-path name="root" path="." />
<files-path name="images" path="images/"/>
<cache-path name="cache" path="net-export/"/>
<cache-path name="passwords" path="passwords/"/>
Expand Down
12 changes: 10 additions & 2 deletions patches/chrome-android-java-AndroidManifest.xml.patch
Original file line number Diff line number Diff line change
@@ -1,8 +1,16 @@
diff --git a/chrome/android/java/AndroidManifest.xml b/chrome/android/java/AndroidManifest.xml
index 4a4ef4f6a6245b36b39f1f901bf13c6d8a8c42f8..4011af4a1c7232075ec94fe28716cf5e76b0d9d0 100644
index 4a4ef4f6a6245b36b39f1f901bf13c6d8a8c42f8..9008cf1c138ab35a7f1cd9e3f5ffccf0a62a00b0 100644
--- a/chrome/android/java/AndroidManifest.xml
+++ b/chrome/android/java/AndroidManifest.xml
@@ -1307,6 +1307,7 @@ android:value="true" />
@@ -125,6 +125,7 @@ by a child template that "extends" this file.
<!-- Set android:largeHeap to "true" to allow more than the default
Java heap limit (32Mb on Nexus S, 48Mb on Xoom). -->
<application android:name="{% block application_name %}org.chromium.chrome.browser.ChromeApplication{% endblock %}"
+ android:requestLegacyExternalStorage="true"
android:icon="@drawable/ic_launcher"
android:roundIcon="@drawable/ic_launcher_round"
android:label="{% block application_label %}@string/app_name{% endblock %}"
@@ -1307,6 +1308,7 @@ android:value="true" />
</activity>
{% endif %}

Expand Down

0 comments on commit 44fb3aa

Please sign in to comment.