Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Desktop] Better handling of restore tabs after crash #10017

Open
jficz opened this issue May 30, 2020 · 0 comments
Open

[Desktop] Better handling of restore tabs after crash #10017

jficz opened this issue May 30, 2020 · 0 comments
Labels
Chromium/waiting upstream Issue is in Chromium; we'll likely wait for the fix OS/Desktop priority/P5 Not scheduled. Don't anticipate work on this any time soon.

Comments

@jficz
Copy link

jficz commented May 30, 2020

Description

Currently when Brave "crashes" user gets at most one opportunity to restore the crashed session. If, for whatever reason, user doesn't click "restore" on the easily dismissable popup as the first thing when Brave starts, the session is lost forever.

Steps to Reproduce

  1. open multiple tabs
  2. crash Brave (kill -9 for example)
  3. do anything except clicking "restore"

Actual result:

Crashed session is lost forever.

Expected result:

An option to restore at least the last session should be available via menu at any time after Brave starts, regardless of current session state. The user should have an option to either "overwrite" current session with a previous one or "merge" the sessions, perhaps opening the old session in new window(s).

Saving multiple previous sessions would be even better.

Also, an option to restore crashed session automatically should be available to the user.

Ideally the session management should allow user to choose not just the session but individual tabs from that session, too.

Reproduces how often:

Each time Brave "crashes".

Brave version (brave://version info)

Brave 1.7.92 Chromium: 80.0.3987.163 (Official Build) (64-bit)
Revision e7fbe071abe9328cdce4ffedac9822435fbd3656-refs/branch-heads/3987@{#1037}
OS Linux
JavaScript V8 8.0.426.30
Flash (Disabled)
User Agent Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/80.0.3987.163 Safari/537.36
Command Line /nix/store/s07wvhvhmk0m81zrsk4b1nawjfr31jph-brave-1.7.92/opt/brave.com/brave/brave --enable-dom-distiller --disable-domain-reliability --no-pings --extension-content-verification=enforce_strict --extensions-install-verification=enforce --sync-url=https://no-thanks.invalid --enable-features=AutoupgradeMixedContent,PassiveMixedContentWarning,MixedContentSiteSetting,SimplifyHttpsIndicator,WebUIDarkMode,PasswordImport,DnsOverHttps --disable-features=AutofillServerCommunication,AllowPopupsDuringPageUnload,LookalikeUrlNavigationSuggestionsUI,SmsReceiver,AudioServiceOutOfProcess,NotificationTriggers,VideoPlaybackQuality --flag-switches-begin --load-media-router-component-extension=1 --flag-switches-end --disable-webrtc-apm-in-audio-service --disable-sync
Executable Path /nix/store/s07wvhvhmk0m81zrsk4b1nawjfr31jph-brave-1.7.92/opt/brave.com/brave/brave
Profile Path /home/user/.config/BraveSoftware/Brave-Browser/Default

Version/Channel Information:

  • Can you reproduce this issue with the current release?
  • Can you reproduce this issue with the beta channel?
  • Can you reproduce this issue with the dev channel?
  • Can you reproduce this issue with the nightly channel?

Didn't try (yet).

Other Additional Information:

N/A

Miscellaneous Information:

N/A

@rebron rebron added the Chromium/waiting upstream Issue is in Chromium; we'll likely wait for the fix label Jul 10, 2020
@rebron rebron added priority/P5 Not scheduled. Don't anticipate work on this any time soon. OS/Desktop labels Jul 17, 2020
@srirambv srirambv changed the title Better handling of restore tabs after crash [Desktop] Better handling of restore tabs after crash Sep 9, 2020
@rebron rebron added this to General May 28, 2024
@rebron rebron moved this to Needs Info in General May 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Chromium/waiting upstream Issue is in Chromium; we'll likely wait for the fix OS/Desktop priority/P5 Not scheduled. Don't anticipate work on this any time soon.
Projects
Status: Needs Info
Development

No branches or pull requests

2 participants