Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Context menu search uses wrong search engine on private tabs #1037

Closed
srirambv opened this issue Sep 8, 2018 · 2 comments · Fixed by brave/brave-core#757
Closed

Context menu search uses wrong search engine on private tabs #1037

srirambv opened this issue Sep 8, 2018 · 2 comments · Fixed by brave/brave-core#757
Assignees
@simonhong
Labels
bug feature/private-browsing QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release/blocking release-notes/include
Milestone
0.58.x - Release ...

Comments

@srirambv
Copy link
Contributor

srirambv commented Sep 8, 2018

Description

Context menu search uses wrong search engine on private tabs

Steps to Reproduce

  1. Open a private window
  2. Enable DDG switch and search for a term, uses DDG as default search engine
  3. Highlight a text on the result page and right click Search on DuckDuckGo for "highlited word", opens a new tab with search results on Google which is the default search engine on profile

Actual result:

https://youtu.be/XHAOB437u10

Expected result:

Should use DDG for context menu search as well

Reproduces how often:

100%

Brave version (about:brave info)

Brave 0.55.2 Chromium: 70.0.3528.4 (Official Build) dev (64-bit)
Revision 1911f781145b803e04f2d0b5b1a0146ae69fcbdc-refs/branch-heads/3528@{#9}
OS Windows/Linux

Reproducible on current release:

No

Website problems only:

  • Does the issue resolve itself when disabling Brave Shields?
  • Is the issue reproducible on the latest version of Chrome?

Additional Information

Doesn't happen on normal tabs. Context menu uses the set default search engine to show results.
@srirambv srirambv added this to the Releasable builds 0.55.x milestone Sep 8, 2018
@simonhong simonhong self-assigned this Sep 8, 2018
@bbondy bbondy modified the milestones: Releasable builds 0.55.x, 1.x Backlog Sep 9, 2018
This was referenced Oct 29, 2018
Closed
Merged
@bbondy bbondy modified the milestones: 1.x Backlog, 0.58.x - Nightly Oct 30, 2018
@bbondy
Copy link
Member

bbondy commented Oct 30, 2018

Updated milestone to 0.58.x since it was merged there.

@srirambv
Copy link
Contributor Author

srirambv commented Dec 11, 2018 •
edited by btlechowski
Loading

Verification passed on

Brave 0.58.11 Chromium: 71.0.3578.80 (Official Build) beta(64-bit)
Revision 2ac50e7249fbd55e6f517a28131605c9fb9fe897-refs/branch-heads/3578@{#860}
OS Linux
  • Verified context menu search uses DDG when searched from the result page

Verified passed with

Brave 0.58.11 Chromium: 71.0.3578.80 (Official Build) beta(64-bit)
Revision 2ac50e7249fbd55e6f517a28131605c9fb9fe897-refs/branch-heads/3578@{#860}
OS Mac OS X
  • Verified STR in description

Verification passed on

Brave 0.58.11 Chromium: 71.0.3578.80 (Official Build) beta (64-bit)
Revision 2ac50e7249fbd55e6f517a28131605c9fb9fe897-refs/branch-heads/3578@{#860}
OS Windows 7 x64

used STR from OP

@kjozwiak kjozwiak mentioned this issue Dec 19, 2018
Closed
@kjozwiak kjozwiak mentioned this issue Apr 3, 2020
Closed
@btlechowski btlechowski mentioned this issue Apr 3, 2020
Closed
81 tasks
This was referenced Apr 4, 2020
Closed
Closed
@GeetaSarvadnya GeetaSarvadnya mentioned this issue Apr 5, 2020
Closed
95 tasks
@btlechowski btlechowski mentioned this issue Apr 6, 2020
Closed
@theHedster theHedster mentioned this issue Apr 6, 2020
Closed
This was referenced Apr 6, 2020
Closed
Closed
Closed
@GeetaSarvadnya GeetaSarvadnya mentioned this issue Apr 8, 2020
Closed
@btlechowski btlechowski mentioned this issue Apr 8, 2020
Closed
@craigs100 craigs100 mentioned this issue Apr 8, 2020
Open
@LaurenWags LaurenWags mentioned this issue Apr 8, 2020
Closed
@btlechowski btlechowski mentioned this issue Apr 8, 2020
Closed
@ghost ghost mentioned this issue Apr 10, 2020
Closed
@Reprevise Reprevise mentioned this issue Apr 10, 2020
Open
@r3pek r3pek mentioned this issue Apr 11, 2020
Closed
@Hanyoro Hanyoro mentioned this issue Apr 12, 2020
Closed
This was referenced Apr 13, 2020
Closed
Closed
@ggrelet ggrelet mentioned this issue Apr 13, 2020
Closed
@GeetaSarvadnya GeetaSarvadnya mentioned this issue Apr 13, 2020
Closed
@btlechowski btlechowski mentioned this issue Apr 13, 2020
Closed
43 tasks
@jaredready jaredready mentioned this issue Apr 14, 2020
Closed
@simonhong simonhong mentioned this issue Apr 16, 2020
Closed
@rebron rebron mentioned this issue Apr 17, 2020
Closed
@rm210 rm210 mentioned this issue Apr 17, 2020
Open
This was referenced Apr 17, 2020
Closed
Closed
@matthewbal matthewbal mentioned this issue Apr 18, 2020
Closed
@afirmware afirmware mentioned this issue Apr 19, 2020
Closed
@leonschmidlin leonschmidlin mentioned this issue Apr 23, 2020
Closed
@uniconstructor uniconstructor mentioned this issue May 2, 2020
Open
@andersmmg andersmmg mentioned this issue May 6, 2020
Closed
@jficz jficz mentioned this issue May 30, 2020
Open
@oleyka oleyka mentioned this issue Jul 17, 2020
Closed
@srirambv srirambv mentioned this issue Oct 12, 2020
Closed
@simonhong simonhong mentioned this issue Apr 15, 2021
Closed
24 tasks
@srirambv srirambv mentioned this issue May 6, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@simonhong simonhong

Labels
bug feature/private-browsing QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release/blocking release-notes/include
Projects
None yet
Milestone
0.58.x - Release (Release Channel)
Development

Successfully merging a pull request may close this issue.

Fix web search from context menu in private window(also tor) brave/brave-core
6 participants
@bbondy @kjozwiak @simonhong @srirambv @LaurenWags @btlechowski