Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Category name is missing from ad history #8646

Closed
tmancey opened this issue Mar 11, 2020 · 1 comment · Fixed by brave/brave-core#4914
Closed

Category name is missing from ad history #8646

tmancey opened this issue Mar 11, 2020 · 1 comment · Fixed by brave/brave-core#4914

Comments

@tmancey
Copy link
Contributor

tmancey commented Mar 11, 2020

Description

Steps to Reproduce

  1. View an ad notification

Actual result:

Category name is missing from Ad History

Expected result:

Category name should be shown on ad history

Reproduces how often:

Easily reproduced

Brave version (brave://version info)

Version/Channel Information:

  • Can you reproduce this issue with the current release? No
  • Can you reproduce this issue with the beta channel? Yes
  • Can you reproduce this issue with the dev channel? Yes
  • Can you reproduce this issue with the nightly channel? Yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? N/A
  • Does the issue resolve itself when disabling Brave Rewards? N/A
  • Is the issue reproducible on the latest version of Chrome? N/A

Miscellaneous Information:

@tmancey tmancey added bug priority/P2 A bad problem. We might uplift this to the next planned release. QA/Yes feature/ads labels Mar 11, 2020
@tmancey tmancey self-assigned this Mar 11, 2020
@tmancey tmancey added priority/P1 A very extremely bad problem. We might push a hotfix for it. and removed priority/P2 A bad problem. We might uplift this to the next planned release. labels Mar 11, 2020
@tmancey tmancey added this to the 1.8.x - Nightly milestone Mar 13, 2020
@LaurenWags
Copy link
Member

LaurenWags commented Apr 3, 2020

Verified passed with

Brave 1.7.85 Chromium: 80.0.3987.162 (Official Build) dev (64-bit)
Revision f2c5dd6138153bb0658091205bd1a1717f16081a-refs/branch-heads/3987@{#1034}
OS macOS Version 10.14.6 (Build 18G3020)
  • Verified STR from description on clean profile

Screen Shot 2020-04-03 at 12 38 28 PM

  • Verified STR from description on an upgrade profile. Viewed an ad prior to upgrade and confirmed I could see the category name in Ad History. After upgrading to 1.7.x,
    • Confirmed ad history still shows category name for ads viewed prior to upgrade
    • Confirmed ad history shows category name for ads viewed after upgrading

Screen Shot 2020-04-03 at 12 19 56 PM

Verification passed on

Brave 1.7.86 Chromium: 80.0.3987.163 (Official Build) (64-bit)
Revision e7fbe071abe9328cdce4ffedac9822435fbd3656-refs/branch-heads/3987@{#1037}
OS Windows 10 OS Version 1803 (Build 17134.1006)
  • Verified STR from description on clean profile

image

  • Verified STR from description on an upgrade profile. Viewed an ad prior to upgrade and confirmed I could see the category name in Ad History. After upgrading to 1.7.x,
    • Confirmed ad history still shows category name for ads viewed prior to upgrade
    • Confirmed ad history shows category name for ads viewed after upgrading

image

Verification passed on

Brave 1.7.86 Chromium: 80.0.3987.163 (Official Build) (64-bit)
Revision e7fbe071abe9328cdce4ffedac9822435fbd3656-refs/branch-heads/3987@{#1037}
OS Ubuntu 18.04 LTS

Verified test plan from the description

image

tmancey pushed a commit that referenced this issue Apr 9, 2020
Fixes category name is missing from ad history - 1.7.x
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants