Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

11 purchase intent weight is needed to trigger the ad #8941

Closed
btlechowski opened this issue Mar 31, 2020 · 2 comments · Fixed by brave/brave-core#5184
Closed

11 purchase intent weight is needed to trigger the ad #8941

btlechowski opened this issue Mar 31, 2020 · 2 comments · Fixed by brave/brave-core#5184
Assignees
@moritzhaller
Labels
bug QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Test-Plan-Specified QA/Yes release-notes/exclude
Milestone
1.9.x - Release

Comments

@btlechowski
Copy link

Follow up to #8047

Ad should be trigger at 10 weight

Steps to Reproduce

  1. Clean profile
  2. Connect to US
  3. Run Brave with command line: /usr/bin/brave-browser --enable-logging=stderr --vmodule=brave_ads=3 --brave-ads-staging --rewards=staging=true
  4. Enable Rewards
  5. Search for audi a4 in URL bar
  6. Reload the page 9 times
  7. Check that automotive purchase intent by make-audi in Default/ads_service/client.json is not empty and contains 10 elements
  8. Try to trigger an ad
  9. Observe the logs

Note: 11 weights will trigger the ad

Actual result:

Ad for purchase intent is not triggered
automotive purchase intent by make-audi is not added to ad categories in logs

[13047:1:0331/183429.208068:INFO:ads_impl.cc(371)] Browser state changed to unidle
[13047:1:0331/183429.213067:INFO:ads_impl.cc(1172)] No categories
[13047:1:0331/183429.213160:INFO:ads_impl.cc(1243)] Serving ad notification from untargeted category
[13047:1:0331/183429.213394:INFO:client.cc(668)] Successfully saved client state
[13047:1:0331/183429.216604:INFO:ads_impl.cc(1285)] Found 22 eligible ads
[13047:1:0331/183429.216887:INFO:ads_impl.cc(1534)] Ad notification shown:

Expected result:

purchase intent ad is shown
automotive purchase intent by make-audi is added to ad categories in logs

Reproduces how often:

100% repro rate

Brave version (brave://version info)

Brave 1.7.78 Chromium: 80.0.3987.149 (Official Build) dev (64-bit)
Revision 5f4eb224680e5d7dca88504586e9fd951840cac6-refs/branch-heads/3987_137@{#16}
OS Ubuntu 18.04 LTS

cc @brave/legacy_qa @rebron @tmancey @moritzhaller
@btlechowski btlechowski mentioned this issue Apr 1, 2020
Closed
@GeetaSarvadnya
Copy link

Reproduced on Windows 10 x64

Brave 1.7.86 Chromium: 80.0.3987.163 (Official Build) (64-bit)
Revision e7fbe071abe9328cdce4ffedac9822435fbd3656-refs/branch-heads/3987@{#1037}
OS Windows 10 OS Version 1803 (Build 17134.1006)

@moritzhaller moritzhaller self-assigned this Apr 7, 2020
@moritzhaller moritzhaller mentioned this issue Apr 7, 2020
Merged
32 tasks
@moritzhaller moritzhaller added this to the 1.9.x - Nightly milestone Apr 8, 2020
@btlechowski
Copy link
Author

btlechowski commented May 5, 2020 •
edited by LaurenWags
Loading

Verification passed on

Brave 1.9.55 Chromium: 81.0.4044.129 (Official Build) dev (64-bit)
Revision 3d71af9f5704a40b85806f4d08925db24605ba25-refs/branch-heads/4044@{#979}
OS Ubuntu 18.04 LTS

Verified test plan from brave/brave-core#5184
Verified 10 purchase intent weight is used

"automotive purchase intent by make-audi": [{
		"timestamp_in_seconds": 1588719770,
		"weight": 1
	}, {
		"timestamp_in_seconds": 1588720273,
		"weight": 1
	}, {
		"timestamp_in_seconds": 1588720280,
		"weight": 1
	}, {
		"timestamp_in_seconds": 1588720287,
		"weight": 1
	}, {
		"timestamp_in_seconds": 1588720309,
		"weight": 1
	}, {
		"timestamp_in_seconds": 1588720320,
		"weight": 1
	}, {
		"timestamp_in_seconds": 1588720385,
		"weight": 1
	}, {
		"timestamp_in_seconds": 1588720447,
		"weight": 1
	}, {
		"timestamp_in_seconds": 1588720452,
		"weight": 1
	}, {
		"timestamp_in_seconds": 1588720456,
		"
	}

Verified ad for automotive purchase intent by make-audi is shown

[8234:1:0506/012031.589495:INFO:ads_impl.cc(358)] Browser state changed to unidle
[8234:1:0506/012031.593562:INFO:ads_impl.cc(945)] Serving ad from categories:
[8234:1:0506/012031.593826:INFO:ads_impl.cc(947)]   automotive-car brands
[8234:1:0506/012031.594055:INFO:ads_impl.cc(947)]   automotive-automotive
[8234:1:0506/012031.594208:INFO:ads_impl.cc(947)]   automotive-pickup trucks
[8234:1:0506/012031.594359:INFO:ads_impl.cc(947)]   automotive purchase intent by make-audi
[8234:1:0506/012031.594547:INFO:ads_impl.cc(947)]   automotive purchase intent by category-entry luxury car
[8234:1:0506/012031.597117:INFO:ads_impl.cc(1053)] Found 1 eligible ads
[8234:1:0506/012031.597714:INFO:ads_impl.cc(1303)] Ad notification shown:
  uuid: bbd13461-39dc-4c7c-9fcf-ec7b2881ca70
  parentUuid: a9364c02-cec7-4eb4-a280-67e46238789a
  creativeInstanceId: d9dc0028-8f86-4c92-b25d-981bc1bdb903
  creativeSetId: dea8df38-27b6-4b53-a699-77629934db80
  category: automotive purchase intent by make-audi
  title: Audi
  body: Check out the best models of the year 2020
  targetUrl: https://brave.com/purchase-intent-test

Verification passed on


Brave | 1.9.63 Chromium: 81.0.4044.138 (Official Build) dev (64-bit)
-- | --
Revision | 8c6c7ba89cc9453625af54f11fd83179e23450fa-refs/branch-heads/4044@{#999}
OS | Windows 10 OS Version 1803 (Build 17134.1006)

Verified test plan from brave/brave-core#5184
Verified 10 purchase intent weight is used

"automotive purchase intent by make-audi": [
      {
        "timestamp_in_seconds": 1589277298,
        "weight": 1
      },
      {
        "timestamp_in_seconds": 1589277305,
        "weight": 1
      },
      {
        "timestamp_in_seconds": 1589277310,
        "weight": 1
      },
      {
        "timestamp_in_seconds": 1589277316,
        "weight": 1
      },
      {
        "timestamp_in_seconds": 1589277321,
        "weight": 1
      },
      {
        "timestamp_in_seconds": 1589277326,
        "weight": 1
      },
      {
        "timestamp_in_seconds": 1589277332,
        "weight": 1
      },
      {
        "timestamp_in_seconds": 1589277338,
        "weight": 1
      },
      {
        "timestamp_in_seconds": 1589277343,
        "weight": 1
      },
      {
        "timestamp_in_seconds": 1589277350,
        "weight": 1
      }
    ]
  },

[7292:15152:0512/152619.024:INFO:ads_impl.cc(359)] Browser state changed to unidle
[7292:15152:0512/152619.034:INFO:ads_impl.cc(946)] Serving ad from categories:
[7292:15152:0512/152619.034:INFO:ads_impl.cc(948)]   automotive purchase intent by make-audi
[7292:15152:0512/152619.034:INFO:ads_impl.cc(948)]   automotive purchase intent by category-entry luxury car
[7292:15152:0512/152619.036:INFO:ads_impl.cc(1054)] Found 1 eligible ads
[7292:15152:0512/152619.036:INFO:ads_impl.cc(1308)] Ad notification shown:
  uuid: f15dc22d-63da-4741-ba8e-ba6f73cb8505
  parentUuid: 97cf04ff-34aa-4a01-a4f8-33fb440c8175
  creativeInstanceId: d9dc0028-8f86-4c92-b25d-981bc1bdb903
  creativeSetId: dea8df38-27b6-4b53-a699-77629934db80
  category: automotive purchase intent by make-audi
  title: Audi
  body: Check out the best models of the year 2020
  targetUrl: https://brave.com/purchase-intent-test
[7292:15152:0512/152619.036:INFO:ad_notifications.cc(307)] Saving notifications state
[10840:10212:0512/152619.036:INFO:confirmations_impl.cc(1146)] Confirm ad:
  creativeInstanceId: d9dc0028-8f86-4c92-b25d-981bc1bdb903
  creativeSetId: dea8df38-27b6-4b53-a699-77629934db80
  category: automotive purchase intent by make-audi
  targetUrl: https://brave.com/purchase-intent-test
  geoTarget: US
  confirmationType: view

Verified passed with

Brave | 1.9.63 Chromium: 81.0.4044.138 (Official Build) dev (64-bit)
-- | --
Revision | 8c6c7ba89cc9453625af54f11fd83179e23450fa-refs/branch-heads/4044@{#999}
OS | macOS Version 10.14.6 (Build 18G3020)
  • Verified STR from description

client.json:

    "automotive purchase intent by make-audi": [
      {
        "timestamp_in_seconds": 1589284923,
        "weight": 1
      },
      {
        "timestamp_in_seconds": 1589284928,
        "weight": 1
      },
      {
        "timestamp_in_seconds": 1589284933,
        "weight": 1
      },
      {
        "timestamp_in_seconds": 1589284938,
        "weight": 1
      },
      {
        "timestamp_in_seconds": 1589284943,
        "weight": 1
      },
      {
        "timestamp_in_seconds": 1589284949,
        "weight": 1
      },
      {
        "timestamp_in_seconds": 1589284954,
        "weight": 1
      },
      {
        "timestamp_in_seconds": 1589284957,
        "weight": 1
      },
      {
        "timestamp_in_seconds": 1589284963,
        "weight": 1
      },
      {
        "timestamp_in_seconds": 1589284968,
        "weight": 1
      }
    ]

Confirmed ad was served as expected w/ weight of 10:

[4393:775:0512/080405.649479:INFO:ads_impl.cc(946)] Serving ad from categories:
[4393:775:0512/080405.649683:INFO:ads_impl.cc(948)]   automotive purchase intent by make-audi
[4393:775:0512/080405.649849:INFO:ads_impl.cc(948)]   automotive purchase intent by category-entry luxury car
[4393:775:0512/080405.651682:INFO:ads_impl.cc(1054)] Found 1 eligible ads
[4393:775:0512/080405.651907:INFO:ads_impl.cc(1308)] Ad notification shown:
  uuid: f6f3888f-a319-4fe0-a6ad-171947323de0
  parentUuid: 04071f7a-9f9d-4a15-a044-3e173d638326
  creativeInstanceId: d9dc0028-8f86-4c92-b25d-981bc1bdb903
  creativeSetId: dea8df38-27b6-4b53-a699-77629934db80
  category: automotive purchase intent by make-audi
  title: Audi
  body: Check out the best models of the year 2020
  targetUrl: https://brave.com/purchase-intent-test
[4393:775:0512/080405.652073:INFO:ad_notifications.cc(307)] Saving notifications state
[4392:775:0512/080405.653620:INFO:confirmations_impl.cc(1146)] Confirm ad:
  creativeInstanceId: d9dc0028-8f86-4c92-b25d-981bc1bdb903
  creativeSetId: dea8df38-27b6-4b53-a699-77629934db80
  category: automotive purchase intent by make-audi
  targetUrl: https://brave.com/purchase-intent-test
  geoTarget: US
  confirmationType: view

@tmancey tmancey added this to Ads Jun 10, 2024
@tmancey tmancey moved this to Done in Ads Jun 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@moritzhaller moritzhaller

Labels
bug QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Test-Plan-Specified QA/Yes release-notes/exclude
Projects
Ads
Archived in project
Milestone
1.9.x - Release
Development

Successfully merging a pull request may close this issue.

Fix 11 purchase intent weight is needed to trigger the ad brave/brave-core
4 participants
@moritzhaller @LaurenWags @btlechowski @GeetaSarvadnya