Skip to content

Changelog URL is incorrect #9415

@leonschmidlin

Description

@leonschmidlin

Test plan

  1. Do install as non-admin user on macOS for an older version of Brave, as described in Software update popup should not be presented during Sparkle update process #9562 (comment)
  2. Check for updates
  3. URL shown in update modal should be correct

Description

The Brave Software Update prompt shows the old changelog URL "https://github.com/brave/brave-browser/blob/master/CHANGELOG.md" instead of the new "CHANGELOG_DESKTOP.md" or "CHANGELOG_ANDROID.md".

Steps to Reproduce

Get a Brave Software update prompt on update and try to open the link, "CHANGELOG.md" does not exist.
Try to open the URL of changelog_url in brave-core/script/lib/omaha.py.

Actual result:

Screenshot 2020-04-23 at 14 03 06

Expected result:

Adjusted URL to the respective changelog.

Reproduces how often:

Easily reproduced

Brave version (brave://version info)

Brave | 1.7.92 Chromium: 80.0.3987.163 (Official Build) (64-bit)
Revision | e7fbe071abe9328cdce4ffedac9822435fbd3656-refs/branch-heads/3987@{#1037}
OS | macOS Version 10.15.4 (Build 19E287)

Version/Channel Information:

Current release

Metadata

Metadata

Assignees

Type

No type

Projects

No projects

Relationships

None yet

Development

No branches or pull requests

Issue actions