Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HTTPSE toggle not working correctly #9099

Closed
LaurenWags opened this issue Apr 8, 2020 · 2 comments
Closed

HTTPSE toggle not working correctly #9099

LaurenWags opened this issue Apr 8, 2020 · 2 comments
Assignees
Labels
bug feature/https-everywhere Issues related to the HTTPS Everywhere component of Shields QA/Yes regression

Comments

@LaurenWags
Copy link
Member

Description

If you're on a site (like https://https-everywhere.badssl.com/) and you toggle HTTPSE off from shields, page still shows that HTTPSE is enabled even if you refresh the page.

This does not reproduce on 1.5.123.

Steps to Reproduce

  1. Clean profile 1.7.86.
  2. Navigate to https://https-everywhere.badssl.com/
  3. Open shields, disable HTTPSE.

Same thing happens on a profile upgraded from 1.5.123.

Actual result:

Page still says HTTPSE is working (same thing happens even if you refresh the page.
Screen Shot 2020-04-08 at 2 34 31 PM

Expected result:

Page should indicate that HTTPSE is not working or not enabled as it does on 1.5.123:
Screen Shot 2020-04-08 at 2 33 10 PM

Reproduces how often:

easily

Brave version (brave://version info)

Brave 1.7.86 Chromium: 80.0.3987.163 (Official Build) (64-bit)
Revision e7fbe071abe9328cdce4ffedac9822435fbd3656-refs/branch-heads/3987@{#1037}
OS macOS Version 10.14.6 (Build 18G3020)

Version/Channel Information:

  • Can you reproduce this issue with the current release? does not reproduce on 1.5.123
  • Can you reproduce this issue with the beta channel? yes
  • Can you reproduce this issue with the dev channel? yes
  • Can you reproduce this issue with the nightly channel? yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields?
  • Does the issue resolve itself when disabling Brave Rewards?
  • Is the issue reproducible on the latest version of Chrome?

Miscellaneous Information:

cc @rebron @brave/legacy_qa

@LaurenWags LaurenWags added bug QA/Yes regression feature/https-everywhere Issues related to the HTTPS Everywhere component of Shields labels Apr 8, 2020
@btlechowski
Copy link

Reproduced on Linux

Brave 1.7.86 Chromium: 80.0.3987.163 (Official Build) (64-bit)
Revision e7fbe071abe9328cdce4ffedac9822435fbd3656-refs/branch-heads/3987@{#1037}
OS Ubuntu 18.04 LTS

image

bsclifton added a commit to brave/brave-core that referenced this issue Apr 8, 2020
Fixes brave/brave-browser#9099
Unfixes brave/brave-browser#4381

--------

Revert "Merge pull request #4537 from jonathanKingston/bug-4381"

This reverts commit 86bf5ed, reversing
changes made to affeac4.
@bsclifton bsclifton self-assigned this Apr 8, 2020
@bsclifton
Copy link
Member

There is a regression with the website itself - which happened starting with brave/brave-core#4537

However- the functionality is working as expected 😄 Thanks to @fmarier for the following test plan, which I also ran through and verified

I tested it successfully in Beta like this:

  1. Open http://https-everywhere.badssl.com/ (you then get redirected to https://https-everywhere.badssl.com/).
  2. Open shields, disable HTTPSE.
  3. Open http://https-everywhere.badssl.com/ (you do not redirected).

I believe we should close this as expected behavior

@bbondy bbondy added this to the 1.9.x - Release milestone Jun 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug feature/https-everywhere Issues related to the HTTPS Everywhere component of Shields QA/Yes regression
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants