Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Android] Follow up of #9657 - Promotion notification is not cleared when error happens #10330

Closed
GeetaSarvadnya opened this issue Jun 17, 2020 · 1 comment

Comments

@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Jun 17, 2020

Description

Follow up of #9657 - Promotion notification is not cleared when error happens

Steps to reproduce

  1. Clean profile 1.10.92
  2. Enable staging flag
  3. Enable rewards
  4. Open Panel
  5. Before claiming promotion turn OFF Internet/Wifi
  6. Press "Claim" button.
  7. Observe a message "Oops, something is wrong. Please try again later." (expected)
  8. Click on Ok button in the error message shows the Claim option again ( NOT expected I guess)
  9. Click on Claim shows the error message on BR panel as ``Uh oh! The Brave Rewards server is not responding, We will fix this as soon as possible` (expected)

Note: Could be related to low-end devices only.

Actual result

Promotion notification is not cleared when error happens
https://drive.google.com/open?id=1TzF7NjtYKAXH0hYyFsBx8Gj8UHEahFvK

Expected result

Promotion notification should be cleared when error happens

Issue reproduces how often

80% reproducible rate

Issue happens on

  • Current Play Store version? No
  • Beta build? No

Device details

  • Install type (ARM, x86): ARM
  • Device (Phone, Tablet, Phablet): Samsung Galaxy J3
  • Android version: 5.1.1

Brave version

1.10.92

Website problems only

  • Does the issue resolve itself when disabling Brave Shields? NA
  • Does the issue resolve itself when disabling Brave Rewards? NA
  • Is the issue reproducible on the latest version of Chrome? NA

Additional information

cc: @brave/legacy_qa @NejcZdovc

@GeetaSarvadnya
Copy link
Author

Step 8 is expected discussed with @NejcZdovc via slack https://bravesoftware.slack.com/archives/C0816QH3R/p1592387955310800
Closing the issue as it works fine

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant