[Android] Promotion notification is not cleared when error happens

[NejcZdovc]

Description

User clicks on ad claim button in the panel. Error happens in claim flow (for this particular case in unblinding code) but user don't receive any feedback, just spinner.

Steps to reproduce

Actual result

Expected result

If there is any error in claim flow we need to pass this back to the user and clear notification. So when we fetch promotions next time we get an actual result from the server and not something that is cached

Issue reproduces how often

Issue happens on

• Current Play Store version?
• Beta build?

Device details

• Install type (ARM, x86):
• Device (Phone, Tablet, Phablet):
• Android version:

Brave version

Website problems only

• Does the issue resolve itself when disabling Brave Shields?
• Does the issue resolve itself when disabling Brave Rewards?
• Is the issue reproducible on the latest version of Chrome?

Additional information

[gdregalo]

@NejcZdovc
If multiple promotions are available, dismissing a promotion UI will open another promotion ready to be claimed. Is it safe to start the second claim while the first one is still being processed?

[NejcZdovc]

yes it's safe

[GeetaSarvadnya]

1+ https://community.brave.com/t/the-claim-bat-button-is-gone-but-i-didnt-receive-last-months-reward/125922/2

[btlechowski]

Verification passed on BraveModernarm v1.10.92 on Samsung Galaxy Tab S5e (Android 9.0)

Verified test plan from brave/brave-core#5520
Error message after tapping Claim Grant

Error message after showing Rewards panel

Verification passed on Samsung Galaxy J3 version 5.1.1 running BraveModernarm 1.10.92.apk

• Verified test plan from [Android] Promotion notification is not cleared when error happens. brave-core#5520
• Verified that Oops, something is wrong, Please tea again later message is shown after pressing Claim
  
• Click on OK button in the above error message shows the Claim button again - Logged [Android] Follow up of #9657 - Promotion notification is not cleared when error happens #10330
• Verified click on claim option shows the error message on BR panel as Uh oh! The Brave Rewards server is not responding, We will fix this as soon as possible