Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Android] Location service message in Search engines settings #10713

Closed
SergeyZhukovsky opened this issue Jul 13, 2020 · 1 comment · Fixed by brave/brave-core#6065
Closed

Comments

@SergeyZhukovsky
Copy link
Member

Description

We have a Location is allowed or not allowed message under a search engine, it does nothing as we don't let to know a location until a user allows that. This message is related to the current device location service message.

Steps to reproduce

Go to Settings->Standard tab and click on any search engine

Actual result

Observe the message

Expected result

We should not show the message

Issue reproduces how often

Always

Issue happens on

  • Current Play Store version? yes
  • Beta build? yes

Device details

  • Install type (ARM, x86):
  • Device (Phone, Tablet, Phablet):
  • Android version:

Brave version

Website problems only

  • Does the issue resolve itself when disabling Brave Shields?
  • Does the issue resolve itself when disabling Brave Rewards?
  • Is the issue reproducible on the latest version of Chrome?

Additional information

@srirambv
Copy link
Contributor

Verification passed on OnePlus 6T with Android 10 running 1.13.81 x64 build

  • Verified location service message is removed from both normal and private search setting
Standard Tab Private Tab
image image

Verification passed on Samsung Tab A with Android 10 running 1.13.81 x64 build

  • Verified location service message is removed from both normal and private search setting
Standard Tab Private Tab
image image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants