Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

removes unneeded location service message on Android #6065

Merged
merged 1 commit into from
Jul 13, 2020

Conversation

SergeyZhukovsky
Copy link
Member

Resolves brave/brave-browser#10713

Submitter Checklist:

Test Plan:

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.

@SergeyZhukovsky SergeyZhukovsky added CI/skip-linux CI/skip-macos-x64 Do not run CI builds for macOS x64 CI/skip-ios Do not run CI builds for iOS labels Jul 13, 2020
@SergeyZhukovsky SergeyZhukovsky added this to the 1.13.x - Nightly milestone Jul 13, 2020
@SergeyZhukovsky SergeyZhukovsky self-assigned this Jul 13, 2020
Copy link
Contributor

@emerick emerick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@samartnik samartnik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@SergeyZhukovsky
Copy link
Member Author

CI failed on a knows unit tests problem that are not related to that PR.

@SergeyZhukovsky SergeyZhukovsky merged commit b3b3f51 into master Jul 13, 2020
@SergeyZhukovsky SergeyZhukovsky deleted the android_remove_location_message branch July 13, 2020 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/skip-ios Do not run CI builds for iOS CI/skip-macos-x64 Do not run CI builds for macOS x64
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Android] Location service message in Search engines settings
3 participants