Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Desktop] Show estimated conversion value in confirm trade window #10756

Closed
srirambv opened this issue Jul 15, 2020 · 1 comment · Fixed by brave/brave-core#6094
Closed

[Desktop] Show estimated conversion value in confirm trade window #10756

srirambv opened this issue Jul 15, 2020 · 1 comment · Fixed by brave/brave-core#6094

Comments

@srirambv
Copy link
Contributor

Description

Right now we only show price per unit in the confirm trade window. We should also show estimated conversion value in confirm trade window so that price per unit doesn't confuse with the estimated price that they are getting

Actual result:

image

Expected result:

Show estimated conversation price to make it more clear

Reproduces how often:

Easy

Brave version (brave://version info)

Brave 1.13.16 Chromium: 84.0.4147.89 (Official Build) nightly (64-bit)
Revision 19abfe7bcba9318a0b2a6bc6634a67fc834aa592-refs/branch-heads/4147@{# 852}
OS Linux

Version/Channel Information:

  • Can you reproduce this issue with the current release? NA
  • Can you reproduce this issue with the beta channel? NA
  • Can you reproduce this issue with the dev channel? NA
  • Can you reproduce this issue with the nightly channel? Yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? NA
  • Does the issue resolve itself when disabling Brave Rewards? NA
  • Is the issue reproducible on the latest version of Chrome? NA

Miscellaneous Information:

@srirambv
Copy link
Contributor Author

Verification passed on

Brave 1.14.61 Chromium: 85.0.4183.69 (Official Build) dev (64-bit)
Revision 4554ea1a1171bd8d06951a4b7d9336afe6c59967-refs/branch-heads/4183@{#1426}
OS Windows 10 OS Version 1809 (Build 17763.1397)
  • Verified total conversion value is shown in the trade window
    image

Verification passed on

Brave 1.14.61 Chromium: 85.0.4183.69 (Official Build) dev (64-bit)
Revision 4554ea1a1171bd8d06951a4b7d9336afe6c59967-refs/branch-heads/4183@{#1426}
OS Linux
  • Verified total conversion value is shown in the trade window
    image

Verification passed on

Brave 1.14.61 Chromium: 85.0.4183.69 (Official Build) dev (64-bit)
Revision 4554ea1a1171bd8d06951a4b7d9336afe6c59967-refs/branch-heads/4183@{#1426}
OS macOS Version 10.15.5 (Build 19F101)
  • Verified total conversion value is shown in the trade window
    image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants