Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Android] Bytecode patch is not applied to SearchEngineAdapter in release #10773

Closed
samartnik opened this issue Jul 16, 2020 · 2 comments · Fixed by brave/brave-core#6102
Closed

[Android] Bytecode patch is not applied to SearchEngineAdapter in release #10773

samartnik opened this issue Jul 16, 2020 · 2 comments · Fixed by brave/brave-core#6102
Assignees
@samartnik
Labels
OS/Android Fixes related to Android browser functionality QA Pass - Android ARM QA Pass - Android Tab QA/Test-Plan-Specified QA/Yes release-notes/include
Milestone
1.13.x - Release #1

Comments

@samartnik
Copy link
Contributor

Description

There is crash when try open Search engine options.

2020-07-16 14:44:26.580 6321-6321/? E/AndroidRuntime: FATAL EXCEPTION: main
    Process: com.brave.browser, PID: 6321
    java.lang.NoSuchMethodError: No super method getPermissionsLinkMessage(Ljava/lang/String;)I in class Ln51; or its super classes (declaration of 'n51' appears in base.apk)

Steps to reproduce

  1. Try open Search engine options
  2. It crashes

Actual result

It crashes

Expected result

No crashes

Issue reproduces how often

Issue happens on

  • Current Play Store version? no
  • Beta build? no

Device details

  • Install type (ARM, x86):
  • Device (Phone, Tablet, Phablet):
  • Android version:

Brave version

1.13.x

Website problems only

  • Does the issue resolve itself when disabling Brave Shields?
  • Does the issue resolve itself when disabling Brave Rewards?
  • Is the issue reproducible on the latest version of Chrome?

Additional information
@samartnik samartnik added OS/Android Fixes related to Android browser functionality QA/Yes release-notes/include labels Jul 16, 2020
@samartnik
Copy link
Contributor Author

Test plan: follow STR

@samartnik samartnik self-assigned this Jul 16, 2020
@samartnik samartnik mentioned this issue Jul 16, 2020
Merged
32 tasks
@samartnik samartnik added this to the 1.13.x - Nightly milestone Jul 23, 2020
This was referenced Aug 21, 2020
Closed
Closed
Closed
@srirambv
Copy link
Contributor

Verification passed on OnePlus 6T with Android 10 running 1.13.81 x64 build

  • Verified no crash when opening search settings
  • Verified changing search engine doesn't cause any crash

Verification passed on Samsung Tab A with Android 10 running 1.13.81 x64 build

  • Verified no crash when opening search settings
  • Verified changing search engine doesn't cause any crash

@srirambv srirambv mentioned this issue Sep 4, 2020
Closed
@kjozwiak kjozwiak mentioned this issue Sep 9, 2020
Merged
28 tasks
@srirambv srirambv mentioned this issue Sep 9, 2020
Closed
19 tasks
srirambv added a commit to srirambv/brave-browser that referenced this issue Sep 10, 2020
@srirambv
Remove brave#10773
6b916aa
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@samartnik samartnik

Labels
OS/Android Fixes related to Android browser functionality QA Pass - Android ARM QA Pass - Android Tab QA/Test-Plan-Specified QA/Yes release-notes/include
Projects
None yet
Milestone
1.13.x - Release #1
Development

Successfully merging a pull request may close this issue.

[Android] Fix for bytecode changes for SearchEngineAdapter brave/brave-core
2 participants
@srirambv @samartnik