Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Android] Remove unused code for BottomSheetBehavior #10865

Closed
samartnik opened this issue Jul 22, 2020 · 2 comments · Fixed by brave/brave-core#6180
Closed

[Android] Remove unused code for BottomSheetBehavior #10865

samartnik opened this issue Jul 22, 2020 · 2 comments · Fixed by brave/brave-core#6180
Assignees
@samartnik
Labels
OS/Android Fixes related to Android browser functionality QA Pass - Android ARM QA Pass - Android Tab QA/Test-Plan-Specified QA/Yes release-notes/exclude
Milestone
1.13.x - Release #1

Comments

@samartnik
Copy link
Contributor

Description

We have unused code for BottomSheetBehavior, that relies on resources that are deleted in cr86. We just need to delete it.

Steps to reproduce

Actual result

Expected result

Issue reproduces how often

Issue happens on

  • Current Play Store version?
  • Beta build?

Device details

  • Install type (ARM, x86):
  • Device (Phone, Tablet, Phablet):
  • Android version:

Brave version

Website problems only

  • Does the issue resolve itself when disabling Brave Shields?
  • Does the issue resolve itself when disabling Brave Rewards?
  • Is the issue reproducible on the latest version of Chrome?

Additional information
@samartnik samartnik added the OS/Android Fixes related to Android browser functionality label Jul 22, 2020
@samartnik samartnik self-assigned this Jul 22, 2020
@samartnik
Copy link
Contributor Author

samartnik commented Jul 22, 2020 •
edited
Loading

Test plan:

  1. Open NTP with sponsored image for the first time.
  2. It will show the bottom banner and then click learn more.
    device-2020-07-22-163449
  3. It should open bottomsheet dialog.
    device-2020-07-22-164111

@samartnik samartnik mentioned this issue Jul 22, 2020
Merged
32 tasks
@samartnik samartnik added this to the 1.13.x - Nightly milestone Jul 23, 2020
This was referenced Aug 21, 2020
Closed
Closed
Closed
@srirambv
Copy link
Contributor

Verification passed on OnePlus 6T with Android 10 running 1.13.81 x64 build

Verification passed on Samsung Tab A with Android 10 running 1.13.81 x64 build

@srirambv srirambv mentioned this issue Sep 9, 2020
Closed
19 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@samartnik samartnik

Labels
OS/Android Fixes related to Android browser functionality QA Pass - Android ARM QA Pass - Android Tab QA/Test-Plan-Specified QA/Yes release-notes/exclude
Projects
None yet
Milestone
1.13.x - Release #1
Development

Successfully merging a pull request may close this issue.

[Android] Removed unused code for BottomSheetBehavior brave/brave-core
2 participants
@srirambv @samartnik