Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Android] Inconsistent decimal representaion on rewards #10874

Closed
srirambv opened this issue Jul 23, 2020 · 8 comments · Fixed by brave/brave-core#6275
Closed

[Android] Inconsistent decimal representaion on rewards #10874

srirambv opened this issue Jul 23, 2020 · 8 comments · Fixed by brave/brave-core#6275
Assignees
Labels

Comments

@srirambv
Copy link
Contributor

Description

Inconsistent decimal representaion on rewards

Steps to reproduce

  1. Install 1.11.8 build
  2. Enable rewards
  3. 3 decimal values are not shown in all the screens

Actual result

Tips banner Recurring tip Onetime tip Rewards panel 0 balance Grant details
image image image image image image

Expected result

All rewards screen should have 3 decimal values

Issue reproduces how often

Easy

Issue happens on

  • Current Play Store version? NA
  • Beta build? Yes

Device details

  • Install type (ARM, x86): ARM
  • Device (Phone, Tablet, Phablet): Phone
  • Android version: 10

Brave version

1.11.98

Website problems only

  • Does the issue resolve itself when disabling Brave Shields? NA
  • Does the issue resolve itself when disabling Brave Rewards? JNA
  • Is the issue reproducible on the latest version of Chrome? NA

Additional information

Follow up to #10028
cc: @tmancey @anthonypkeane

@srirambv srirambv added feature/rewards QA/Yes release-notes/exclude OS/Android Fixes related to Android browser functionality ARM Android ARM related issues labels Jul 23, 2020
@srirambv srirambv added this to the Android 1.11.x - Release milestone Jul 23, 2020
@deeppandya
Copy link

@anthonypkeane updated the changes but i can't verify it as the staging is not working right now. i will test it again once i can fund the wallet.

@deeppandya
Copy link

Screenshot_20200730-161131_Brave
Screenshot_20200730-161144_Brave
Screenshot_20200730-161156_Brave
Screenshot_20200730-161212_Brave
Screenshot_20200730-161230_Brave

@srirambv
Copy link
Contributor Author

@deeppandya the BAT value in selector should also have 3 decimal values

@deeppandya
Copy link

@srirambv @anthonypkeane i think we should update BAT value selector to 3 decimal points as it's an iteger value and it won't fit in the UI. we might need to update the UI

@anthonypkeane
Copy link

@jamesmudgett for ideas

@anthonypkeane
Copy link

@deeppandya the BAT value in selector should also have 3 decimal values

Yes, add the 3 decimal places. Pls look at iOS for reference.

@deeppandya
Copy link

Okay @anthonypkeane it's Done
Screenshot_20200804-145512_Brave

@srirambv
Copy link
Contributor Author

Verification passed on OnePlus 6T with Android 10 running 1.12.112 x64 build

  • Verified correct decimal representation is shown in the following screens
Tips banner Recurring tip Onetime tip Rewards panel 0 balance Grant details
image image image image image image

Verification passed on Samsung Tab A with Android 10 running 1.12.112 x64 build

  • Verified correct decimal representation is shown in the following screens
Tips banner Recurring tip Onetime tip Rewards panel 0 balance Grant details
image image image image image image

@kjozwiak kjozwiak added this to the 1.12.x - Release milestone Aug 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants