Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistent decimal dp (uplift to 1.13.x) #6375

Merged
merged 1 commit into from
Aug 10, 2020

Conversation

brave-builds
Copy link
Collaborator

@brave-builds brave-builds commented Aug 7, 2020

Uplift of #6275
Fixes brave/brave-browser#10874

Approved, please ensure that before merging:

  • You have checked CI and the builds, lint, and tests all pass or are not related to your PR.
  • You have tested your change on Nightly.
  • The PR milestones match the branch they are landing to.

After you merge:

  • The associated issue milestone is set to the smallest version that the changes is landed on.

@brave-builds brave-builds requested a review from a team August 7, 2020 22:43
@brave-builds brave-builds self-assigned this Aug 7, 2020
@brave-builds brave-builds added this to the 1.13.x - Beta milestone Aug 7, 2020
@deeppandya deeppandya force-pushed the pr6275_inconsistent_decimal_dp_1.13.x branch from 950946c to 1d9e139 Compare August 10, 2020 07:27
@kjozwiak
Copy link
Member

Looks like the binaries failed to upload in Win x64 as per https://ci.brave.com/job/pr-brave-browser-pr6275_inconsistent_decimal_dp_1.13.x-windows/1/execution/node/461/log & https://ci.brave.com/job/pr-brave-browser-pr6275_inconsistent_decimal_dp_1.13.x-windows/1/execution/node/488/log. However, this doesn't block uplift as it's not related to the specific PR and everything else passed without failures/issues.

05:41:48  upload failed: .\ to s3://****/brave-browser-build-pr/pr6275_inconsistent_decimal_dp_1.13.x/\ufffd\ufffd9 [Errno 2] No such file or directory: 
05:41:48  'C:\\13.x\\src\\out\\Release\\'
05:41:48  
05:41:48  upload failed: dist\ to s3://****/brave-browser-build-pr/pr6275_inconsistent_decimal_dp_1.13.x/\ufffd\ufffd9 [Errno 2] No such file or directory: 
05:41:48  'C:\\13.x\\src\\out\\Release\\dist\\'

Copy link
Contributor

@srirambv srirambv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving after deliberating with @brave/uplift-approvers . #6375 (comment) isn't blocking the uplift

@srirambv srirambv merged commit 68b6bb9 into 1.13.x Aug 10, 2020
@srirambv srirambv deleted the pr6275_inconsistent_decimal_dp_1.13.x branch August 10, 2020 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants