Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Desktop] Add padding to Customize text to accomodate translations #10946

Closed
rebron opened this issue Jul 27, 2020 · 3 comments · Fixed by brave/brave-core#6786
Closed

[Desktop] Add padding to Customize text to accomodate translations #10946

rebron opened this issue Jul 27, 2020 · 3 comments · Fixed by brave/brave-core#6786

Comments

@rebron
Copy link
Collaborator

rebron commented Jul 27, 2020

Description

Customize text on the NTP needs to expand to support translations.

Steps to Reproduce

  1. Go to NTP in Japanese version of Brave.
  2. Notice that the Customize translation overflows into a second line.
  3. Expected is that Customize translations fit into one line.

Actual result:

Screen Shot 2020-07-27 at 1 03 54 PM

Expected result:

One line. [tbd] for screenshot.

Reproduces how often:

easy.

Brave version (brave://version info)

Version/Channel Information:

Brave 1.12.98 Chromium: 84.0.4147.89 (Official Build) beta (64-bit)
Revision 19abfe7bcba9318a0b2a6bc6634a67fc834aa592-refs/branch-heads/4147@{#852}
OS macOS Version 10.16 (Build 20A5323l)
  • Can you reproduce this issue with the current release? yes
  • Can you reproduce this issue with the beta channel? yes
  • Can you reproduce this issue with the nightly channel? yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? n/a
  • Does the issue resolve itself when disabling Brave Rewards? n/a
  • Is the issue reproducible on the latest version of Chrome? n/a

Miscellaneous Information:

@rebron
Copy link
Collaborator Author

rebron commented Jul 27, 2020

cc: @karenkliu @ryanml @anthonypkeane

@rebron rebron added l10n priority/P2 A bad problem. We might uplift this to the next planned release. labels Jul 27, 2020
@karenkliu
Copy link

We should set the bounding box of "Customize" to fit the width of the text so it doesn't wrap in different languages.

@btlechowski
Copy link

btlechowski commented Oct 14, 2020

Verification passed on

Brave 1.17.28 Chromium: 86.0.4240.75 (Official Build) nightly (64-bit)
Revision c69c33933bfc72a159aceb4aeca939eb0087416c-refs/branch-heads/4240@{#1149}
OS Ubuntu 18.04 LTS

Verified that Customize text accommodates long translations
Japanese:
image
Polish:
image


Verification passed on


Brave | 1.17.39 Chromium: 86.0.4240.99 (Official Build) nightly (64-bit)
-- | --
Revision | 002668237e13d38aabd6d11c2d216dd22b736ff2-refs/branch-heads/4240@{#1229}
OS | Windows 10 OS Version 1903 (Build 18362.1082)

Hindi locale
image

Kannada locale
image


Verification PASSED on macOS 10.15.7 x64 using the following build:

Brave | 1.17.41 Chromium: 86.0.4240.99 (Official Build) nightly (x86_64)
-- | --
Revision | 002668237e13d38aabd6d11c2d216dd22b736ff2-refs/branch-heads/4240@{#1229}
OS | macOS Version 10.15.7 (Build 19H2)
Finland Russia Congo
Näyttökuva 2020-10-19 kello 11 45 40 ip Снимок экрана 2020-10-19 в 11 46 11 PM Screen Shot 2020-10-19 at 11 47 18 PM

Reproduced & Commented on #12194 (comment).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants