-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
When Rewards is reset ads service should shut down #11035
Labels
bug
feature/ads
OS/Desktop
priority/P1
A very extremely bad problem. We might push a hotfix for it.
QA Pass-Linux
QA Pass-macOS
QA Pass-Win64
QA/Yes
regression
release-notes/exclude
Milestone
Comments
same thing if ads is off I still see in logs |
tmancey
added
priority/P1
A very extremely bad problem. We might push a hotfix for it.
priority/P3
The next thing for us to work on. It'll ride the trains.
QA/Yes
release-notes/include
and removed
priority/P1
A very extremely bad problem. We might push a hotfix for it.
priority/P3
The next thing for us to work on. It'll ride the trains.
labels
Jul 31, 2020
This was referenced Jul 31, 2020
This was referenced Aug 3, 2020
tmancey
changed the title
[Desktop] When rewards is reset ads service should shut down
When rewards is reset ads service should shut down
Aug 5, 2020
rebron
changed the title
When rewards is reset ads service should shut down
When Rewards is reset ads service should shut down
Aug 5, 2020
Verified passed with
Verification passed on
Verification passed on
|
Removing Android for now because unfortunately there is limited ability to test this on Android right now, and most important is the general list of ads regressions that should ensure this didn't break anything. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
bug
feature/ads
OS/Desktop
priority/P1
A very extremely bad problem. We might push a hotfix for it.
QA Pass-Linux
QA Pass-macOS
QA Pass-Win64
QA/Yes
regression
release-notes/exclude
When rewards is reset we still have logs in
Rewards.log
from functions likeAdsImpl::OnTabUpdated
,AdsImpl::OnIdle
,AdsImpl::OnUnIdle
,AdNotifications::SaveState
, etc.The text was updated successfully, but these errors were encountered: