Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When Rewards is reset ads service should shut down #11035

Closed
NejcZdovc opened this issue Jul 31, 2020 · 3 comments · Fixed by brave/brave-core#6284
Closed

When Rewards is reset ads service should shut down #11035

NejcZdovc opened this issue Jul 31, 2020 · 3 comments · Fixed by brave/brave-core#6284

Comments

@NejcZdovc
Copy link
Contributor

When rewards is reset we still have logs in Rewards.log from functions like AdsImpl::OnTabUpdated, AdsImpl::OnIdle, AdsImpl::OnUnIdle, AdNotifications::SaveState, etc.

@NejcZdovc
Copy link
Contributor Author

same thing if ads is off I still see in logs confirmations_impl.cc

@tmancey tmancey self-assigned this Jul 31, 2020
@tmancey tmancey added priority/P1 A very extremely bad problem. We might push a hotfix for it. priority/P3 The next thing for us to work on. It'll ride the trains. QA/Yes release-notes/include and removed priority/P1 A very extremely bad problem. We might push a hotfix for it. priority/P3 The next thing for us to work on. It'll ride the trains. labels Jul 31, 2020
@tmancey tmancey added this to the 1.14.x - Nightly milestone Aug 3, 2020
@tmancey tmancey added the OS/Android Fixes related to Android browser functionality label Aug 5, 2020
@tmancey tmancey changed the title [Desktop] When rewards is reset ads service should shut down When rewards is reset ads service should shut down Aug 5, 2020
@rebron rebron changed the title When rewards is reset ads service should shut down When Rewards is reset ads service should shut down Aug 5, 2020
@LaurenWags
Copy link
Member

LaurenWags commented Aug 10, 2020

Verified passed with

Brave | 1.12.108 Chromium: 84.0.4147.105 (Official Build) (64-bit)
-- | --
Revision | a6b12dfad6663f13a7e16e9a42a6a4975374096b-refs/branch-heads/4147@{#943}
OS | macOS Version 10.14.6 (Build 18G3020)
  • Verified test plan from Fixes when rewards is reset ads service should shut down brave-core#6284.
  • Confirmed if rewards are reset, then Brave-Browser/Default/ads_service folder is deleted.
  • Confirmed if rewards are reset, then Brave-Browser/Default/rewards_service folder is deleted.
  • Confirmed re-enabling rewards creates these two folders again.
  • Confirmed toggling Ads off did not remove Brave-Browser/Default/ads_service or Brave-Browser/Default/rewards_service folders.
  • Confirmed no ads messages seen in logs when Ads were toggled off.
  • Confirmed if Ads are toggled off and then the browser is restarted, ads are still off after restart.
  • Confirmed Ads can be toggled on and ads messages start appearing in the logs.
  • Confirmed when Ads were toggled back on the ads panel information was not lost.
  • Confirmed when re-enabling Ads that ads were shown based on max per hour setting.

Verification passed on

Brave 1.12.108 Chromium: 84.0.4147.105 (Official Build) (64-bit)
Revision a6b12dfad6663f13a7e16e9a42a6a4975374096b-refs/branch-heads/4147@{#943}
OS Ubuntu 18.04 LTS
  • Verified test plan from Fixes when rewards is reset ads service should shut down brave-core#6284.
  • Confirmed if rewards are reset, then Brave-Browser/Default/ads_service folder is deleted.
  • Confirmed if rewards are reset, then Brave-Browser/Default/rewards_service folder is deleted.
  • Confirmed re-enabling rewards creates these two folders again.
  • Confirmed toggling Ads off did not remove Brave-Browser/Default/ads_service or Brave-Browser/Default/rewards_service folders.
  • Confirmed no ads messages seen in logs when Ads were toggled off.
  • Confirmed if Ads are toggled off and then the browser is restarted, ads are still off after restart.
  • Confirmed Ads can be toggled on and ads messages start appearing in the logs.
  • Confirmed when Ads were toggled back on the ads panel information was not lost.
  • Confirmed when re-enabling Ads that ads were shown based on max per hour setting.

Verification passed on

Brave | 1.12.108 Chromium: 84.0.4147.105 (Official Build) (64-bit)
-- | --
Revision | a6b12dfad6663f13a7e16e9a42a6a4975374096b-refs/branch-heads/4147@{#943}
OS | Windows 10 OS Version 1903 (Build 18362.959)

  • Verified test plan from Fixes when rewards is reset ads service should shut down brave-core#6284.
  • Confirmed if rewards are reset, then Brave-Browser/Default/ads_service folder is deleted.
  • Confirmed if rewards are reset, then Brave-Browser/Default/rewards_service folder is deleted.
  • Confirmed re-enabling rewards creates these two folders again.
  • Confirmed toggling Ads off did not remove Brave-Browser/Default/ads_service or Brave-Browser/Default/rewards_service folders.
  • Confirmed no ads messages seen in logs when Ads were toggled off.
  • Confirmed if Ads are toggled off and then the browser is restarted, ads are still off after restart.
  • Confirmed Ads can be toggled on and ads messages start appearing in the logs.
  • Confirmed when Ads were toggled back on the ads panel information was not lost.
  • Confirmed when re-enabling Ads that ads were shown based on max per hour setting.

@jsecretan jsecretan removed the OS/Android Fixes related to Android browser functionality label Aug 10, 2020
@jsecretan
Copy link

Removing Android for now because unfortunately there is limited ability to test this on Android right now, and most important is the general list of ads regressions that should ensure this didn't break anything.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

8 participants