Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Browser crashes when clicking on Autoplay notification #943

Closed
srirambv opened this issue Sep 4, 2018 · 6 comments
Closed

Browser crashes when clicking on Autoplay notification #943

srirambv opened this issue Sep 4, 2018 · 6 comments

Comments

@srirambv
Copy link
Contributor

srirambv commented Sep 4, 2018

Description

Browser crashes when clicking on Autoplay notification

Steps to Reproduce

  1. Launch a new profile
  2. Open a new tab and visit cnn.com
  3. Click back button when site is loaded and go back to new tab
  4. Shows Autoplay notification on new tab for cnn.com
  5. Click on Allow, browser crashes

Actual result:

autoplay1
Crash ID: 4952a5c9ccb51091

Expected result:

Should not show the autoplay notification on new tab and should not crash if clicked on the notification

Reproduces how often:

Easy

Brave version (about:brave info)

Brave 0.54.4 Chromium: 70.0.3528.4 (Official Build) dev (64-bit)
Revision 1911f781145b803e04f2d0b5b1a0146ae69fcbdc-refs/branch-heads/3528@{#9}
OS Windows

Reproducible on current release:

No

Website problems only:

  • Does the issue resolve itself when disabling Brave Shields?
  • Is the issue reproducible on the latest version of Chrome?

Additional Information

cc: @bbondy @brave/legacy_qa

@srirambv srirambv added this to the 1.x Backlog milestone Sep 4, 2018
@LaurenWags
Copy link
Member

@srirambv does not reproduce on MacOS with 0.55.3 with the following Steps:

  1. Launch a new profile
  2. Open a new tab and visit cnn.com
  3. Click back button when site is loaded and go back to new tab
  4. New tab does not show Autoplay notification for cnn.com (Once I go back to the new tab page, the autoplay notification goes away)

@srirambv
Copy link
Contributor Author

Still happens on Windows. CrashID eef6d4b66c791d58
943

@kjozwiak
Copy link
Member

kjozwiak commented Oct 4, 2018

@srirambv can you still reproduce this on Win? I tried following the gif and STR but got the same results as @LaurenWags. I'm not receiving the Autoplay notification that I'm seeing in the gif. Was using 0.55.10 Chromium: 70.0.3538.22. Tried on both macOS 10.13.6 x64 & Win 10 x64 without any luck.

@srirambv
Copy link
Contributor Author

srirambv commented Oct 4, 2018

I can still reproduce if Autoplay setting is turned on from content setting. Because default setting is to block you wont see the popup under site info when you visit the site. You can crash with the following steps

  1. Clean beta profile
  2. Visit cnn.com, no notification bubble shown, URL bar shows Autoplay blocked message
  3. Enable Autoplay from Settings -> Privacy and Security -> Content Setting ->Autoplay
  4. Open a new tab and visit cnn.com, wait for it to load and show the notification popup under siteinfo
  5. Press back button, notification popup shows on newtab, click allow/block and the browser crashes
    943

@kjozwiak
Copy link
Member

kjozwiak commented Oct 4, 2018

Thanks for the updated STR @srirambv! Added OS/Linux as this is also reproducible under Linux. Couldn't reproduce under macOS 10.13.6 after several attempts.

@srirambv
Copy link
Contributor Author

This issue is not valid anymore as the autoplay bubble prompt is now replaced with autoplay notification inside URL bar. Also tried the steps on 0.59.31 and doesn't reproduce hence closing the issue

@ghost ghost mentioned this issue Aug 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants