Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crypto Wallet Dark theme second follow up [6381 & #8018] #8085

Closed
srirambv opened this issue Feb 6, 2020 · 3 comments · Fixed by brave/ethereum-remote-client#126
Closed

Comments

@srirambv
Copy link
Contributor

srirambv commented Feb 6, 2020

Description

Crypto Wallet Dark theme second follow up [6381 & #8018]

Actual result:

Back button is not visible until hover
image
Basic tab on gas price selection during transaction is not visible on dark theme
image
Account connecting dotted lines are not visible on dark theme
image
Autofill selection is still highlighting white bar in input field
image

Expected result:

All theme related issues fixed

Reproduces how often:

Easy

Brave version (brave://version info)

Component 0.1.41

Version/Channel Information:

  • Can you reproduce this issue with the current release? Yes
  • Can you reproduce this issue with the beta channel? Yes
  • Can you reproduce this issue with the dev channel? Yes
  • Can you reproduce this issue with the nightly channel? Yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields?
  • Does the issue resolve itself when disabling Brave Rewards?
  • Is the issue reproducible on the latest version of Chrome?

Miscellaneous Information:

@bbondy bbondy added this to the Ethereum Remote Client 1.0.16 milestone Feb 7, 2020
@bbondy bbondy added the priority/P2 A bad problem. We might uplift this to the next planned release. label Feb 7, 2020
@srirambv
Copy link
Contributor Author

Value not properly visible on hover
Actual
image
Expected
image

Advance gas option text is not having right theme on Windows
image


Token hover
tokenhover

Customize gas advance text
image

@srirambv
Copy link
Contributor Author

image

@srirambv
Copy link
Contributor Author

srirambv commented Feb 27, 2020

Verification passed on

Brave 1.7.16 Chromium: 80.0.3987.122 (Official Build) nightly (64-bit)
Revision cf72c4c4f7db75bc3da689cd76513962d31c7b52-refs/branch-heads/3987@{#943}
OS Linux
Component 0.1.47

image
image
image


Verification passed on

Brave 1.6.51 Chromium: 80.0.3987.116 (Official Build) dev (64-bit)
Revision dc00a510e4c2ae25c4d084cc3d946fc782249224-refs/branch-heads/3987@{#917}
OS Windows 10 OS Version 1803 (Build 17134.523)
Component 0.1.47

image
image
image

Verification passed on

Brave 1.5.102 Chromium: 80.0.3987.122 (Official Build) beta (64-bit)
Revision cf72c4c4f7db75bc3da689cd76513962d31c7b52-refs/branch-heads/3987@{#943}
OS macOS Version 10.15.1 (Build 19B88)
Component 0.1.47

Screen Shot 2020-02-28 at 2 45 29 PM

Screen Shot 2020-02-28 at 2 45 54 PM

Screen Shot 2020-02-28 at 2 45 23 PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants