Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add grant check #917

Closed
NejcZdovc opened this issue Sep 2, 2018 · 3 comments · Fixed by brave/brave-core#751
Closed

Add grant check #917

NejcZdovc opened this issue Sep 2, 2018 · 3 comments · Fixed by brave/brave-core#751

Comments

@NejcZdovc
Copy link
Contributor

Grant should be checked in the background every 24h

@NejcZdovc
Copy link
Contributor Author

you can see publisher list for an example

@LaurenWags
Copy link
Member

@NejcZdovc @jasonrsadler just to confirm, QA can't see the UGP grant checks without verbose mode flag, correct? @GeetaSarvadnya and myself tried looking in the terminal for the checks described in the test plan from brave/brave-core#751 but we don't see them. cc @kjozwiak

@LaurenWags
Copy link
Member

LaurenWags commented Nov 2, 2018

Verified passed with

Brave 0.56.8 Chromium: 70.0.3538.77 (Official Build) (64-bit)
Revision 0f6ce0b0cd63a12cb4eccea3637b1bc9a29148d9-refs/branch-heads/3538@{#1039}
OS Mac OS X

Verification Passed on

Brave 0.56.8 Chromium: 70.0.3538.77 (Official Build) (64-bit)
Revision 0f6ce0b0cd63a12cb4eccea3637b1bc9a29148d9-refs/branch-heads/3538@{#1039}
OS Linux

Verification Passed on

Brave 0.56.8 Chromium: 70.0.3538.77 (Official Build) (64-bit)
Revision 0f6ce0b0cd63a12cb4eccea3637b1bc9a29148d9-refs/branch-heads/3538@{#1039}
OS Windows

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment