Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Grant checks are now performed every 24 hours #751

Merged
merged 1 commit into from
Oct 29, 2018
Merged

Grant checks are now performed every 24 hours #751

merged 1 commit into from
Oct 29, 2018

Conversation

jasonrsadler
Copy link
Contributor

@jasonrsadler jasonrsadler commented Oct 27, 2018

Resolves brave/brave-browser#917

Ledger implementation: brave-intl/bat-native-ledger#160

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Verified that these changes build without errors on
    • Windows
    • macOS
    • Linux
  • Verified that these changes pass automated tests (npm test brave_unit_tests && npm test brave_browser_tests) on
    • Windows
    • macOS
    • Linux
  • Ran git rebase master (if needed).
  • Ran git rebase -i to squash commits (if needed).
  • Tagged reviewers and labelled the pull request as needed.
  • Request a security/privacy review as needed.
  • Add appropriate QA labels (QA/Yes or QA/No) to include the closed issue in milestone

Test Plan:

  1. Start Brave using --vmodule=*rewards*=5 and enable rewards.
  2. Quit Brave and restart
  3. Ensure that grant check is not performed (view request in terminal)
  4. Quit Brave.
  5. Open ledger state and modify last_grant_fetch_stamp to be 24 hours (or more) in the past.
  6. Start Brave and ensure that grant check is performed (view request in termainal)
  1. Start Brave using --vmodule=*rewards*=5 and enable rewards.
  2. Quit Brave and restart
  3. Ensure that grant check is not performed (view request in terminal)
  4. Start Brave and open Rewards page and ensure that grant check is performed.
  5. Open ledger-state and verify that last_grant_fetch_stamp is reset to 24 hours since opening Rewards page.

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

Updated ledger dependency
@NejcZdovc NejcZdovc merged commit 2d027a6 into brave:master Oct 29, 2018
@NejcZdovc
Copy link
Contributor

NejcZdovc commented Oct 29, 2018

master 2d027a6
0.57.x 1e33d8d
0.56.x 0365868

NejcZdovc added a commit that referenced this pull request Oct 29, 2018
Grant checks are now performed every 24 hours
NejcZdovc added a commit that referenced this pull request Oct 29, 2018
Grant checks are now performed every 24 hours
@jasonrsadler jasonrsadler deleted the grant-interval branch October 29, 2018 18:32
@jasonrsadler jasonrsadler restored the grant-interval branch October 29, 2018 18:52
@jasonrsadler jasonrsadler deleted the grant-interval branch November 2, 2018 14:04
@bbondy bbondy added this to the 0.56.x - Release milestone Jan 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add grant check
3 participants