Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

eth_signTypedData in brave crypto wallet renders without confirm button #8223

Closed
cloudonshore opened this issue Feb 12, 2020 · 1 comment · Fixed by brave/ethereum-remote-client#126
Assignees
Labels

Comments

@cloudonshore
Copy link

Description

When using JSON RPC for eth_signTypedData in brave crypto wallet the wallet renders the JSON of the message to be signed, but a confirm button isn't rendered.

Screen Shot 2020-02-12 at 6 37 35 PM

Steps to Reproduce

  1. Initialize a wallet in brave metamask with some rinkeby ETH (https://faucet.rinkeby.io/)
  2. Navigate to https://trader.development.airswap.io, and create an order for ETH -> DAI (or ETH to any other token)
  3. When signing, the bottom of the signature gets cut off, and can not be confirmed or cancelled

Actual result:

When signing, the bottom of the signature gets cut off, and can not be confirmed or cancelled

Screen Shot 2020-02-12 at 6 52 05 PM

Expected result:

The confirm and cancel buttons would be displayed, as happens here when clicking "Click here to sign some typed data": https://weijiekoh.github.io/eip712-signing-demo/index.html

Screen Shot 2020-02-12 at 6 53 21 PM

Reproduces how often:

Whenever the message is too large to be displayed in the frame, the confirm and cancel buttons get cut off. It seems that the issue is a CSS issue within the wallet that doesn't account for large signTypedData payloads.

Brave version (brave://version info)

Brave | 1.3.115 Chromium: 80.0.3987.87 (Official Build) (64-bit)
Revision | 449cb163497b70dbf98d389f54e38e85d4c59b43-refs/branch-heads/3987@{#801}
OS | macOS Version 10.14.5 (Build 18F132)

@srirambv srirambv added the feature/web3/wallet Integrating Ethereum+ wallet support label Feb 13, 2020
@bbondy bbondy added the priority/P2 A bad problem. We might uplift this to the next planned release. label Feb 14, 2020
@bbondy bbondy added this to the Ethereum Remote Client 1.0.17 milestone Feb 14, 2020
@srirambv
Copy link
Contributor

srirambv commented Feb 27, 2020

Verification passed on

Brave 1.7.16 Chromium: 80.0.3987.122 (Official Build) nightly (64-bit)
Revision cf72c4c4f7db75bc3da689cd76513962d31c7b52-refs/branch-heads/3987@{#943}
OS Linux
Component 0.1.47

image

Verification passed on

Brave 1.6.51 Chromium: 80.0.3987.116 (Official Build) dev (64-bit)
Revision dc00a510e4c2ae25c4d084cc3d946fc782249224-refs/branch-heads/3987@{#917}
OS Windows 10 OS Version 1803 (Build 17134.523)
Component 0.1.47

image
image

Verification passed on

Brave 1.5.102 Chromium: 80.0.3987.122 (Official Build) beta (64-bit)
Revision cf72c4c4f7db75bc3da689cd76513962d31c7b52-refs/branch-heads/3987@{#943}
OS macOS Version 10.15.1 (Build 19B88)
Component 0.1.47

Screen Shot 2020-02-28 at 2 41 52 PM

Screen Shot 2020-02-28 at 2 41 59 PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants