eth_signTypedData in brave crypto wallet renders without confirm button #8223
Labels
feature/ethereum-remote-client
priority/P2
A bad problem. We might uplift this to the next planned release.
QA Pass-Linux
QA Pass-macOS
QA Pass-Win64
QA/Yes
Milestone
Description
When using JSON RPC for eth_signTypedData in brave crypto wallet the wallet renders the JSON of the message to be signed, but a confirm button isn't rendered.
Steps to Reproduce
Actual result:
When signing, the bottom of the signature gets cut off, and can not be confirmed or cancelled
Expected result:
The confirm and cancel buttons would be displayed, as happens here when clicking "Click here to sign some typed data": https://weijiekoh.github.io/eip712-signing-demo/index.html
Reproduces how often:
Whenever the message is too large to be displayed in the frame, the confirm and cancel buttons get cut off. It seems that the issue is a CSS issue within the wallet that doesn't account for large signTypedData payloads.
Brave version (brave://version info)
Brave | 1.3.115 Chromium: 80.0.3987.87 (Official Build) (64-bit)
Revision | 449cb163497b70dbf98d389f54e38e85d4c59b43-refs/branch-heads/3987@{#801}
OS | macOS Version 10.14.5 (Build 18F132)
The text was updated successfully, but these errors were encountered: