Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot approve DAI loan using connected Crypto wallet in Brave #7141

Closed
Brave-Matt opened this issue Nov 27, 2019 · 2 comments · Fixed by brave/ethereum-remote-client#126
Closed

Comments

@Brave-Matt
Copy link

Description

There appears to be an overflow/scroll issue on the Crypto wallets page when attempting approve DAI transactions. The user that brought this to my attention provided the following image of the bug:
image

The area the user needs to access seems to be off-screen with no way to scroll to it.

Steps to Reproduce

[User provided steps]

Repro:

  1. Open a Vault in Maker Oasis. Take a DAI loan.
  2. Go to uniswap and try to swap the DAI. It has to be unlocked first.

Actual result:

No scroll bar appears to access the needed area of the screen.

Expected result:

To be able to scroll to required area on the page when necessary.

Reproduces how often:

N/A

Brave version (brave://version info)

Brave | 1.0.1 Chromium: 78.0.3904.108 (Official Build) (64-bit)
Revision | 4b26898a39ee037623a72fcfb77279fce0e7d648-refs/branch-heads/3904@{#889}
Windows 10

Miscellaneous Information:

Initial user report:
https://www.reddit.com/r/brave_browser/comments/e2l0f3/how_do_i_approve_this_transaction_theres_no_scroll/

@Brave-Matt Brave-Matt added the feature/web3/wallet Integrating Ethereum+ wallet support label Nov 27, 2019
@ivan-prodanov
Copy link

Let me know if you’ve got any questions. I’m the user who reported this on reddit.

@srirambv
Copy link
Contributor

srirambv commented Feb 27, 2020

Verification passed on

Brave 1.7.16 Chromium: 80.0.3987.122 (Official Build) nightly (64-bit)
Revision cf72c4c4f7db75bc3da689cd76513962d31c7b52-refs/branch-heads/3987@{#943}
OS Linux
Component 0.1.47
  • Verified able to scroll the popup connection windows

Verification passed on

Brave 1.6.51 Chromium: 80.0.3987.116 (Official Build) dev (64-bit)
Revision dc00a510e4c2ae25c4d084cc3d946fc782249224-refs/branch-heads/3987@{#917}
OS Windows 10 OS Version 1803 (Build 17134.523)
Component 0.1.47
  • Verified able to scroll the popup connection windows

Verification passed on

Brave 1.5.102 Chromium: 80.0.3987.122 (Official Build) beta (64-bit)
Revision cf72c4c4f7db75bc3da689cd76513962d31c7b52-refs/branch-heads/3987@{#943}
OS macOS Version 10.15.1 (Build 19B88)
Component 0.1.47
  • Verified able to scroll the popup connection windows

Screen Shot 2020-02-28 at 2 51 42 PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants