Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Brave Ads intermittently crashes when opening a new tab #9393

Closed
tmancey opened this issue Apr 22, 2020 · 6 comments · Fixed by brave/brave-core#6304
Closed

Brave Ads intermittently crashes when opening a new tab #9393

tmancey opened this issue Apr 22, 2020 · 6 comments · Fixed by brave/brave-core#6304
Assignees
@tmancey
Labels
bug crash feature/ads OS/Android Fixes related to Android browser functionality OS/Desktop priority/P1 A very extremely bad problem. We might push a hotfix for it. QA Pass - Android ARM QA Pass - Android Tab QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/include
Milestone
1.12.x - Release #1

Comments

@tmancey
Copy link
Contributor

tmancey commented Apr 22, 2020 •
edited
Loading

[ 00 ] Browser::Browser
[ 01 ] brave_ads::AdsServiceImpl::OnViewAdNotification
[ 02 ] bat_ads::mojom::BatAds_GetAdNotification_ForwardToCallback::Accept
[ 03 ] mojo::InterfaceEndpointClient::HandleValidatedMessage
[ 04 ] mojo::internal::MultiplexRouter::ProcessIncomingMessage
[ 05 ] mojo::internal::MultiplexRouter::ProcessTasks
[ 06 ] mojo::internal::MultiplexRouter::LockAndCallProcessTasks
[ 07 ] base::TaskAnnotator::RunTask
[ 08 ] base::sequence_manager::internal::ThreadControllerWithMessagePumpImpl::DoWorkImpl
[ 09 ] base::sequence_manager::internal::ThreadControllerWithMessagePumpImpl::DoWork
[ 10 ] base::MessagePumpGlib::Run
[ 11 ] base::sequence_manager::internal::ThreadControllerWithMessagePumpImpl::Run
[ 12 ] base::RunLoop::Run
[ 13 ] ChromeBrowserMainParts::MainMessageLoopRun
[ 14 ] content::BrowserMainLoop::RunMainMessageLoopParts
[ 15 ] content::BrowserMainRunnerImpl::Run
[ 16 ] content::BrowserMain
[ 17 ] content::ContentMainRunnerImpl::Run
[ 18 ] service_manager::Main
[ 19 ] content::ContentMain
[ 20 ] ChromeMain

https://brave.sp.backtrace.io/p/brave/triage?filters=((callstack%2Cregex%2C%22(BatAds%7CAdsService%7CAdsImpl%7CConfirmationsImpl)%22))&aggregations=((ver%2Cdistribution)%2C(guid%2Cunique)%2C(classifiers%2Chead))&fingerprint=0000000000000000000000000000000000000000000000000000000000000094
@tmancey
Copy link
Contributor Author

tmancey commented Apr 22, 2020 •
edited
Loading

2 crashes have occurred, see 8eaa4d7cc0b17d90a09bd4a562afd8c714547ce4ac52a69455e619ef6b47ff6c in backtrace.io

@tmancey tmancey added the bug label May 1, 2020
@tmancey tmancey added the priority/P3 The next thing for us to work on. It'll ride the trains. label May 5, 2020
@Durss
Copy link

Durss commented May 28, 2020

Seems like a duplicate of issue #8476
I still get between 2 to 5-6 crashes a day when a new tab opens.

@tmancey
Copy link
Contributor Author

tmancey commented May 29, 2020

@Durss Are the crashes you are experiencing when click on Brave Ad notifications to view the ad, or just general browsing please?

@Durss
Copy link

Durss commented May 29, 2020

Woops my bad i missread and didn't see it was related to ads. You can ignore my comment then sorry :)

@tmancey tmancey added priority/P2 A bad problem. We might uplift this to the next planned release. and removed priority/P3 The next thing for us to work on. It'll ride the trains. labels Jul 21, 2020
@tmancey tmancey added priority/P1 A very extremely bad problem. We might push a hotfix for it. and removed priority/P2 A bad problem. We might uplift this to the next planned release. labels Jul 31, 2020
@tmancey tmancey mentioned this issue Jul 31, 2020
Merged
32 tasks
@tmancey tmancey self-assigned this Jul 31, 2020
@tmancey tmancey added this to the 1.14.x - Nightly milestone Aug 3, 2020
This was referenced Aug 5, 2020
Merged
Merged
@LaurenWags
Copy link
Member

LaurenWags commented Aug 7, 2020 •
edited by btlechowski
Loading

Verified passed with

Brave | 1.12.108 Chromium: 84.0.4147.105 (Official Build) (64-bit)
-- | --
Revision | a6b12dfad6663f13a7e16e9a42a6a4975374096b-refs/branch-heads/4147@{#943}
OS | macOS Version 10.14.6 (Build 18G3020)

Verification passed on

Brave | 1.12.108 Chromium: 84.0.4147.105 (Official Build) (64-bit)
-- | --
Revision | a6b12dfad6663f13a7e16e9a42a6a4975374096b-refs/branch-heads/4147@{#943}
OS | Windows 10 OS Version 1903 (Build 18362.959)

Verification passed on

Brave 1.12.108 Chromium: 84.0.4147.105 (Official Build) (64-bit)
Revision a6b12dfad6663f13a7e16e9a42a6a4975374096b-refs/branch-heads/4147@{#943}
OS Ubuntu 18.04 LTS

@bbondy bbondy added OS/Android Fixes related to Android browser functionality OS/Desktop labels Aug 7, 2020
@srirambv
Copy link
Contributor

srirambv commented Aug 11, 2020 •
edited
Loading

Verification passed on OnePlus 6T with Android 10 running 1.12.111 x64 build

Verification passed on Samsung Tab A with Android 10 running 1.12.111 x64 build

@LaurenWags LaurenWags mentioned this issue Aug 11, 2020
Closed
@srirambv srirambv mentioned this issue Aug 18, 2020
Closed
@tmancey tmancey added this to Ads Jun 10, 2024
@tmancey tmancey moved this to Done in Ads Jun 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tmancey tmancey

Labels
bug crash feature/ads OS/Android Fixes related to Android browser functionality OS/Desktop priority/P1 A very extremely bad problem. We might push a hotfix for it. QA Pass - Android ARM QA Pass - Android Tab QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/include
Projects
Ads
Archived in project
Milestone
1.12.x - Release #1
Development

Successfully merging a pull request may close this issue.

Brave Ads intermittently crashes when opening a new tab brave/brave-core
8 participants
@Durss @bbondy @tmancey @kjozwiak @srirambv @LaurenWags @btlechowski @GeetaSarvadnya