Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Desktop] Sync v2 - Inconsistent bookmark structure after moving a bookmark to just deleted folder #11156

Open
btlechowski opened this issue Aug 10, 2020 · 1 comment

Comments

@btlechowski
Copy link

In a rare situation when user deletes a folder on one device and then on the other device will move a bookmark to said folder, the bookmark structure becomes different on the devices

Steps to Reproduce

  1. Clean install on DeviceA and DeviceB
  2. Establish sync chain between DeviceA and DeviceB
  3. DeviceA: Add bookmark folder FA1
  4. DeviceA: Add bookmark A1
  5. Wait for sync update
  6. DeviceB: Delete FA1 and the same time on DeviceA: Move A1 to FA1
  7. Wait for sync update

sync2_bookmark_deleted_not

Actual result:

Inconsistent bookmark structure.
image

Note: Next sync update does not fix the issue
Note: Browser restart does not fix the issue
Important: opening the orphaned bookmark fixes the issue, the bookmark is synced to another device

Expected result:

The same bookmark structure

Reproduces how often:

100% repro rate

Brave version (brave://version info)

Brave 1.12.108 Chromium: 84.0.4147.105 (Official Build) (64-bit)
Revision a6b12dfad6663f13a7e16e9a42a6a4975374096b-refs/branch-heads/4147@{#943}
OS Ubuntu 18.04 LTS

cc @brave/legacy_qa @darkdh @jsecretan @rebron

@GeetaSarvadnya
Copy link

Reproduced in windows 10 x64 - 1.12.108

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: P3, P4, & P5 backlog
Development

No branches or pull requests

3 participants